summaryrefslogtreecommitdiff
path: root/Source/Core/Common/FileUtil.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'Source/Core/Common/FileUtil.cpp')
-rw-r--r--Source/Core/Common/FileUtil.cpp37
1 files changed, 21 insertions, 16 deletions
diff --git a/Source/Core/Common/FileUtil.cpp b/Source/Core/Common/FileUtil.cpp
index 814d891c22..f0594cffcc 100644
--- a/Source/Core/Common/FileUtil.cpp
+++ b/Source/Core/Common/FileUtil.cpp
@@ -674,22 +674,26 @@ std::string GetBundleDirectory()
std::string GetExePath()
{
- static std::string dolphin_path;
- if (dolphin_path.empty())
- {
+ static const std::string dolphin_path = [] {
+ std::string result;
#ifdef _WIN32
- TCHAR dolphin_exe_path[2048];
- TCHAR dolphin_exe_expanded_path[MAX_PATH];
- GetModuleFileName(nullptr, dolphin_exe_path, ARRAYSIZE(dolphin_exe_path));
- if (_tfullpath(dolphin_exe_expanded_path, dolphin_exe_path,
- ARRAYSIZE(dolphin_exe_expanded_path)) != nullptr)
- dolphin_path = TStrToUTF8(dolphin_exe_expanded_path);
- else
- dolphin_path = TStrToUTF8(dolphin_exe_path);
+ auto dolphin_exe_path = GetModuleName(nullptr);
+ if (dolphin_exe_path)
+ {
+ std::unique_ptr<TCHAR[], decltype(&std::free)> dolphin_exe_expanded_path{
+ _tfullpath(nullptr, dolphin_exe_path->c_str(), 0), std::free};
+ if (dolphin_exe_expanded_path)
+ {
+ result = TStrToUTF8(dolphin_exe_expanded_path.get());
+ }
+ else
+ {
+ result = TStrToUTF8(*dolphin_exe_path);
+ }
+ }
#elif defined(__APPLE__)
- dolphin_path = GetBundleDirectory();
- dolphin_path =
- dolphin_path.substr(0, dolphin_path.find_last_of("Dolphin.app/Contents/MacOS") + 1);
+ result = GetBundleDirectory();
+ result = result.substr(0, result.find_last_of("Dolphin.app/Contents/MacOS") + 1);
#else
char dolphin_exe_path[PATH_MAX];
ssize_t len = ::readlink("/proc/self/exe", dolphin_exe_path, sizeof(dolphin_exe_path));
@@ -698,9 +702,10 @@ std::string GetExePath()
len = 0;
}
dolphin_exe_path[len] = '\0';
- dolphin_path = dolphin_exe_path;
+ result = dolphin_exe_path;
#endif
- }
+ return result;
+ }();
return dolphin_path;
}