summaryrefslogtreecommitdiff
path: root/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp')
-rw-r--r--Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp20
1 files changed, 12 insertions, 8 deletions
diff --git a/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp b/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp
index a26b87b46e..c2652563d1 100644
--- a/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp
+++ b/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp
@@ -5,8 +5,9 @@
#include <QSignalBlocker>
-ConfigChoice::ConfigChoice(const QStringList& options, const Config::Info<int>& setting)
- : ConfigControl(setting.GetLocation()), m_setting(setting)
+ConfigChoice::ConfigChoice(const QStringList& options, const Config::Info<int>& setting,
+ Config::Layer* layer)
+ : ConfigControl(setting.GetLocation(), layer), m_setting(setting)
{
addItems(options);
setCurrentIndex(ReadValue(setting));
@@ -25,8 +26,9 @@ void ConfigChoice::OnConfigChanged()
}
ConfigStringChoice::ConfigStringChoice(const std::vector<std::string>& options,
- const Config::Info<std::string>& setting)
- : ConfigControl(setting.GetLocation()), m_setting(setting), m_text_is_data(true)
+ const Config::Info<std::string>& setting,
+ Config::Layer* layer)
+ : ConfigControl(setting.GetLocation(), layer), m_setting(setting), m_text_is_data(true)
{
for (const auto& op : options)
addItem(QString::fromStdString(op));
@@ -36,8 +38,9 @@ ConfigStringChoice::ConfigStringChoice(const std::vector<std::string>& options,
}
ConfigStringChoice::ConfigStringChoice(const std::vector<std::pair<QString, QString>>& options,
- const Config::Info<std::string>& setting)
- : ConfigControl(setting.GetLocation()), m_setting(setting), m_text_is_data(false)
+ const Config::Info<std::string>& setting,
+ Config::Layer* layer)
+ : ConfigControl(setting.GetLocation(), layer), m_setting(setting), m_text_is_data(false)
{
for (const auto& [option_text, option_data] : options)
addItem(option_text, option_data);
@@ -57,9 +60,10 @@ void ConfigStringChoice::Update(int index)
void ConfigStringChoice::Load()
{
const QString setting_value = QString::fromStdString(ReadValue(m_setting));
-
const int index = m_text_is_data ? findText(setting_value) : findData(setting_value);
- const QSignalBlocker blocker(this);
+
+ // This can be called publicly.
+ const QSignalBlocker block(this);
setCurrentIndex(index);
}