| Age | Commit message (Collapse) | Author |
|---|
|
|
|
For thread safety, we shouldn't return any pointers or references that
can be used to mutate the state of the PPCSymbolDB. This should be the
final part of making PPCSymbolDB thread safe unless I've missed
something.
|
|
9395238 added locking in some PPCSymbolDB functions that access member
variables, but far from all. To ensure thread safety, this commit adds
the missing locking.
|
|
By building the map in a local variable and then swapping it with the
member variable, we avoid the need to hold a lock while building the
map.
|
|
as it will be needing a mutex.
Cleanup loading code and reduce amount of signals.
On boot. allow previously loaded map to be kept, if its filename matches. Useful for restarting a game with a large symbol map.
|
|
instructions, or small groups of instructions.
Notes are separate from function symbols, and can be searched separately.
Unlike functions, notes of different length can overlap each other.
In the instruction window, a note will always display over the function symbol.
|
|
|
|
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
|
|
Continues the migration of our code over to the fmt logger.
|
|
These strings are only used for comparison against other strings, so a
string view can be used here.
|
|
Otherwise DolphinQt will have a stale symbol list and
you can get nullptr dereferences when trying to use it.
|
|
Moves more common code into the Common namespace where it belongs.
|
|
Given this is a class with non-trivial data-members, it's preferable to
default the constructor and destructor in the cpp file.
|
|
Normalizes variable naming so that it adheres to our coding style
While we're at it do minor cleanup relating to modified lines
|
|
|
|
Given a std::map can't have duplicate keys, iterating over the map
explicitly isn't necessary, and find() can just be used instead.
Also, instead of manually calling push_back() for every entry to
be added, the range constructor of std::vector can be used instead to add
the whole range all at once.
|
|
|
|
|
|
|
|
This changes GetSymbolFromName to not require the passed name to
completely match with the symbol name. Instead, we now match
against the stripped symbol name (i.e. only the function name).
This fixes a regression introduced by #4160, which prevented
HLE::PatchFunctions() from working properly.
|
|
|
|
|
|
not the variable name
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also changes some function params, but this is ok.
Some simplifications were also able to be made (ie. killing off strcmps with ==, etc).
|
|
and s/\bNULL\b/nullptr/g for *.cpp/h/mm files not compiled on my machine
|
|
and some manual adjustments
|
|
detected by this change).
|
|
|
|
|
