| Age | Commit message (Collapse) | Author |
|---|
|
Yellow squiggly lines begone!
Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes.
If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed.
The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports.
Not everything is removed, but the cleanup should be substantial enough.
Because this done on Linux, code that isn't used on it is mostly untouched.
(Hopefully no open PR is depending on these imports...)
|
|
|
|
dolphinQt: fix Qt6 deprecation warnings
|
|
MemoryWidget: Add Symbols and Notes.
|
|
Add option to hide them.
Add box to search.
Add ability to edit data symbols and notes in MemoryViewWidget.
|
|
PowerPC: Add RAII handling for breakpoint updates
|
|
|
|
Fix two bugs that occurred when viewing a memory range starting shortly
before 0xffffffff.
Bug 1: When there was at least one visible memory address at or after
0x0 none of the values would be displayed even when some of the
addresses were valid. This happened because the loop condition in
GetValues immediately returned false since m_address_range.first >
m_address_range.second, causing m_values to be empty. This in turn led
every address to be considered INVALID_MEMORY in UpdateColumns.
Bug 2: When m_address_range.second was equal to 0xffffffff GetValues
would enter an infinite loop. This happened because address would
overflow to 0 after printing the last value in the table, causing the
loop condition address <= m_address_range.second to be true forever.
|
|
|
|
bbf72e7 made a change where you can pass `false` to certain MemChecks
functions to get them to skip performing an "update" step. It was then
up to the caller to call the Update function later.
This commit changes the implementation so that, instead of the caller
passing in a boolean that controls whether a function calls Update, the
function now returns an object that on destruction will call Update.
Callers that are fine with Update being called right away can skip
storing the object in a variable and thereby call Update immediately,
and callers that want to call Update later can keep the object around.
This new design reduces the risk that someone will forget calling
Update.
|
|
Breakpoints: Fix lag when loading multiple memory breakpoints
|
|
only calling DBATUpdated() once.
|
|
|
|
is running.
|
|
reads from table updates.
Preparations for auto update while a game is running.
|
|
replace with a signal that is only sent at the correct time.
|
|
There were three distinct mechanisms for signaling breakpoint changes in DolphinQt, and the wiring had room for improvement. The behavior of these signals has been consolidated into the new `Host::PPCBreakpointsChanged` signal, which can be emitted from anywhere in DolphinQt to properly update breakpoints everywhere in DolphinQt.
This improves a few things:
- For the `CodeViewWidget` and `MemoryViewWidget`, signals no longer need to propagate through the `CodeWidget` and `MemoryWidget` (respectively) to reach their destination (incoming or outgoing).
- For the `BreakpointWidget`, by self-triggering from its own signal, it no longer must manually call `Update()` after all of the emission sites.
- For the `BranchWatchDialog`, it now has one less thing it must go through the `CodeWidget` for, which is a plus.
|
|
|
|
This is not every memory leak, just the ones that were obvious.
|
|
|
|
|
|
|
|
|
|
Allows for avoiding string copies. While we're at it, we can also mark
ConvertTextToBytes as const.
|
|
|
|
Fixes dynamically changing dpi scaling.
Load resources from svg if possible.
Currently svg support is not in Qt build in Externals,
and image files need to be added later.
|
|
|
|
Resolve GCC/Clang Warnings
|
|
|
|
|
|
|
|
|
|
bp_item/row_item/item were never deleted, and the normal Qt ownership system wasn't applying to them because they were being cloned.
|
|
|
|
This fixes a problem I was having where using frame advance with the
debugger open would frequently cause panic alerts about invalid addresses
due to the CPU thread changing MSR.DR while the host thread was trying
to access memory.
To aid in tracking down all the places where we weren't properly locking
the CPU, I've created a new type (in Core.h) that you have to pass as a
reference or pointer to functions that require running as the CPU thread.
|
|
switch [-Wswitch]
|
|
|
|
|
|
color selected item blue.
|
|
Don't re-create the table on every update.
|
|
|
|
Before, the Hex 32 display would get truncated on Linux.
|
|
|
|
centers the table on that row.
|
|
|
|
|
|
per row instead of assuming 16.
|
|
position.
|
|
clipboard.
|
|
the current mouse click.
|
