| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
PowerPC: Add functions to read/write the full timebase value
|
|
These can be moved into the RegisterColumn constructor, which avoids
potential allocations in the case a std::function would otherwise need
to allocate to hold all of it's captured data.
Also tidy up the inclusion order while we're at it.
|
|
Allows us to get rid of a silly pointer cast and deduplicate some code
from the front-end when it comes to reading the value.
|
|
Rather than introduce this handling in every system instruction that modifies
the FPSCR directly, we can instead just handle it within the data structure
instead, which avoids duplicating mask handling across instructions.
This also allows handling proper masking from the debugger register
windows themselves without duplicating masking behavior there either.
|
|
Qt/MemoryWidget: Allow operating on columns
|
|
|
|
|
|
Moves more common code into the Common namespace where it belongs.
|
|
Normalizes variable naming so that it adheres to our coding style
While we're at it do minor cleanup relating to modified lines
|
|
These aren't used to modify the data they point to, so make that
explicit. Also while we're at it, add const to any nearby variables that
can be made so.
|
|
Moves more common code into the Common namespace where it belongs
|
|
CodeView: Restore instruction added
|
|
|
|
This class effectively acted as a "discount vector", that would simply
allocate memory and then delete it in the destructor when it goes out of
scope.
We can just use a std::vector directly to reduce this boilerplate.
|
|
PowerPC: Move MMU-specifics from PowerPC.h to MMU.h
|
|
PowerPC.h at this point is pretty much a general glob of stuff, and it's
unfortunate, since it means pulling in a lot of unrelated header
dependencies and a bunch of other things that don't need to be seen by
things that just want to read memory.
Breaking this out into its own header keeps all the MMU-related stuff
together and also limits the amount of header dependencies being
included (the primary motivation for this being the former reason).
|
|
DolphinQt2: Minor changes
|
|
|
|
This host event is still useful because the emu thread will load the symbols on boot if required.
|
|
|
|
BreakpointWidget: Move variables closer to usage sites in OnLoad()
|
|
CodeViewWidget: Minor changes
|
|
Resolves -Wunused-lambda-capture warnings.
|
|
A call like ReplaceAddress(address, 0) is pretty ambiguous; so is
ReplaceAddress(address, false), so use an enum class that tells people
straight-up what the replacer is.
This also gets rid of the really weird naming, where if 'blr' is true,
we'd be replacing the address with a NOP, rather than an actual BLR
instruction, so we invert that so it actually makes sense. There's no
actual bug fixed here though, considering the OnInsert functions
specified the correct values; it's literally just weird naming.
|
|
QStringLiteral where applicable
There's no need to construct a std::string here, when there's no dynamic
elements to the text.
|
|
|
|
QBrush also accepts regular GlobalColor values as well.
|
|
In the early-out case, we now don't end up constructing two vectors
that aren't even used. It also keeps relevant code together.
|
|
It only needs to be updated when we changes the symbols, not every time the code widget updates and it does take a while to update them so this fixes some delay when updating the code window.
|
|
Putting the columns to resizeToContents causes way too much resizes per updates which can cause severe lags and even crashes. This only does one resize at the end of the columns.
|
|
|
|
widget
One, which was also possible in Wx is to add an mbp after the core stopped which shouldn't be possible as it needs to add the memcheck on the core thread which wouldn't be running. The other fix is Qt specific where it doesn't clear the breakpoints on stop.
|
|
|
|
The items were editable while you cannot edit the breakpoints at the moment and the last breakpoint deleted would not cause the row count to change to 0.
|
|
The Host_UpdateDisasmDialog was unimplemented in Qt which is required to get updates when we break. Additionally, this updates the debugger toolbar.
|
|
Not only it colors the entire row instead of just the address, but if the pc is the selected row, the pc color will overwrite the selection, this is done via a stylesheet.
|
|
This commit makes the colors hardcoded except when there is no symbols loaded, in which case, it uses the theme colors, except for the PC which is hardcoded to black on green. This makes a compromise between making use of the corespoinding theme color and the text being nicely readable on all themes.
|
|
This aligns the values to the right since It looks odd to be aligned to the left with any format other than hexadecimal. It also sets the font tot he debugger font and disallow selection as a previous commit made the selection pointless since it now relies on the current item.
|
|
It seemed impossible to SELECT an item, however, when right clicking, the CURRENT item is set to the appropriate cell, this commit makes the view use thta cell instead of the first selected one.
|
|
Qt/Debugger: Implement "JIT" widget
|
|
|
|
toStdString()
Avoids needing to iterate and append the characters in one case. This also
alters the function to not need to construct a temporary std::string
(QString's toUtf8() is sufficient, as QByteArray exposes iterators).
toStdString() is equivalent to retrieving the QString's underlying
QByteArray via calling QString's .toUtf8 member function and then
calling .toStdString() on the result of it (discarding the QByteArray
afterwords), so this just trims off an unnecessary step in the process.
This is also somewhat more indicative of the conversions going on:
toStdString() converts the underlying character sequence of a
QString to UTF-8, not strict ASCII, so we're really using a superset of
ASCII.
|
|
Gets rid of the need to cast the actual member to access information without bit shifts and masking.
|
|
DebugInterface: Watches methods added
|
|
PowerPC: Make the PowerPCState's msr member variable a UReg_MSR instance
|
|
This condition is already checked earlier in the function and exits out
if it's satisfied, meaning it'll never reach this check further down.
|
|
Gets rid of the need to construct UReg_MSR values around the the actual
member in order to query information from it (without using shifts and
masks). This makes it more concise in some areas, while helping with
readability in some other places (such as copying the ILE bit to the LE
bit in the exception checking functions).
|
|
Move Watches to Common
|
