summaryrefslogtreecommitdiff
path: root/src/code
diff options
context:
space:
mode:
authortomtee <33041004+t0mtee@users.noreply.github.com>2025-04-23 22:47:01 +0100
committerGitHub <noreply@github.com>2025-04-23 17:47:01 -0400
commit2ab028b46579f3e9c23f87a8af4e520240fdcbf0 (patch)
treeca4d17861f7fc413312219d5ae800c623b802ec9 /src/code
parentdc81d2285cfbc57d7f43892b113f1e8c41929889 (diff)
Document inconsistent empty C-button disabling bug (#1810)
* Document inconsistent empty C-button disabling bug * Fixed formatting
Diffstat (limited to 'src/code')
-rw-r--r--src/code/z_parameter.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/code/z_parameter.c b/src/code/z_parameter.c
index 4c6ac58e5..5a96c8a72 100644
--- a/src/code/z_parameter.c
+++ b/src/code/z_parameter.c
@@ -2044,6 +2044,10 @@ void Interface_UpdateButtonsPart2(PlayState* play) {
if (GET_PLAYER_FORM == player->transformation) {
for (i = EQUIP_SLOT_C_LEFT; i <= EQUIP_SLOT_C_RIGHT; i++) {
// Individual C button
+ //! @bug When C-buttons are empty, their item code is 255. However, gPlayerFormItemRestrictions's second
+ //! dimension has only been allocated 114 elements. This leads to inconsistent behaviour when checking
+ //! the status of empty C-buttons - for most forms, the C-buttons are enabled when empty, however for
+ //! Deku Link only, empty C-buttons are disabled.
if (!gPlayerFormItemRestrictions[GET_PLAYER_FORM][GET_CUR_FORM_BTN_ITEM(i)]) {
// Item not usable in current playerForm
if (gSaveContext.buttonStatus[i] != BTN_DISABLED) {