diff options
| author | engineer124 <47598039+engineer124@users.noreply.github.com> | 2024-12-21 14:15:10 +1100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-21 14:15:10 +1100 |
| commit | 4724a2b7fe5cfce5d8334643875115e68c253ec2 (patch) | |
| tree | cd8a2649265edf324a0f0d383e8158aea1b63919 /src/code | |
| parent | a8eb7e327f78b503837bca41d242384835a16f4c (diff) | |
Standardize "ActorMovement" over "ActorMove" (#1773)
* actor movement
* cleanup
* missed one
Diffstat (limited to 'src/code')
| -rw-r--r-- | src/code/z_en_hy_code.c | 4 | ||||
| -rw-r--r-- | src/code/z_player_lib.c | 5 | ||||
| -rw-r--r-- | src/code/z_skelanime.c | 27 |
3 files changed, 19 insertions, 17 deletions
diff --git a/src/code/z_en_hy_code.c b/src/code/z_en_hy_code.c index 54522d01d..86d182c66 100644 --- a/src/code/z_en_hy_code.c +++ b/src/code/z_en_hy_code.c @@ -189,8 +189,8 @@ void func_800F0BB4(EnHy* enHy, PlayState* play, EnDoor* door, s16 arg3, s16 arg4 EnHy_ChangeObjectAndAnim(enHy, play, (animIndex == 0) ? arg3 : arg4); enHy->skelAnime.baseTransl = enHy->skelAnime.jointTable[LIMB_ROOT_POS]; enHy->skelAnime.prevTransl = enHy->skelAnime.jointTable[LIMB_ROOT_POS]; - enHy->skelAnime.moveFlags |= (ANIM_FLAG_UPDATE_Y | ANIM_FLAG_1); - AnimTaskQueue_AddActorMove(play, &enHy->actor, &enHy->skelAnime, 1.0f); + enHy->skelAnime.movementFlags |= (ANIM_FLAG_UPDATE_Y | ANIM_FLAG_1); + AnimTaskQueue_AddActorMovement(play, &enHy->actor, &enHy->skelAnime, 1.0f); door->knobDoor.requestOpen = true; door->knobDoor.animIndex = animIndex; } diff --git a/src/code/z_player_lib.c b/src/code/z_player_lib.c index 81bb0cb77..2f3e06f59 100644 --- a/src/code/z_player_lib.c +++ b/src/code/z_player_lib.c @@ -2235,11 +2235,12 @@ s32 Player_OverrideLimbDrawGameplayCommon(PlayState* play, s32 limbIndex, Gfx** sPlayerCurBodyPartPos = &player->bodyPartsPos[0] - 1; if (player->transformation != PLAYER_FORM_FIERCE_DEITY) { - if (!(player->skelAnime.moveFlags & ANIM_FLAG_4) || (player->skelAnime.moveFlags & ANIM_FLAG_1)) { + if (!(player->skelAnime.movementFlags & ANIM_FLAG_4) || (player->skelAnime.movementFlags & ANIM_FLAG_1)) { pos->x *= player->ageProperties->unk_08; pos->z *= player->ageProperties->unk_08; } - if (!(player->skelAnime.moveFlags & ANIM_FLAG_4) || (player->skelAnime.moveFlags & ANIM_FLAG_UPDATE_Y)) { + if (!(player->skelAnime.movementFlags & ANIM_FLAG_4) || + (player->skelAnime.movementFlags & ANIM_FLAG_UPDATE_Y)) { pos->y *= player->ageProperties->unk_08; } } diff --git a/src/code/z_skelanime.c b/src/code/z_skelanime.c index a5fee2859..671ab8c6e 100644 --- a/src/code/z_skelanime.c +++ b/src/code/z_skelanime.c @@ -19,7 +19,7 @@ void AnimTask_Copy(struct PlayState* play, AnimTaskData* data); void AnimTask_Interp(struct PlayState* play, AnimTaskData* data); void AnimTask_CopyUsingMap(struct PlayState* play, AnimTaskData* data); void AnimTask_CopyUsingMapInverted(struct PlayState* play, AnimTaskData* data); -void AnimTask_ActorMove(struct PlayState* play, AnimTaskData* data); +void AnimTask_ActorMovement(struct PlayState* play, AnimTaskData* data); s32 sCurAnimTaskGroup; s32 sDisabledTransformTaskGroups; @@ -1121,13 +1121,13 @@ void AnimTaskQueue_AddCopyUsingMapInverted(PlayState* play, s32 vecCount, Vec3s* /** * Creates a task which will move an actor according to the translation of its root limb for the current frame. */ -void AnimTaskQueue_AddActorMove(PlayState* play, Actor* actor, SkelAnime* skelAnime, f32 moveDiffScale) { +void AnimTaskQueue_AddActorMovement(PlayState* play, Actor* actor, SkelAnime* skelAnime, f32 moveDiffScale) { AnimTask* task = AnimTaskQueue_NewTask(&play->animTaskQueue, ANIMTASK_ACTOR_MOVE); if (task != NULL) { - task->data.actorMove.actor = actor; - task->data.actorMove.skelAnime = skelAnime; - task->data.actorMove.diffScale = moveDiffScale; + task->data.actorMovement.actor = actor; + task->data.actorMovement.skelAnime = skelAnime; + task->data.actorMovement.diffScale = moveDiffScale; } } @@ -1210,9 +1210,10 @@ void AnimTask_CopyUsingMapInverted(PlayState* play, AnimTaskData* data) { /** * Move an actor according to the translation of its root limb for the current animation frame. + * The actor's current shape yaw will factor into the resulting movement. */ -void AnimTask_ActorMove(PlayState* play, AnimTaskData* data) { - AnimTaskActorMove* task = &data->actorMove; +void AnimTask_ActorMovement(PlayState* play, AnimTaskData* data) { + AnimTaskActorMovement* task = &data->actorMovement; Actor* actor = task->actor; Vec3f diff; @@ -1231,8 +1232,8 @@ typedef void (*AnimTaskFunc)(struct PlayState* play, AnimTaskData* data); */ void AnimTaskQueue_Update(PlayState* play, AnimTaskQueue* animTaskQueue) { static AnimTaskFunc sAnimTaskFuncs[ANIMTASK_MAX] = { - AnimTask_LoadPlayerFrame, AnimTask_Copy, AnimTask_Interp, AnimTask_CopyUsingMap, - AnimTask_CopyUsingMapInverted, AnimTask_ActorMove, + AnimTask_LoadPlayerFrame, AnimTask_Copy, AnimTask_Interp, AnimTask_CopyUsingMap, + AnimTask_CopyUsingMapInverted, AnimTask_ActorMovement, }; AnimTask* task = animTaskQueue->tasks; @@ -1978,7 +1979,7 @@ void SkelAnime_UpdateTranslation(SkelAnime* skelAnime, Vec3f* diff, s16 angle) { f32 sin; f32 cos; - if (skelAnime->moveFlags & ANIM_FLAG_NOMOVE) { + if (skelAnime->movementFlags & ANIM_FLAG_NOMOVE) { diff->z = 0.0f; diff->x = 0.0f; } else { @@ -1996,8 +1997,8 @@ void SkelAnime_UpdateTranslation(SkelAnime* skelAnime, Vec3f* diff, s16 angle) { skelAnime->prevTransl.z = skelAnime->jointTable[LIMB_ROOT_POS].z; skelAnime->jointTable[LIMB_ROOT_POS].z = skelAnime->baseTransl.z; - if (skelAnime->moveFlags & ANIM_FLAG_UPDATE_Y) { - if (skelAnime->moveFlags & ANIM_FLAG_NOMOVE) { + if (skelAnime->movementFlags & ANIM_FLAG_UPDATE_Y) { + if (skelAnime->movementFlags & ANIM_FLAG_NOMOVE) { diff->y = 0.0f; } else { diff->y = skelAnime->jointTable[LIMB_ROOT_POS].y - skelAnime->prevTransl.y; @@ -2008,7 +2009,7 @@ void SkelAnime_UpdateTranslation(SkelAnime* skelAnime, Vec3f* diff, s16 angle) { diff->y = 0.0f; skelAnime->prevTransl.y = skelAnime->jointTable[LIMB_ROOT_POS].y; } - skelAnime->moveFlags &= ~ANIM_FLAG_NOMOVE; + skelAnime->movementFlags &= ~ANIM_FLAG_NOMOVE; } /** |
