Fix most compiler warnings in the boot and code segments (#674)

* Less warnings in boot & code segments

* few more warnings gone

* Ran formatter

* z_view warning gone

* -> 1

* f31 -> 31

* Remove function casts

* Few more small improvements

* Separate declaration and assignment in func_80091738 and Item_Give

Co-authored-by: Thar0 <maximilianc64@gmail.com>

1 files changed, 5 insertions, 12 deletions

diff --git a/src/code/z_lib.c b/src/code/z_lib.c
index 54f90bb3b..c8ffa4fad 100644
--- a/src/code/z_lib.c
+++ b/src/code/z_lib.c
@@ -345,11 +345,8 @@ void IChain_Apply_f32div1000(u8* ptr, InitChainEntry* ichain) {
 }
 
 void IChain_Apply_Vec3f(u8* ptr, InitChainEntry* ichain) {
-    Vec3f* vec;
-    f32 val;
-
-    vec = (Vec3f*)(ptr + ichain->offset);
-    val = ichain->value;
+    Vec3f* vec = (Vec3f*)(ptr + ichain->offset);
+    f32 val = ichain->value;
 
     vec->z = val;
     vec->y = val;
@@ -357,10 +354,9 @@ void IChain_Apply_Vec3f(u8* ptr, InitChainEntry* ichain) {
 }
 
 void IChain_Apply_Vec3fdiv1000(u8* ptr, InitChainEntry* ichain) {
-    Vec3f* vec;
+    Vec3f* vec = (Vec3f*)(ptr + ichain->offset);
     f32 val;
 
-    vec = (Vec3f*)(ptr + ichain->offset);
     osSyncPrintf("pp=%x data=%f\n", vec, ichain->value / 1000.0f);
     val = ichain->value / 1000.0f;
 
@@ -370,11 +366,8 @@ void IChain_Apply_Vec3fdiv1000(u8* ptr, InitChainEntry* ichain) {
 }
 
 void IChain_Apply_Vec3s(u8* ptr, InitChainEntry* ichain) {
-    Vec3s* vec;
-    s16 val;
-
-    vec = (Vec3s*)(ptr + ichain->offset);
-    val = ichain->value;
+    Vec3s* vec = (Vec3s*)(ptr + ichain->offset);
+    s16 val = ichain->value;
 
     vec->z = val;
     vec->y = val;