diff options
| author | Tharo <17233964+Thar0@users.noreply.github.com> | 2021-02-14 00:49:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-13 19:49:40 -0500 |
| commit | f9d96d9f73ac090245a518ec04f3fa0e50655d1e (patch) | |
| tree | 9dc905fce276cbfb07a05fc2bf0883bcedddcf23 /src/code/z_view.c | |
| parent | d615ec4f31563b939f8c0dce1c20c79e137c2043 (diff) | |
Fix most compiler warnings in the boot and code segments (#674)
* Less warnings in boot & code segments
* few more warnings gone
* Ran formatter
* z_view warning gone
* -> 1
* f31 -> 31
* Remove function casts
* Few more small improvements
* Separate declaration and assignment in func_80091738 and Item_Give
Co-authored-by: Thar0 <maximilianc64@gmail.com>
Diffstat (limited to 'src/code/z_view.c')
| -rw-r--r-- | src/code/z_view.c | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/src/code/z_view.c b/src/code/z_view.c index 3374eeb5e..974191ac2 100644 --- a/src/code/z_view.c +++ b/src/code/z_view.c @@ -52,7 +52,7 @@ void View_Init(View* view, GraphicsContext* gfxCtx) { view->eye.z = -1.0f; if (D_8012ABF0) { - if (&D_8012ABF0) {} + if (D_8012ABF0 == 0) {} osSyncPrintf("\nview: initialize ---\n"); D_8012ABF0 = false; } @@ -132,9 +132,7 @@ void func_800AA550(View* view) { s32 uly; s32 lrx; s32 lry; - GraphicsContext* gfxCtx; - - gfxCtx = view->gfxCtx; + GraphicsContext* gfxCtx = view->gfxCtx; varY = ShrinkWindow_GetCurrentVal(); @@ -276,9 +274,7 @@ s32 func_800AAA9C(View* view) { Vp* vp; Mtx* projection; Mtx* viewing; - GraphicsContext* gfxCtx; - - gfxCtx = view->gfxCtx; + GraphicsContext* gfxCtx = view->gfxCtx; OPEN_DISPS(gfxCtx, "../z_view.c", 596); @@ -377,9 +373,7 @@ s32 func_800AAA9C(View* view) { s32 func_800AB0A8(View* view) { Vp* vp; Mtx* projection; - GraphicsContext* gfxCtx; - - gfxCtx = view->gfxCtx; + GraphicsContext* gfxCtx = view->gfxCtx; OPEN_DISPS(gfxCtx, "../z_view.c", 726); @@ -456,9 +450,7 @@ s32 func_800AB560(View* view) { Vp* vp; Mtx* projection; Mtx* viewing; - GraphicsContext* gfxCtx; - - gfxCtx = view->gfxCtx; + GraphicsContext* gfxCtx = view->gfxCtx; OPEN_DISPS(gfxCtx, "../z_view.c", 816); |