Fix some more GCC warnings, mark some bugs based on GCC warnings (#2309)

* Fix some more GCC warnings, mark some bugs based on GCC warnings

* Weird formatting

* Suggested changes

* More weird indentation I guess

* UNREACHABLE() macro, add missing NORETURNs to fault_n64.c

* AVOID_UB for PAL path in z_file_nameset.c

* Remove comments about return types

* Remove temp no longer needed

1 files changed, 2 insertions, 2 deletions

diff --git a/src/libu64/stackcheck.c b/src/libu64/stackcheck.c
index 596c0b411..a8b32ffce 100644
--- a/src/libu64/stackcheck.c
+++ b/src/libu64/stackcheck.c
@@ -111,7 +111,7 @@ u32 StackCheck_Check(StackEntry* entry) {
         return ret;
     } else {
         u32* last;
-        u32 used;
+        UNUSED_NDEBUG u32 used;
         u32 free;
         u32 ret;
 
@@ -143,7 +143,7 @@ u32 StackCheck_Check(StackEntry* entry) {
 
 u32 StackCheck_GetState(StackEntry* entry) {
     u32* last;
-    u32 used;
+    UNUSED_NDEBUG u32 used;
     u32 free;
     u32 ret;