Fix most compiler warnings in the boot and code segments (#674)

* Less warnings in boot & code segments

* few more warnings gone

* Ran formatter

* z_view warning gone

* -> 1

* f31 -> 31

* Remove function casts

* Few more small improvements

* Separate declaration and assignment in func_80091738 and Item_Give

Co-authored-by: Thar0 <maximilianc64@gmail.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/libultra_boot_O2/sprintf.c b/src/libultra_boot_O2/sprintf.c
index 96698b79e..386d9fa14 100644
--- a/src/libultra_boot_O2/sprintf.c
+++ b/src/libultra_boot_O2/sprintf.c
@@ -1,11 +1,11 @@
 #include "global.h"
 
-char* proutSprintf(char* dst, const char* fmt, size_t size) {
-    return (char*)memcpy(dst, fmt, size) + size;
+void* proutSprintf(void* dst, const char* fmt, u32 size) {
+    return (void*)((u32)memcpy(dst, fmt, size) + size);
 }
 
 s32 vsprintf(char* dst, const char* fmt, va_list args) {
-    s32 ret = _Printf(&proutSprintf, dst, fmt, args);
+    s32 ret = _Printf(proutSprintf, dst, fmt, args);
     if (ret > -1) {
         dst[ret] = 0;
     }
@@ -17,7 +17,7 @@ s32 sprintf(char* dst, const char* fmt, ...) {
     va_list args;
     va_start(args, fmt);
 
-    ret = _Printf(&proutSprintf, dst, fmt, args);
+    ret = _Printf(proutSprintf, dst, fmt, args);
     if (ret > -1) {
         dst[ret] = 0;
     }