Fix most compiler warnings in the boot and code segments (#674)

* Less warnings in boot & code segments

* few more warnings gone

* Ran formatter

* z_view warning gone

* -> 1

* f31 -> 31

* Remove function casts

* Few more small improvements

* Separate declaration and assignment in func_80091738 and Item_Give

Co-authored-by: Thar0 <maximilianc64@gmail.com>

1 files changed, 7 insertions, 4 deletions

diff --git a/src/libultra_boot_O2/string.c b/src/libultra_boot_O2/string.c
index cea07c253..bf059094f 100644
--- a/src/libultra_boot_O2/string.c
+++ b/src/libultra_boot_O2/string.c
@@ -1,7 +1,8 @@
 #include "global.h"
 
-const u8* strchr(const u8* str, s32 ch) {
+const char* strchr(const char* str, s32 ch) {
     u8 c = ch;
+
     while (*str != c) {
         if (*str == 0) {
             return NULL;
@@ -11,17 +12,19 @@ const u8* strchr(const u8* str, s32 ch) {
     return str;
 }
 
-size_t strlen(const u8* str) {
-    const u8* ptr = str;
+u32 strlen(const char* str) {
+    const char* ptr = str;
+
     while (*ptr) {
         ptr++;
     }
     return ptr - str;
 }
 
-void* memcpy(void* dst, const void* src, size_t size) {
+void* memcpy(void* dst, const void* src, u32 size) {
     u8* _dst = dst;
     const u8* _src = src;
+
     while (size > 0) {
         *_dst++ = *_src++;
         size--;