diff options
| author | Aurel <285191559+0Aurel@users.noreply.github.com> | 2026-05-23 17:10:58 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-05-23 17:10:58 +0200 |
| commit | 51640eb100522a3986779599f057d72c8cb9e42e (patch) | |
| tree | 96dd74c92bc9d024088cf506597973448140ec2e /config/usa | |
| parent | 0bb7400136dd84c00abdaf96c5dbdb63c02f836f (diff) | |
* Game_16 OK
* Remove unnecessary FadeControl constructor definition
* Define HW_RESET_PARAMETER_BUF macro to replace hardcoded address
* Refactor Game constructor to use proper C++ initialization
Address Yanis' review comments:
- Make Game::func_0202cf44 static with Game* parameter to allow
passing as callback pointer
- Replace raw mUnk_00c array with Game_0c class containing constructor
- Add Game_0c constructor with inline initialization calling func_ov016_0211fab8
- Add FadeControl_Derived1 class for mFadeControl member
- Use C++ initializer list in Game constructor for mModeId, mPrevModeId,
mMode, mUnk_00c, and mFadeControl
* Fix Game constructor and FadeControl initialization
- Use PAD macro in Game_0c instead of unk8 pad[]
- Pass 'this' instead of 'pad' to func_ov016_0211fab8
- Add FadeControl constructor that calls _ZN11FadeControlC2Ev
- FadeControl_Derived1 now uses empty constructor (base class ctor called automatically)
- Update mUnk_00c.pad to mUnk_00c.pad_0x00 (PAD macro creates named member)
- Add types.h include to nds/system.h
* Remove explicit call to mangled constructor symbol
- Removed _ZN11FadeControlC2Ev call from FadeControl constructor
- FadeControl now has an empty constructor (called automatically by derived classes)
- FadeControl_Derived1 uses empty constructor which calls base class ctor
* Update symbols.txt for func_0202cf44 signature change
Changed mangled name from _ZN4Game13func_0202cf44Ev to
_ZN4Game13func_0202cf44EPS_ to reflect the function becoming
static with a Game* parameter.
Diffstat (limited to 'config/usa')
| -rw-r--r-- | config/usa/arm9/symbols.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/config/usa/arm9/symbols.txt b/config/usa/arm9/symbols.txt index f46857bd..992e9c13 100644 --- a/config/usa/arm9/symbols.txt +++ b/config/usa/arm9/symbols.txt @@ -1384,7 +1384,7 @@ _ZN4Game13func_0202c97cEv kind:function(thumb,size=0x24) addr:0x0202c964 _ZN4Game3RunEv kind:function(arm,size=0x528) addr:0x0202c988 _ZN4Game13func_0202cec8Eib kind:function(thumb,size=0x6c) addr:0x0202ceb0 _ZN4Game13func_0202cf34Ev kind:function(thumb,size=0x10) addr:0x0202cf1c -_ZN4Game13func_0202cf44Ev kind:function(arm,size=0x170) addr:0x0202cf2c +_ZN4Game13func_0202cf44EPS_ kind:function(arm,size=0x170) addr:0x0202cf2c _ZN4GameD1Ev kind:function(arm,size=0x18) addr:0x0202d09c func_0202d0cc kind:function(thumb,size=0x3a) addr:0x0202d0b4 func_0202d108 kind:function(thumb,size=0x38) addr:0x0202d0f0 |