update from dtk-template - clangd :) (#66)

* update from dtk-template and start work towards using clangd

* include <a> -> "a"

* Update build.yml

* remove/add non-trivial class in union warning

1 files changed, 25 insertions, 18 deletions

diff --git a/include/DynamicLink.h b/include/DynamicLink.h
index c63c3077..b4638c68 100644
--- a/include/DynamicLink.h
+++ b/include/DynamicLink.h
@@ -1,18 +1,19 @@
 #ifndef DYNAMICLINK_H
 #define DYNAMICLINK_H
 
-#include <common.h>
-#include <m/m_dvd.h>
-#include <nw4r/db/db_mapFile.h>
-#include <rvl/OS.h>
+#include "common.h"
+#include "m/m_dvd.h"
+#include "nw4r/db/db_mapFile.h"
+#include "rvl/OS.h" // IWYU pragma: export
 
 class DbMapFile {
 public:
-    DbMapFile(): mMapFileHandle(nullptr) {}
+    DbMapFile() : mMapFileHandle(nullptr) {}
     ~DbMapFile();
 
     void RegisterOnDvd(const char *, const OSModuleInfo *);
     void Unregister();
+
 private:
     nw4r::db::MapFileHandle mMapFileHandle;
     nw4r::db::MapFile mMapFile;
@@ -23,14 +24,14 @@ private:
 struct DynamicModuleControlBase {
     /* 0x00 */ u16 mLinkCount;
     /* 0x02 */ u16 mDoLinkCount;
-    /* 0x04 */ DynamicModuleControlBase* mPrev;
-    /* 0x08 */ DynamicModuleControlBase* mNext;
+    /* 0x04 */ DynamicModuleControlBase *mPrev;
+    /* 0x08 */ DynamicModuleControlBase *mNext;
 
     /* 0x0C */ /*vtable*/
     /* 802df100 */ virtual ~DynamicModuleControlBase();
-    /* 802df340 */ virtual const char* getModuleName() const;
+    /* 802df340 */ virtual const char *getModuleName() const;
     /* 802df350 */ virtual int getModuleSize() const;
-    /* 802df360 */ virtual const char* getModuleTypeString() const;
+    /* 802df360 */ virtual const char *getModuleTypeString() const;
     /* 802df370 */ virtual void dump();
     /* 802df380 */ virtual bool do_load();
     /* 802df390 */ virtual BOOL do_load_async();
@@ -42,28 +43,34 @@ struct DynamicModuleControlBase {
     /* 802df290 */ BOOL unlink();
     /* 802df310 */ BOOL load_async();
 
-    static inline DynamicModuleControlBase* getFirstClass() { return mFirst; }
-    inline DynamicModuleControlBase* getNextClass() { return mNext; }
-    bool isLinked() const { return mLinkCount != 0; }
+    static inline DynamicModuleControlBase *getFirstClass() {
+        return mFirst;
+    }
+    inline DynamicModuleControlBase *getNextClass() {
+        return mNext;
+    }
+    bool isLinked() const {
+        return mLinkCount != 0;
+    }
 
-    static DynamicModuleControlBase* mFirst;
-    static DynamicModuleControlBase* mLast;
+    static DynamicModuleControlBase *mFirst;
+    static DynamicModuleControlBase *mLast;
 };
 
 struct DynamicModuleControl : DynamicModuleControlBase {
-    /* 802df4c0 */ virtual const char* getModuleName() const;
+    /* 802df4c0 */ virtual const char *getModuleName() const;
     /* 802df450 */ virtual ~DynamicModuleControl();
     /* 802dfb10 */ virtual int getModuleSize() const;
-    /* 802dfb70 */ virtual const char* getModuleTypeString() const;
+    /* 802dfb70 */ virtual const char *getModuleTypeString() const;
     /* 802df800 */ virtual void dump();
     /* 802df5d0 */ virtual bool do_load();
     /* 802df710 */ virtual BOOL do_load_async();
     /* 802df7a0 */ virtual bool do_unload();
     /* 802df810 */ virtual BOOL do_link();
     /* 802dfa60 */ virtual bool do_unlink();
-    /* 802df3d0 */ DynamicModuleControl(char const*, EGG::ExpHeap *);
+    /* 802df3d0 */ DynamicModuleControl(char const *, EGG::ExpHeap *);
     /* 802df4d0 */ static void initialize(EGG::ExpHeap *heap);
-    /* 802df530 */ static u32 callback(void*);
+    /* 802df530 */ static u32 callback(void *);
     void checkHeapStatus();
 
     /* 0x10 */ UNKWORD unk_16;