diff options
| author | Howard Luck <pheenoh@gmail.com> | 2026-04-11 13:54:25 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-04-11 12:54:25 -0700 |
| commit | d912857ec45a33c823331589e0067e1365e172c9 (patch) | |
| tree | 66eec5da24b85ad2020e42447b2a90a1f69450fa | |
| parent | c57a7cf98fab3623ab7b2501da51ed1d2ada70c4 (diff) | |
Fix dMsgFlow_c::event027 aParam8 buffer size (#3153)
| -rw-r--r-- | src/d/d_msg_flow.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/d/d_msg_flow.cpp b/src/d/d_msg_flow.cpp index 4648f81dc9..47ef21063e 100644 --- a/src/d/d_msg_flow.cpp +++ b/src/d/d_msg_flow.cpp @@ -2229,7 +2229,13 @@ int dMsgFlow_c::event027(mesg_flow_node_event* i_flowNode_p, fopAc_ac_c* i_speak u16 prm0; getParam(&prm0, &prm1, i_flowNode_p->params); + // !@bug aParam8 is undersized; getParam always writes 4 bytes, stomping the + // 2 bytes past the buffer. Harmless on GC/Wii (MWCC stack layout absorbs it). +#if AVOID_UB + u8 aParam8[4]; +#else u8 aParam8[2]; +#endif getParam(aParam8, i_flowNode_p->params); JUT_ASSERT(4509, (aParam8[0] >= 0 && aParam8[0] <= dSv_player_item_c::BOMB_BAG_MAX) || (aParam8[0] == 4)); |