various Z2Audio / JAudio debug cleanup (#2876)

* some JAudio work

* audio cleanup checkpoint

* checkpoint more audio cleanup

* fix symbols

* more z2 cleanup

* fix regression

* fix build

* some fixes

1 files changed, 14 insertions, 12 deletions

diff --git a/src/JSystem/JAudio2/JASDvdThread.cpp b/src/JSystem/JAudio2/JASDvdThread.cpp
index b5c31dbf4a..2de97b7978 100644
--- a/src/JSystem/JAudio2/JASDvdThread.cpp
+++ b/src/JSystem/JAudio2/JASDvdThread.cpp
@@ -1,16 +1,9 @@
-//
-// Generated By: dol2asm
-// Translation Unit: JASDvdThread
-//
-
 #include "JSystem/JSystem.h" // IWYU pragma: keep
 
 #include "JSystem/JAudio2/JASDvdThread.h"
 #include "JSystem/JAudio2/JASTaskThread.h"
 #include "JSystem/JKernel/JKRSolidHeap.h"
-#include "dolphin/types.h"
 
-/* ############################################################################################## */
 /* 80451208-80451210 000708 0004+04 2/1 0/0 0/0 .sbss            sThread__6JASDvd */
 JASTaskThread* JASDvd::sThread;
 
@@ -20,10 +13,19 @@ JASTaskThread* JASDvd::getThreadPointer() {
 }
 
 /* 8028FF04-8028FFA8 28A844 00A4+00 0/0 1/1 0/0 .text            createThread__6JASDvdFliUl */
-bool JASDvd::createThread(s32 priority, int param_1, u32 param_2) {
-    if (sThread != NULL) return false;
-    sThread = new (JASDram, 0) JASTaskThread(priority, param_1, param_2);
-    sThread->setCurrentHeap(JKRGetSystemHeap());
-	OSResumeThread(sThread->getThreadRecord());
+bool JASDvd::createThread(s32 priority, int msgCount, u32 stackSize) {
+    if (sThread != NULL) {
+        JUT_WARN_DEVICE(32, 2, "%s", "JASDvd::createThread が２回呼び出されました");
+        return false;
+    }
+
+    sThread = new (JASDram, 0) JASTaskThread(priority, msgCount, stackSize);
+    JUT_ASSERT(36, sThread);
+
+    JKRHeap* pCurrentHeap = JKRGetSystemHeap();
+    JUT_ASSERT(38, pCurrentHeap);
+
+    sThread->setCurrentHeap(pCurrentHeap);
+    sThread->resume();
 	return true;
 }