summaryrefslogtreecommitdiff
path: root/src/d/d_name.cpp
diff options
context:
space:
mode:
authorJcw87 <Jcw87@users.noreply.github.com>2023-09-15 04:15:46 -0700
committerGitHub <noreply@github.com>2023-09-15 04:15:46 -0700
commitf834379a8b60e0d3308e5aa064a910cead92b899 (patch)
tree170450153c98ff5e1ea743f38121e72e75439741 /src/d/d_name.cpp
parent4ab104f390e401c7dfdc9697374c17c223650661 (diff)
fix functions not returning values (#1926)
Diffstat (limited to 'src/d/d_name.cpp')
-rw-r--r--src/d/d_name.cpp16
1 files changed, 11 insertions, 5 deletions
diff --git a/src/d/d_name.cpp b/src/d/d_name.cpp
index d0ff478015..34f1b3dcdb 100644
--- a/src/d/d_name.cpp
+++ b/src/d/d_name.cpp
@@ -1422,17 +1422,23 @@ void dName_c::NameStrSet() {
/* 80251048-80251094 24B988 004C+00 6/6 0/0 0/0 .text getMenuPosIdx__7dName_cFUc */
s32 dName_c::getMenuPosIdx(u8 selPos) {
+ s32 result;
switch (selPos) {
case 0:
- return 0;
+ result = 0;
+ break;
case 1:
- return 1;
+ result = 1;
+ break;
case 2:
- return 2;
+ result = 2;
+ break;
case 3:
- return 3;
+ result = 3;
+ break;
}
- //!@bug UB: no default return
+ return result;
+ //!@bug UB: uninitialized default return
}
/* 80251094-8025115C 24B9D4 00C8+00 1/0 0/0 0/0 .text draw__14dDlst_NameIN_cFv */