summaryrefslogtreecommitdiff
path: root/src/f_op
diff options
context:
space:
mode:
authorLagoLunatic <LagoLunatic@users.noreply.github.com>2025-09-25 15:57:15 -0400
committerGitHub <noreply@github.com>2025-09-25 12:57:15 -0700
commitdbf6abeb90ee70aeec18695f7eb589a0977ddb56 (patch)
tree2d5b78cf6535a71b679cc7abec6d2d6d5faf1e82 /src/f_op
parent27507a603098d4cb88db0f6ec10b47336c092b2c (diff)
Use composition instead of inheritance for most f_op classes (#2700)
Diffstat (limited to 'src/f_op')
-rw-r--r--src/f_op/f_op_actor.cpp2
-rw-r--r--src/f_op/f_op_actor_mng.cpp3
-rw-r--r--src/f_op/f_op_camera.cpp2
-rw-r--r--src/f_op/f_op_camera_mng.cpp4
-rw-r--r--src/f_op/f_op_kankyo.cpp2
-rw-r--r--src/f_op/f_op_msg.cpp2
-rw-r--r--src/f_op/f_op_msg_mng.cpp3
7 files changed, 9 insertions, 9 deletions
diff --git a/src/f_op/f_op_actor.cpp b/src/f_op/f_op_actor.cpp
index b303a6828b..6efc5a5e4b 100644
--- a/src/f_op/f_op_actor.cpp
+++ b/src/f_op/f_op_actor.cpp
@@ -209,7 +209,7 @@ static int fopAc_Create(void* i_this) {
int ret = fpcMtd_Create((process_method_class*)a_this->sub_method, a_this);
if (ret == cPhs_COMPLEATE_e) {
- s32 priority = fpcLf_GetPriority(a_this);
+ s32 priority = fpcM_DrawPriority(a_this);
fopDwTg_ToDrawQ(&a_this->draw_tag, priority);
} else if (ret == cPhs_ERROR_e) {
fopAcM_OnCondition(a_this, 0x10);
diff --git a/src/f_op/f_op_actor_mng.cpp b/src/f_op/f_op_actor_mng.cpp
index 5a75945aeb..cbf9447bc2 100644
--- a/src/f_op/f_op_actor_mng.cpp
+++ b/src/f_op/f_op_actor_mng.cpp
@@ -1911,7 +1911,8 @@ void fopAcM_setEffectMtx(const fopAc_ac_c* i_actor, const J3DModelData* modelDat
/* 8001D5A4-8001D5EC 017EE4 0048+00 1/1 0/0 0/0 .text fopAcM_getProcNameString__FPC10fopAc_ac_c */
static const char* fopAcM_getProcNameString(const fopAc_ac_c* i_actor) {
- const char* name = dStage_getName2(i_actor->base.profname, i_actor->argument);
+ s16 prof_name = fopAcM_GetProfName(i_actor);
+ const char* name = dStage_getName2(prof_name, i_actor->argument);
return name != NULL ? name : "UNKOWN";
}
diff --git a/src/f_op/f_op_camera.cpp b/src/f_op/f_op_camera.cpp
index 3558dc673b..fe2ebbca81 100644
--- a/src/f_op/f_op_camera.cpp
+++ b/src/f_op/f_op_camera.cpp
@@ -102,7 +102,7 @@ static int fopCam_Create(void* i_this) {
int ret = fpcMtd_Create(&a_this->submethod->base, a_this);
if (ret == cPhs_COMPLEATE_e) {
- s32 priority = fpcLf_GetPriority(a_this);
+ s32 priority = fpcM_DrawPriority(a_this);
fopDwTg_ToDrawQ(&a_this->create_tag, priority);
}
diff --git a/src/f_op/f_op_camera_mng.cpp b/src/f_op/f_op_camera_mng.cpp
index 3e7ccd1168..8da922981d 100644
--- a/src/f_op/f_op_camera_mng.cpp
+++ b/src/f_op/f_op_camera_mng.cpp
@@ -12,12 +12,12 @@ static fpc_ProcID l_fopCamM_id[4];
/* 8001E308-8001E310 018C48 0008+00 0/0 12/12 2/2 .text fopCamM_GetParam__FP12camera_class */
u32 fopCamM_GetParam(camera_class* i_this) {
- return i_this->base.parameters;
+ return fpcM_GetParam(i_this);
}
/* 8001E310-8001E374 018C50 0064+00 0/0 1/1 0/0 .text fopCamM_Create__FisPv */
fpc_ProcID fopCamM_Create(int i_cameraIdx, s16 i_procName, void* i_append) {
- l_fopCamM_id[i_cameraIdx] = fpcSCtRq_Request(fpcLy_CurrentLayer(), i_procName, NULL, NULL, i_append);
+ l_fopCamM_id[i_cameraIdx] = fpcM_Create(i_procName, NULL, i_append);
return l_fopCamM_id[i_cameraIdx];
}
diff --git a/src/f_op/f_op_kankyo.cpp b/src/f_op/f_op_kankyo.cpp
index 70da2903a4..58f8b26df6 100644
--- a/src/f_op/f_op_kankyo.cpp
+++ b/src/f_op/f_op_kankyo.cpp
@@ -81,7 +81,7 @@ static int fopKy_Create(void* i_this) {
int ret = fpcMtd_Create(&a_this->sub_method->base, a_this);
if (ret == cPhs_COMPLEATE_e) {
- s32 priority = fpcLf_GetPriority(a_this);
+ s32 priority = fpcM_DrawPriority(a_this);
fopDwTg_ToDrawQ(&a_this->draw_tag, priority);
}
diff --git a/src/f_op/f_op_msg.cpp b/src/f_op/f_op_msg.cpp
index d82bb6cce9..e6c201c42a 100644
--- a/src/f_op/f_op_msg.cpp
+++ b/src/f_op/f_op_msg.cpp
@@ -75,7 +75,7 @@ int fopMsg_Create(void* i_this) {
int ret = fpcMtd_Create(&a_this->sub_method->base, a_this);
if (ret == cPhs_COMPLEATE_e) {
- s32 priority = fpcLf_GetPriority(a_this);
+ s32 priority = fpcM_DrawPriority(a_this);
fopDwTg_ToDrawQ(&a_this->draw_tag, priority);
}
diff --git a/src/f_op/f_op_msg_mng.cpp b/src/f_op/f_op_msg_mng.cpp
index 00326665f7..d10d5f9d5e 100644
--- a/src/f_op/f_op_msg_mng.cpp
+++ b/src/f_op/f_op_msg_mng.cpp
@@ -29,8 +29,7 @@ msg_class* fopMsgM_SearchByID(fpc_ProcID i_id) {
/* 8001FA44-8001FA4C 01A384 0008+00 0/0 2/2 0/0 .text fopMsgM_GetAppend__FPv */
fopMsg_prm_class* fopMsgM_GetAppend(void* i_msg) {
- msg_class* msg = (msg_class*)i_msg;
- return (fopMsg_prm_class*)msg->base.append;
+ return (fopMsg_prm_class*)fpcM_GetAppend(i_msg);
}
/* 8001FA4C-8001FA6C 01A38C 0020+00 0/0 2/2 0/0 .text fopMsgM_Delete__FPv */