summaryrefslogtreecommitdiff
path: root/src/d/d_bg_s_acch.cpp
diff options
context:
space:
mode:
authorLagoLunatic <LagoLunatic@users.noreply.github.com>2024-02-03 16:23:18 -0500
committerLagoLunatic <LagoLunatic@users.noreply.github.com>2024-02-03 16:23:18 -0500
commit2103305ac9f06888722ca53cfa6d5fcebeb5b8c4 (patch)
tree0db98357e738bbe407614891cd4368ef2590c672 /src/d/d_bg_s_acch.cpp
parent74f571ff9738d494eed3159fe99bf0a47dfc5798 (diff)
Realmatch dStage_roomControl_c's static weak functions
Diffstat (limited to 'src/d/d_bg_s_acch.cpp')
-rw-r--r--src/d/d_bg_s_acch.cpp15
1 files changed, 0 insertions, 15 deletions
diff --git a/src/d/d_bg_s_acch.cpp b/src/d/d_bg_s_acch.cpp
index 855880e6..c31a1de8 100644
--- a/src/d/d_bg_s_acch.cpp
+++ b/src/d/d_bg_s_acch.cpp
@@ -463,18 +463,3 @@ static void dummy2() {
OSReport("\033[43;30m**************************************\ndBgS_ObjAcch::copy constructer called.\n**************************************\n\033[m");
dBgS_ObjAcch acch; // fakematch to get dBgS_ObjAcch's vtable and destructor to show up in this TU
}
-
-// TODO: Figure out what's going on with dStage_roomControl_c's weak functions. This is a fakematch.
-// dStage_roomControl_c::getBgW is supposed to be a weak function defined in d_stage.h, but putting it in the class body
-// makes it inline, and putting it outside the class body causes it to be included in every TU that includes d_stage.h.
-// It should only appear in d_bg_s_acch, but putting it in d_bg_s_acch.cpp would normally screw up the order of weak
-// functions in this TU because of the `-sym on` compiler flag.
-// This can be fixed by putting the function in a fake separate file and including it in only this TU.
-// But in this case we simulate this by using the #line directive's second argument to force the filename for this one
-// function to be different from the other functions in this file. This tricks `-sym on` into splitting it into its own
-// .text section, and the weak function order winds up being correct.
-#line 1 "d_stage.h"
-/* 800A4434-800A444C .text getBgW__20dStage_roomControl_cFi */
-dBgW* dStage_roomControl_c::getBgW(int i_roomNo) {
- return mStatus[i_roomNo].mpBgW;
-}