diff options
| author | Andzura <11079691+Andzura@users.noreply.github.com> | 2022-03-27 17:09:47 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-27 12:09:47 -0300 |
| commit | 4f3202fd7e5313ab7b777eb3be162283fe5ea142 (patch) | |
| tree | d674155db4f1660a5f18a7af5b00598ebf73644e /docs/tutorial/documenting.md | |
| parent | 02cb97161609e1c9aa53e2bbdc29e8b6f4f46c47 (diff) | |
z_message progress (#701)
* 8 functions matching, 1 non-matching, 45 untouched
* match func_801518B0
* match func_8014CC14
* matching 8 func, 1 non-matching
* matched func_80148CBC
* matched func_80156758
* matched func_80147564
* matched func_80151BB4
* matched func80152EC0/Message_Spawn_Song_Effect
* matched func_80151C9C
* WIP func_80148B98
* WIP func_80151938
* matched func_80151938
* matched func_80148B98
* matched func_80147734
* matched func_80147624
* WIP func_8014EBC
* match func_801518B0
* matched func_80147564
* matched func80152EC0/Message_Spawn_Song_Effect
* matched func_80151C9C
* WIP func_80148B98
* matched func_80151938
* matched func_80148B98
* matched func_80147734
* matched func_80147624
* WIP#2 func_8014EBC
* matched func_80149EBC
* WIP func_8014CCB4
* matched func_8014CCB4
* matched func_80151A68
* WIP func_8014D62C
* fix func_8015A68 signature
* z_message_nes & z_message_staff progress
* z_message_nes & z_message_staff renaming
* documenting z_message
* cleaning & renaming
* documenting MessageContext
* matched func_80151A68
* format
* naming convention fix
* re-add func_80147564
* apply renaming of Message_ShouldAdvanceSilent on the whole project
* re-format, add clang-format off/on in z_message.c needed for matching
* rename staff => credits; add renames in actorfixer.
* change rupees array to ascii
* remove useless comments
* change MessageContext.decodedBuffer to a union
* remove decodedBuffer from actorfixer
* applied AngheloAlf suggestions & ran sfxconvert on z_message.c
* rename message_struct => message_data_static; revert decodedBuffer as union creating differences.
* use true/false instead of 1/0
* use SET_FULLSCREEN_VIEWPORT macro in func_80152c64
* AngheloAlf suggestions.
* extract assign from dayTime calculation for readability in Message_LoadTimeNES
* remove bss_reordering from osFlash, idle & boot_main to typedef MessageTableEntry in message_data_static & make decodedBuffer an union.
* remove useless casts
* Changes hexa to ascii chars when it's meaningful;
add comments to func_8014CCB4 to show what hexa constant means.
* Hensldm suggestions
* ran actorfixer on new changes; fix new bss reordering error introduced with rebase
* use new TIME_TO_MINUTES_F macro
* re-ran format.sh
* hensldm suggestions #2 + overall cleaning
* remove useless parenthesis
* Update include/message_data_static.h
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* actorfixer and format
* more fixes
Co-authored-by: Andzura <andzura@andzura.fr>
Co-authored-by: abaud <adrien.baud@inria.fr>
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
Diffstat (limited to 'docs/tutorial/documenting.md')
| -rw-r--r-- | docs/tutorial/documenting.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/tutorial/documenting.md b/docs/tutorial/documenting.md index b064b3e3b..e50921bef 100644 --- a/docs/tutorial/documenting.md +++ b/docs/tutorial/documenting.md @@ -183,7 +183,7 @@ void func_80C102D4(EnRecepgirl *this, GlobalContext *globalCtx) { return; } - if ((temp_v0_2 == 5) && (func_80147624(globalCtx) != 0)) { + if ((temp_v0_2 == 5) && (Message_ShouldAdvance(globalCtx) != 0)) { if (this->actor.textId == 0x2AD9) { Flags_SetSwitch(globalCtx, this->actor.params); Animation_MorphToPlayOnce(&this->skelAnime, &object_bg_Anim_00AD98, 10.0f); @@ -500,7 +500,7 @@ void func_80C102D4(EnRecepgirl* this, GlobalContext* globalCtx) { if (temp_v0_2 == 2) { this->actor.textId = 0x2ADC; // hear directions again? func_80C10148(this); - } else if ((temp_v0_2 == 5) && (func_80147624(globalCtx) != 0)) { + } else if ((temp_v0_2 == 5) && (Message_ShouldAdvance(globalCtx) != 0)) { if (this->actor.textId == 0x2AD9) { // "Welcome..." Flags_SetSwitch(globalCtx, this->actor.params); Animation_MorphToPlayOnce(&this->skelAnime, &object_bg_Anim_00AD98, 10.0f); |