diff options
| author | David Racine <bass_dr@hotmail.com> | 2026-07-30 10:11:48 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-07-30 14:11:48 +0000 |
| commit | c7d72c0cdb71c29ff16097ca61c4d2312953ab91 (patch) | |
| tree | b42ccf6f523759e07227b20e8dfe90363a2ecaaf | |
| parent | 2c5762a0f287ee9de16eb8ed916275cf230fc60c (diff) | |
Fix startup crash from over-long "Speak Hylian" stat name (#6995)
itemTimestampDisplayName rows are char[24], sized for the 23-char column the
table uses. #6978 corrected "SpeakHylian:" to "Speak Hylian:" but kept the
original padding, making the string 24 chars + NUL = 25 bytes. That overflows
the buffer, so the strcpy in SetupDisplayNames aborts (__strcpy_chk) at GUI
init on any _FORTIFY_SOURCE build, crashing before the main menu. Drop one
trailing space to restore the 23-char column.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
| -rw-r--r-- | soh/soh/Enhancements/gameplaystats.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/soh/soh/Enhancements/gameplaystats.cpp b/soh/soh/Enhancements/gameplaystats.cpp index 5bd511749..2a647dcef 100644 --- a/soh/soh/Enhancements/gameplaystats.cpp +++ b/soh/soh/Enhancements/gameplaystats.cpp @@ -897,7 +897,7 @@ void SetupDisplayNames() { strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_DEKU], "Speak Deku: "); strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_GERUDO], "Speak Gerudo: "); strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_GORON], "Speak Goron: "); - strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_HYLIAN], "Speak Hylian: "); + strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_HYLIAN], "Speak Hylian: "); strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_KOKIRI], "Speak Kokiri: "); strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_SPEAK_ZORA], "Speak Zora: "); strcpy(itemTimestampDisplayName[TIMESTAMP_FOUND_DMC_BEAN_SOUL], "DMC Bean Soul: "); |