summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArchez <Archez@users.noreply.github.com>2024-02-20 10:32:28 -0500
committerGitHub <noreply@github.com>2024-02-20 10:32:28 -0500
commitcd5d2589f7e277e65fb1d35992da1fcb9ef63e3b (patch)
tree7d0159e95aaa6a74255020cb2931e687a1297022
parentd0b09743b9b9eef10ec7d102b78483e352dd7795 (diff)
parentef9fc0a9ec8716201dfaeb2d28d059171a066b7a (diff)
Merge pull request #3958 from HarbourMasters/develop-macready
macready -> develop
-rw-r--r--soh/soh/z_scene_otr.cpp2
-rw-r--r--soh/src/code/z_camera_data.inc8
2 files changed, 6 insertions, 4 deletions
diff --git a/soh/soh/z_scene_otr.cpp b/soh/soh/z_scene_otr.cpp
index aed069698..3d7889807 100644
--- a/soh/soh/z_scene_otr.cpp
+++ b/soh/soh/z_scene_otr.cpp
@@ -178,7 +178,7 @@ bool Scene_CommandObjectList(PlayState* play, SOH::ISceneCommand* cmd) {
// Loop until a mismatch in the object lists
// Then clear all object ids past that in the context object list and kill actors for those objects
for (i = play->objectCtx.unk_09, k = 0; i < play->objectCtx.num; i++, k++) {
- if (i >= cmdObj->objects.size() || play->objectCtx.status[i].id != cmdObj->objects[k]) {
+ if (k >= cmdObj->objects.size() || play->objectCtx.status[i].id != cmdObj->objects[k]) {
for (j = i; j < play->objectCtx.num; j++) {
play->objectCtx.status[j].id = OBJECT_INVALID;
}
diff --git a/soh/src/code/z_camera_data.inc b/soh/src/code/z_camera_data.inc
index b9e0ba864..90b1874c7 100644
--- a/soh/src/code/z_camera_data.inc
+++ b/soh/src/code/z_camera_data.inc
@@ -16,9 +16,11 @@ typedef struct {
union {
u32 unk_00;
struct {
- u32 unk_bit0 : 1;
- u32 unk_bit1 : 1;
- u32 validModes : 30;
+ // SoH [Port] These bitfield values are unused and led to shifting in validModes for little endian systems
+ // Removing those so that validModes can be a complete 32 bit value
+ // u32 unk_bit0 : 1;
+ // u32 unk_bit1 : 1;
+ u32 validModes;
};
};
CameraMode* cameraModes;