diff options
| author | Stenzek <stenzek@gmail.com> | 2018-10-03 23:03:26 +1000 |
|---|---|---|
| committer | Stenzek <stenzek@gmail.com> | 2018-10-20 21:11:34 +1000 |
| commit | dcdd02d646230e7903520a41dc9f86e57ae16dbe (patch) | |
| tree | 600f49146250708874ef1d7ddf6380c8a829646a /Source/Core/VideoBackends | |
| parent | eb284b5d661cab6aed770e0e51b790917249ef21 (diff) | |
GLContext: Remove global context pointer
Diffstat (limited to 'Source/Core/VideoBackends')
| -rw-r--r-- | Source/Core/VideoBackends/OGL/FramebufferManager.cpp | 3 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/PerfQuery.cpp | 15 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp | 5 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/Render.cpp | 47 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/Render.h | 12 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/SamplerCache.cpp | 4 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/VideoBackend.h | 4 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/OGL/main.cpp | 20 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/Software/SWOGLWindow.cpp | 61 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/Software/SWOGLWindow.h | 22 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/Software/SWRenderer.cpp | 11 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/Software/SWRenderer.h | 9 | ||||
| -rw-r--r-- | Source/Core/VideoBackends/Software/SWmain.cpp | 10 |
13 files changed, 129 insertions, 94 deletions
diff --git a/Source/Core/VideoBackends/OGL/FramebufferManager.cpp b/Source/Core/VideoBackends/OGL/FramebufferManager.cpp index 1c1c976f70..12de898ff5 100644 --- a/Source/Core/VideoBackends/OGL/FramebufferManager.cpp +++ b/Source/Core/VideoBackends/OGL/FramebufferManager.cpp @@ -9,7 +9,6 @@ #include "Common/Common.h" #include "Common/CommonTypes.h" -#include "Common/GL/GLContext.h" #include "Common/Logging/Log.h" #include "Common/MsgHandler.h" @@ -414,7 +413,7 @@ FramebufferManager::FramebufferManager(int targetWidth, int targetHeight, int ms glBindBuffer(GL_ARRAY_BUFFER, static_cast<VertexManager*>(g_vertex_manager.get())->GetVertexBufferHandle()); - if (!g_main_gl_context->IsGLES()) + if (!static_cast<Renderer*>(g_renderer.get())->IsGLES()) glEnable(GL_PROGRAM_POINT_SIZE); } diff --git a/Source/Core/VideoBackends/OGL/PerfQuery.cpp b/Source/Core/VideoBackends/OGL/PerfQuery.cpp index 30a6e1781b..77471cee19 100644 --- a/Source/Core/VideoBackends/OGL/PerfQuery.cpp +++ b/Source/Core/VideoBackends/OGL/PerfQuery.cpp @@ -6,24 +6,23 @@ #include "Common/CommonFuncs.h" #include "Common/CommonTypes.h" -#include "Common/GL/GLContext.h" -#include "Common/GL/GLUtil.h" +#include "Common/GL/GLExtensions/GLExtensions.h" #include "VideoBackends/OGL/PerfQuery.h" -#include "VideoCommon/RenderBase.h" +#include "VideoBackends/OGL/Render.h" #include "VideoCommon/VideoConfig.h" namespace OGL { std::unique_ptr<PerfQueryBase> GetPerfQuery() { - if (g_main_gl_context->IsGLES() && GLExtensions::Supports("GL_NV_occlusion_query_samples")) + const bool is_gles = static_cast<Renderer*>(g_renderer.get())->IsGLES(); + if (is_gles && GLExtensions::Supports("GL_NV_occlusion_query_samples")) return std::make_unique<PerfQueryGLESNV>(); - - if (g_main_gl_context->IsGLES()) + else if (is_gles) return std::make_unique<PerfQueryGL>(GL_ANY_SAMPLES_PASSED); - - return std::make_unique<PerfQueryGL>(GL_SAMPLES_PASSED); + else + return std::make_unique<PerfQueryGL>(GL_SAMPLES_PASSED); } PerfQuery::PerfQuery() : m_query_read_pos() diff --git a/Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp b/Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp index ae930dddab..78458aa3fe 100644 --- a/Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp +++ b/Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp @@ -805,7 +805,8 @@ void ProgramShaderCache::CreateHeader() bool SharedContextAsyncShaderCompiler::WorkerThreadInitMainThread(void** param) { - std::unique_ptr<GLContext> context = g_main_gl_context->CreateSharedContext(); + std::unique_ptr<GLContext> context = + static_cast<Renderer*>(g_renderer.get())->GetMainGLContext()->CreateSharedContext(); if (!context) { PanicAlert("Failed to create shared context for shader compiling."); @@ -824,7 +825,7 @@ bool SharedContextAsyncShaderCompiler::WorkerThreadInitWorkerThread(void* param) s_is_shared_context = true; if (g_ActiveConfig.backend_info.bSupportsPrimitiveRestart) - GLUtil::EnablePrimitiveRestart(); + GLUtil::EnablePrimitiveRestart(context); return true; } diff --git a/Source/Core/VideoBackends/OGL/Render.cpp b/Source/Core/VideoBackends/OGL/Render.cpp index be08541f97..b28df12c6a 100644 --- a/Source/Core/VideoBackends/OGL/Render.cpp +++ b/Source/Core/VideoBackends/OGL/Render.cpp @@ -353,9 +353,10 @@ static void InitDriverInfo() } // Init functions -Renderer::Renderer() - : ::Renderer(static_cast<int>(std::max(g_main_gl_context->GetBackBufferWidth(), 1u)), - static_cast<int>(std::max(g_main_gl_context->GetBackBufferHeight(), 1u))) +Renderer::Renderer(std::unique_ptr<GLContext> main_gl_context) + : ::Renderer(static_cast<int>(std::max(main_gl_context->GetBackBufferWidth(), 1u)), + static_cast<int>(std::max(main_gl_context->GetBackBufferHeight(), 1u))), + m_main_gl_context(std::move(main_gl_context)) { bool bSuccess = true; @@ -365,7 +366,7 @@ Renderer::Renderer() InitDriverInfo(); - if (!g_main_gl_context->IsGLES()) + if (!m_main_gl_context->IsGLES()) { if (!GLExtensions::Supports("GL_ARB_framebuffer_object")) { @@ -500,7 +501,7 @@ Renderer::Renderer() g_Config.backend_info.bSupportsBPTCTextures = GLExtensions::Supports("GL_ARB_texture_compression_bptc"); - if (g_main_gl_context->IsGLES()) + if (m_main_gl_context->IsGLES()) { g_ogl_config.SupportedESPointSize = GLExtensions::Supports("GL_OES_geometry_point_size") ? @@ -731,7 +732,7 @@ Renderer::Renderer() if (!g_ogl_config.bSupportsGLBufferStorage && !g_ogl_config.bSupportsGLPinnedMemory) { OSD::AddMessage(StringFromFormat("Your OpenGL driver does not support %s_buffer_storage.", - g_main_gl_context->IsGLES() ? "EXT" : "ARB"), + m_main_gl_context->IsGLES() ? "EXT" : "ARB"), 60000); OSD::AddMessage("This device's performance will be terrible.", 60000); OSD::AddMessage("Please ask your device vendor for an updated OpenGL driver.", 60000); @@ -760,7 +761,7 @@ Renderer::Renderer() // Handle VSync on/off s_vsync = g_ActiveConfig.IsVSync(); if (!DriverDetails::HasBug(DriverDetails::BUG_BROKEN_VSYNC)) - g_main_gl_context->SwapInterval(s_vsync); + m_main_gl_context->SwapInterval(s_vsync); // Because of the fixed framebuffer size we need to disable the resolution // options while running @@ -795,18 +796,22 @@ Renderer::Renderer() glClearDepthf(1.0f); if (g_ActiveConfig.backend_info.bSupportsPrimitiveRestart) - GLUtil::EnablePrimitiveRestart(); + GLUtil::EnablePrimitiveRestart(m_main_gl_context.get()); IndexGenerator::Init(); UpdateActiveConfig(); ClearEFBCache(); } -Renderer::~Renderer() = default; +Renderer::~Renderer() +{ + m_main_gl_context->ClearCurrent(); + m_main_gl_context->Shutdown(); +} bool Renderer::IsHeadless() const { - return g_main_gl_context->IsHeadless(); + return m_main_gl_context->IsHeadless(); } void Renderer::Shutdown() @@ -1048,7 +1053,7 @@ u32 Renderer::AccessEFB(EFBAccessType type, u32 x, u32 y, u32 poke_data) std::unique_ptr<u32[]> colorMap(new u32[targetPixelRcWidth * targetPixelRcHeight]); - if (g_main_gl_context->IsGLES()) + if (IsGLES()) // XXX: Swap colours glReadPixels(targetPixelRc.left, targetPixelRc.bottom, targetPixelRcWidth, targetPixelRcHeight, GL_RGBA, GL_UNSIGNED_BYTE, colorMap.get()); @@ -1355,7 +1360,7 @@ void Renderer::ApplyBlendingState(const BlendingState state, bool force) GL_XOR, GL_OR, GL_NOR, GL_EQUIV, GL_INVERT, GL_OR_REVERSE, GL_COPY_INVERTED, GL_OR_INVERTED, GL_NAND, GL_SET}; - if (g_main_gl_context->IsGLES()) + if (IsGLES()) { // Logic ops aren't available in GLES3 } @@ -1425,7 +1430,7 @@ void Renderer::SwapImpl(AbstractTexture* texture, const EFBRectangle& xfb_region OSD::DrawMessages(); // Swap the back and front buffers, presenting the image. - g_main_gl_context->Swap(); + m_main_gl_context->Swap(); } else { @@ -1470,7 +1475,7 @@ void Renderer::SwapImpl(AbstractTexture* texture, const EFBRectangle& xfb_region { s_vsync = g_ActiveConfig.IsVSync(); if (!DriverDetails::HasBug(DriverDetails::BUG_BROKEN_VSYNC)) - g_main_gl_context->SwapInterval(s_vsync); + m_main_gl_context->SwapInterval(s_vsync); } // Clean out old stuff from caches. It's not worth it to clean out the shader caches. @@ -1504,12 +1509,12 @@ void Renderer::CheckForSurfaceChange() if (!m_surface_changed.TestAndClear()) return; - g_main_gl_context->UpdateSurface(m_new_surface_handle); + m_main_gl_context->UpdateSurface(m_new_surface_handle); m_new_surface_handle = nullptr; // With a surface change, the window likely has new dimensions. - m_backbuffer_width = g_main_gl_context->GetBackBufferWidth(); - m_backbuffer_height = g_main_gl_context->GetBackBufferHeight(); + m_backbuffer_width = m_main_gl_context->GetBackBufferWidth(); + m_backbuffer_height = m_main_gl_context->GetBackBufferHeight(); } void Renderer::CheckForSurfaceResize() @@ -1517,9 +1522,9 @@ void Renderer::CheckForSurfaceResize() if (!m_surface_resized.TestAndClear()) return; - g_main_gl_context->Update(); - m_backbuffer_width = g_main_gl_context->GetBackBufferWidth(); - m_backbuffer_height = g_main_gl_context->GetBackBufferHeight(); + m_main_gl_context->Update(); + m_backbuffer_width = m_main_gl_context->GetBackBufferWidth(); + m_backbuffer_height = m_main_gl_context->GetBackBufferHeight(); } void Renderer::DrawEFB(GLuint framebuffer, const TargetRectangle& target_rc, @@ -1540,7 +1545,7 @@ void Renderer::ResetAPIState() glDisable(GL_DEPTH_TEST); glDisable(GL_CULL_FACE); glDisable(GL_BLEND); - if (!g_main_gl_context->IsGLES()) + if (!IsGLES()) glDisable(GL_COLOR_LOGIC_OP); if (g_ActiveConfig.backend_info.bSupportsDepthClamp) { diff --git a/Source/Core/VideoBackends/OGL/Render.h b/Source/Core/VideoBackends/OGL/Render.h index 7662900624..5beb4ecd75 100644 --- a/Source/Core/VideoBackends/OGL/Render.h +++ b/Source/Core/VideoBackends/OGL/Render.h @@ -7,7 +7,8 @@ #include <array> #include <string> -#include "Common/GL/GLUtil.h" +#include "Common/GL/GLContext.h" +#include "Common/GL/GLExtensions/GLExtensions.h" #include "VideoCommon/RenderBase.h" struct XFBSourceBase; @@ -81,7 +82,7 @@ extern VideoConfig g_ogl_config; class Renderer : public ::Renderer { public: - Renderer(); + Renderer(std::unique_ptr<GLContext> main_gl_context); ~Renderer() override; bool IsHeadless() const override; @@ -143,6 +144,10 @@ public: std::unique_ptr<VideoCommon::AsyncShaderCompiler> CreateAsyncShaderCompiler() override; + // Only call methods from this on the GPU thread. + GLContext* GetMainGLContext() const { return m_main_gl_context.get(); } + bool IsGLES() const { return m_main_gl_context->IsGLES(); } + private: void UpdateEFBCache(EFBAccessType type, u32 cacheRectIdx, const EFBRectangle& efbPixelRc, const TargetRectangle& targetPixelRc, const void* data); @@ -161,10 +166,11 @@ private: void ApplyDepthState(const DepthState state, bool force = false); void UploadUtilityUniforms(const void* uniforms, u32 uniforms_size); + std::unique_ptr<GLContext> m_main_gl_context; std::array<const AbstractTexture*, 8> m_bound_textures{}; const OGLPipeline* m_graphics_pipeline = nullptr; RasterizationState m_current_rasterization_state = {}; DepthState m_current_depth_state = {}; BlendingState m_current_blend_state = {}; }; -} +} // namespace OGL diff --git a/Source/Core/VideoBackends/OGL/SamplerCache.cpp b/Source/Core/VideoBackends/OGL/SamplerCache.cpp index ae848e8d29..364ec51c99 100644 --- a/Source/Core/VideoBackends/OGL/SamplerCache.cpp +++ b/Source/Core/VideoBackends/OGL/SamplerCache.cpp @@ -3,11 +3,11 @@ // Refer to the license.txt file included. #include "VideoBackends/OGL/SamplerCache.h" +#include "VideoBackends/OGL/Render.h" #include <memory> #include "Common/CommonTypes.h" -#include "Common/GL/GLContext.h" #include "VideoCommon/SamplerCommon.h" #include "VideoCommon/VideoConfig.h" @@ -99,7 +99,7 @@ void SamplerCache::SetParameters(GLuint sampler_id, const SamplerState& params) glSamplerParameterf(sampler_id, GL_TEXTURE_MIN_LOD, params.min_lod / 16.f); glSamplerParameterf(sampler_id, GL_TEXTURE_MAX_LOD, params.max_lod / 16.f); - if (!g_main_gl_context->IsGLES()) + if (!static_cast<Renderer*>(g_renderer.get())->IsGLES()) glSamplerParameterf(sampler_id, GL_TEXTURE_LOD_BIAS, params.lod_bias / 256.f); if (params.anisotropic_filtering && g_ogl_config.bSupportsAniso) diff --git a/Source/Core/VideoBackends/OGL/VideoBackend.h b/Source/Core/VideoBackends/OGL/VideoBackend.h index 2a1360542f..74bc929e85 100644 --- a/Source/Core/VideoBackends/OGL/VideoBackend.h +++ b/Source/Core/VideoBackends/OGL/VideoBackend.h @@ -7,6 +7,8 @@ #include <string> #include "VideoCommon/VideoBackendBase.h" +class GLContext; + namespace OGL { class VideoBackend : public VideoBackendBase @@ -20,7 +22,7 @@ class VideoBackend : public VideoBackendBase void InitBackendInfo() override; private: - bool InitializeGLExtensions(); + bool InitializeGLExtensions(GLContext* context); bool FillBackendInfo(); }; } // namespace OGL diff --git a/Source/Core/VideoBackends/OGL/main.cpp b/Source/Core/VideoBackends/OGL/main.cpp index 56cd60fc47..2c38986aa9 100644 --- a/Source/Core/VideoBackends/OGL/main.cpp +++ b/Source/Core/VideoBackends/OGL/main.cpp @@ -66,7 +66,7 @@ std::string VideoBackend::GetName() const std::string VideoBackend::GetDisplayName() const { - if (g_main_gl_context && g_main_gl_context->GetMode() == GLContext::Mode::OpenGLES) + if (g_renderer && static_cast<Renderer*>(g_renderer.get())->IsGLES()) return _trans("OpenGL ES"); else return _trans("OpenGL"); @@ -108,10 +108,10 @@ void VideoBackend::InitBackendInfo() g_Config.backend_info.AAModes = {1, 2, 4, 8}; } -bool VideoBackend::InitializeGLExtensions() +bool VideoBackend::InitializeGLExtensions(GLContext* context) { // Init extension support. - if (!GLExtensions::Init()) + if (!GLExtensions::Init(context)) { // OpenGL 2.0 is required for all shader based drawings. There is no way to get this by // extensions @@ -161,15 +161,16 @@ bool VideoBackend::Initialize(const WindowSystemInfo& wsi) { InitializeShared(); - g_main_gl_context = GLContext::Create(wsi, g_ActiveConfig.stereo_mode == StereoMode::QuadBuffer); - if (!g_main_gl_context) + std::unique_ptr<GLContext> main_gl_context = + GLContext::Create(wsi, g_ActiveConfig.stereo_mode == StereoMode::QuadBuffer); + if (!main_gl_context) return false; - g_main_gl_context->MakeCurrent(); - if (!InitializeGLExtensions() || !FillBackendInfo()) + main_gl_context->MakeCurrent(); + if (!InitializeGLExtensions(main_gl_context.get()) || !FillBackendInfo()) return false; - g_renderer = std::make_unique<Renderer>(); + g_renderer = std::make_unique<Renderer>(std::move(main_gl_context)); g_vertex_manager = std::make_unique<VertexManager>(); g_perf_query = GetPerfQuery(); ProgramShaderCache::Init(); @@ -195,9 +196,6 @@ void VideoBackend::Shutdown() g_perf_query.reset(); g_vertex_manager.reset(); g_renderer.reset(); - g_main_gl_context->ClearCurrent(); - g_main_gl_context->Shutdown(); - g_main_gl_context.reset(); ShutdownShared(); } } // namespace OGL diff --git a/Source/Core/VideoBackends/Software/SWOGLWindow.cpp b/Source/Core/VideoBackends/Software/SWOGLWindow.cpp index d9694c17aa..4936d1a13c 100644 --- a/Source/Core/VideoBackends/Software/SWOGLWindow.cpp +++ b/Source/Core/VideoBackends/Software/SWOGLWindow.cpp @@ -7,48 +7,58 @@ #include "Common/GL/GLContext.h" #include "Common/GL/GLUtil.h" #include "Common/Logging/Log.h" +#include "Common/MsgHandler.h" #include "VideoBackends/Software/SWOGLWindow.h" #include "VideoBackends/Software/SWTexture.h" -std::unique_ptr<SWOGLWindow> SWOGLWindow::s_instance; +SWOGLWindow::SWOGLWindow() = default; -void SWOGLWindow::Init(const WindowSystemInfo& wsi) +SWOGLWindow::~SWOGLWindow() { - g_main_gl_context = GLContext::Create(wsi); - if (!g_main_gl_context) + if (m_gl_context) { - ERROR_LOG(VIDEO, "GLInterface::Create failed."); + m_gl_context->ClearCurrent(); + m_gl_context->Shutdown(); } - - s_instance.reset(new SWOGLWindow()); } -void SWOGLWindow::Shutdown() +std::unique_ptr<SWOGLWindow> SWOGLWindow::Create(const WindowSystemInfo& wsi) { - g_main_gl_context->Shutdown(); - g_main_gl_context.reset(); + std::unique_ptr<SWOGLWindow> window = std::unique_ptr<SWOGLWindow>(new SWOGLWindow()); + if (!window->Initialize(wsi)) + { + PanicAlert("Failed to create OpenGL window"); + return nullptr; + } - s_instance.reset(); + return window; } -void SWOGLWindow::Prepare() +bool SWOGLWindow::IsHeadless() const { - if (m_init) - return; - m_init = true; + return m_gl_context->IsHeadless(); +} + +bool SWOGLWindow::Initialize(const WindowSystemInfo& wsi) +{ + m_gl_context = GLContext::Create(wsi); + if (!m_gl_context) + return false; + + m_gl_context->MakeCurrent(); // Init extension support. - if (!GLExtensions::Init()) + if (!GLExtensions::Init(m_gl_context.get())) { ERROR_LOG(VIDEO, "GLExtensions::Init failed!Does your video card support OpenGL 2.0?"); - return; + return false; } else if (GLExtensions::Version() < 310) { ERROR_LOG(VIDEO, "OpenGL Version %d detected, but at least 3.1 is required.", GLExtensions::Version()); - return; + return false; } std::string frag_shader = "in vec2 TexCoord;\n" @@ -65,9 +75,9 @@ void SWOGLWindow::Prepare() " TexCoord = vec2(rawpos.x, -rawpos.y);\n" "}\n"; - std::string header = g_main_gl_context->IsGLES() ? "#version 300 es\n" - "precision highp float;\n" : - "#version 140\n"; + std::string header = m_gl_context->IsGLES() ? "#version 300 es\n" + "precision highp float;\n" : + "#version 140\n"; m_image_program = GLUtil::CompileProgram(header + vertex_shader, header + frag_shader); @@ -81,6 +91,7 @@ void SWOGLWindow::Prepare() glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glGenVertexArrays(1, &m_image_vao); + return true; } void SWOGLWindow::PrintText(const std::string& text, int x, int y, u32 color) @@ -91,10 +102,10 @@ void SWOGLWindow::PrintText(const std::string& text, int x, int y, u32 color) void SWOGLWindow::ShowImage(AbstractTexture* image, const EFBRectangle& xfb_region) { SW::SWTexture* sw_image = static_cast<SW::SWTexture*>(image); - g_main_gl_context->Update(); // just updates the render window position and the backbuffer size + m_gl_context->Update(); // just updates the render window position and the backbuffer size - GLsizei glWidth = (GLsizei)g_main_gl_context->GetBackBufferWidth(); - GLsizei glHeight = (GLsizei)g_main_gl_context->GetBackBufferHeight(); + GLsizei glWidth = (GLsizei)m_gl_context->GetBackBufferWidth(); + GLsizei glHeight = (GLsizei)m_gl_context->GetBackBufferHeight(); glViewport(0, 0, glWidth, glHeight); @@ -121,5 +132,5 @@ void SWOGLWindow::ShowImage(AbstractTexture* image, const EFBRectangle& xfb_regi // } m_text.clear(); - g_main_gl_context->Swap(); + m_gl_context->Swap(); } diff --git a/Source/Core/VideoBackends/Software/SWOGLWindow.h b/Source/Core/VideoBackends/Software/SWOGLWindow.h index 2d85770e61..38ae316d07 100644 --- a/Source/Core/VideoBackends/Software/SWOGLWindow.h +++ b/Source/Core/VideoBackends/Software/SWOGLWindow.h @@ -11,15 +11,18 @@ #include "Common/CommonTypes.h" #include "VideoCommon/VideoCommon.h" +class GLContext; + class AbstractTexture; struct WindowSystemInfo; class SWOGLWindow { public: - static void Init(const WindowSystemInfo& wsi); - static void Shutdown(); - void Prepare(); + ~SWOGLWindow(); + + GLContext* GetContext() const { return m_gl_context.get(); } + bool IsHeadless() const; // Will be printed on the *next* image void PrintText(const std::string& text, int x, int y, u32 color); @@ -27,10 +30,13 @@ public: // Image to show, will be swapped immediately void ShowImage(AbstractTexture* image, const EFBRectangle& xfb_region); - static std::unique_ptr<SWOGLWindow> s_instance; + static std::unique_ptr<SWOGLWindow> Create(const WindowSystemInfo& wsi); private: - SWOGLWindow() {} + SWOGLWindow(); + + bool Initialize(const WindowSystemInfo& wsi); + struct TextData { std::string text; @@ -39,7 +45,9 @@ private: }; std::vector<TextData> m_text; - bool m_init{false}; + u32 m_image_program = 0; + u32 m_image_texture = 0; + u32 m_image_vao = 0; - u32 m_image_program, m_image_texture, m_image_vao; + std::unique_ptr<GLContext> m_gl_context; }; diff --git a/Source/Core/VideoBackends/Software/SWRenderer.cpp b/Source/Core/VideoBackends/Software/SWRenderer.cpp index 5e76cdd296..2c6a97027b 100644 --- a/Source/Core/VideoBackends/Software/SWRenderer.cpp +++ b/Source/Core/VideoBackends/Software/SWRenderer.cpp @@ -24,14 +24,15 @@ #include "VideoCommon/VideoBackendBase.h" #include "VideoCommon/VideoConfig.h" -SWRenderer::SWRenderer() - : ::Renderer(static_cast<int>(MAX_XFB_WIDTH), static_cast<int>(MAX_XFB_HEIGHT)) +SWRenderer::SWRenderer(std::unique_ptr<SWOGLWindow> window) + : ::Renderer(static_cast<int>(MAX_XFB_WIDTH), static_cast<int>(MAX_XFB_HEIGHT)), + m_window(std::move(window)) { } bool SWRenderer::IsHeadless() const { - return g_main_gl_context->IsHeadless(); + return m_window->IsHeadless(); } std::unique_ptr<AbstractTexture> SWRenderer::CreateTexture(const TextureConfig& config) @@ -55,7 +56,7 @@ SWRenderer::CreateFramebuffer(const AbstractTexture* color_attachment, void SWRenderer::RenderText(const std::string& pstr, int left, int top, u32 color) { - SWOGLWindow::s_instance->PrintText(pstr, left, top, color); + m_window->PrintText(pstr, left, top, color); } class SWShader final : public AbstractShader @@ -100,7 +101,7 @@ void SWRenderer::SwapImpl(AbstractTexture* texture, const EFBRectangle& xfb_regi if (!IsHeadless()) { DrawDebugText(); - SWOGLWindow::s_instance->ShowImage(texture, xfb_region); + m_window->ShowImage(texture, xfb_region); } UpdateActiveConfig(); diff --git a/Source/Core/VideoBackends/Software/SWRenderer.h b/Source/Core/VideoBackends/Software/SWRenderer.h index 6b2a3f0795..936139516f 100644 --- a/Source/Core/VideoBackends/Software/SWRenderer.h +++ b/Source/Core/VideoBackends/Software/SWRenderer.h @@ -4,14 +4,18 @@ #pragma once +#include <memory> + #include "Common/CommonTypes.h" #include "VideoCommon/RenderBase.h" +class SWOGLWindow; + class SWRenderer : public Renderer { public: - SWRenderer(); + SWRenderer(std::unique_ptr<SWOGLWindow> window); bool IsHeadless() const override; @@ -42,4 +46,7 @@ public: u32 color, u32 z) override; void ReinterpretPixelData(unsigned int convtype) override {} + +private: + std::unique_ptr<SWOGLWindow> m_window; }; diff --git a/Source/Core/VideoBackends/Software/SWmain.cpp b/Source/Core/VideoBackends/Software/SWmain.cpp index 070cf74b69..a0ad349849 100644 --- a/Source/Core/VideoBackends/Software/SWmain.cpp +++ b/Source/Core/VideoBackends/Software/SWmain.cpp @@ -82,16 +82,15 @@ bool VideoSoftware::Initialize(const WindowSystemInfo& wsi) { InitializeShared(); - SWOGLWindow::Init(wsi); + std::unique_ptr<SWOGLWindow> window = SWOGLWindow::Create(wsi); + if (!window) + return false; Clipper::Init(); Rasterizer::Init(); DebugUtil::Init(); - g_main_gl_context->MakeCurrent(); - SWOGLWindow::s_instance->Prepare(); - - g_renderer = std::make_unique<SWRenderer>(); + g_renderer = std::make_unique<SWRenderer>(std::move(window)); g_vertex_manager = std::make_unique<SWVertexLoader>(); g_perf_query = std::make_unique<PerfQuery>(); g_texture_cache = std::make_unique<TextureCache>(); @@ -108,7 +107,6 @@ void VideoSoftware::Shutdown() g_renderer->Shutdown(); DebugUtil::Shutdown(); - SWOGLWindow::Shutdown(); g_framebuffer_manager.reset(); g_texture_cache.reset(); g_perf_query.reset(); |
