diff options
| author | Admiral H. Curtiss <pikachu025@gmail.com> | 2023-12-11 23:37:29 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-11 23:37:29 +0100 |
| commit | 54301d709a385661e76c1c2c5fe09df68be3fb1f (patch) | |
| tree | 36920a330e813c9c40a5fb1408db13cf4698400d /Source/Core/VideoCommon/OnScreenUI.cpp | |
| parent | 16ba56a34b496bb270b7414174e87e14a248e543 (diff) | |
| parent | d90537cc18df27a5e893beb767d8801131820659 (diff) | |
Merge pull request #12389 from lioncash/cheeve
AchievementManager: Make GetInstance() and GetLock() return a reference
Diffstat (limited to 'Source/Core/VideoCommon/OnScreenUI.cpp')
| -rw-r--r-- | Source/Core/VideoCommon/OnScreenUI.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/Source/Core/VideoCommon/OnScreenUI.cpp b/Source/Core/VideoCommon/OnScreenUI.cpp index 11953b2f4c..88141736e4 100644 --- a/Source/Core/VideoCommon/OnScreenUI.cpp +++ b/Source/Core/VideoCommon/OnScreenUI.cpp @@ -330,10 +330,9 @@ void OnScreenUI::DrawDebugText() #ifdef USE_RETRO_ACHIEVEMENTS void OnScreenUI::DrawChallenges() { - std::lock_guard lg{*AchievementManager::GetInstance()->GetLock()}; - const AchievementManager::NamedIconMap& challenge_icons = - AchievementManager::GetInstance()->GetChallengeIcons(); - if (challenge_icons.size() == 0) + std::lock_guard lg{AchievementManager::GetInstance().GetLock()}; + const auto& challenge_icons = AchievementManager::GetInstance().GetChallengeIcons(); + if (challenge_icons.empty()) return; const std::string window_name = "Challenges"; |