diff options
| author | Pokechu22 <Pokechu022@gmail.com> | 2024-09-24 23:46:45 -0700 |
|---|---|---|
| committer | Pokechu22 <Pokechu022@gmail.com> | 2024-10-12 10:32:41 -0700 |
| commit | 937bb2aa2e12b635ba328af8de7c9a5d5963d084 (patch) | |
| tree | f7e24ca237cdda8cde7e611ee52806fdea96292a /Source/Core/VideoCommon/VertexLoaderManager.cpp | |
| parent | 35ec2e97a8ea90730cb33eceec701f81597f98f7 (diff) | |
Cache normals in addition to binormals and tangents
Fixes LIT (https://bugs.dolphin-emu.org/issues/13635). The text does not include normals, but has lighting enabled. With the previous default of (0, 0, 0), lighting was always black (as dot(X, (0, 0, 0)) is always 0). It seems like the normal from the map in the background (0, 0, 1) is re-used.
LIT also has the vertex color enabled while vertex color is not specified, the same as SMS's debug cubes; the default MissingColorValue GameINI value of solid white seems to work correctly in this case.
Diffstat (limited to 'Source/Core/VideoCommon/VertexLoaderManager.cpp')
| -rw-r--r-- | Source/Core/VideoCommon/VertexLoaderManager.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/Source/Core/VideoCommon/VertexLoaderManager.cpp b/Source/Core/VideoCommon/VertexLoaderManager.cpp index 0c48bf32a8..4ef11a1283 100644 --- a/Source/Core/VideoCommon/VertexLoaderManager.cpp +++ b/Source/Core/VideoCommon/VertexLoaderManager.cpp @@ -40,6 +40,7 @@ namespace VertexLoaderManager std::array<u32, 3> position_matrix_index_cache; // 3 vertices, 4 floats each to allow SIMD overwrite alignas(sizeof(std::array<float, 4>)) std::array<std::array<float, 4>, 3> position_cache; +alignas(sizeof(std::array<float, 4>)) std::array<float, 4> normal_cache; alignas(sizeof(std::array<float, 4>)) std::array<float, 4> tangent_cache; alignas(sizeof(std::array<float, 4>)) std::array<float, 4> binormal_cache; |