diff options
Diffstat (limited to 'Source/Core/Common/GL/GLInterface')
| -rw-r--r-- | Source/Core/Common/GL/GLInterface/AGL.h | 3 | ||||
| -rw-r--r-- | Source/Core/Common/GL/GLInterface/AGL.mm | 32 |
2 files changed, 24 insertions, 11 deletions
diff --git a/Source/Core/Common/GL/GLInterface/AGL.h b/Source/Core/Common/GL/GLInterface/AGL.h index cb3b03974e..dda9fee0e3 100644 --- a/Source/Core/Common/GL/GLInterface/AGL.h +++ b/Source/Core/Common/GL/GLInterface/AGL.h @@ -3,6 +3,9 @@ #pragma once +// This define will silence all "OpenGL is deprecated, use Metal" warnings. +#define GL_SILENCE_DEPRECATION 1 + #if defined(__APPLE__) && defined(__OBJC__) #import <AppKit/AppKit.h> #else diff --git a/Source/Core/Common/GL/GLInterface/AGL.mm b/Source/Core/Common/GL/GLInterface/AGL.mm index 3649cd0a76..a6fc7f0c0e 100644 --- a/Source/Core/Common/GL/GLInterface/AGL.mm +++ b/Source/Core/Common/GL/GLInterface/AGL.mm @@ -4,6 +4,9 @@ #include "Common/GL/GLInterface/AGL.h" #include "Common/Logging/Log.h" +// UpdateCachedDimensions and AttachContextToView contain calls to UI APIs, so they must only be +// called from the main thread or they risk crashing! + static bool UpdateCachedDimensions(NSView* view, u32* width, u32* height) { NSWindow* window = [view window]; @@ -35,12 +38,10 @@ static bool AttachContextToView(NSOpenGLContext* context, NSView* view, u32* wid (void)UpdateCachedDimensions(view, width, height); - // the following calls can crash if not called from the main thread on macOS 10.15 - dispatch_sync(dispatch_get_main_queue(), ^{ - [window makeFirstResponder:view]; - [context setView:view]; - [window makeKeyAndOrderFront:nil]; - }); + [window makeFirstResponder:view]; + [context setView:view]; + [window makeKeyAndOrderFront:nil]; + return true; } @@ -98,8 +99,16 @@ bool GLContextAGL::Initialize(const WindowSystemInfo& wsi, bool stereo, bool cor m_view = static_cast<NSView*>(wsi.render_surface); m_opengl_mode = Mode::OpenGL; - if (!AttachContextToView(m_context, m_view, &m_backbuffer_width, &m_backbuffer_height)) + + __block bool success; + dispatch_sync(dispatch_get_main_queue(), ^{ + success = AttachContextToView(m_context, m_view, &m_backbuffer_width, &m_backbuffer_height); + }); + + if (!success) + { return false; + } [m_context makeCurrentContext]; return true; @@ -140,11 +149,12 @@ void GLContextAGL::Update() if (!m_view) return; - if (UpdateCachedDimensions(m_view, &m_backbuffer_width, &m_backbuffer_height)) - // the following calls can crash if not called from the main thread on macOS 10.15 - dispatch_sync(dispatch_get_main_queue(), ^{ + dispatch_sync(dispatch_get_main_queue(), ^{ + if (UpdateCachedDimensions(m_view, &m_backbuffer_width, &m_backbuffer_height)) + { [m_context update]; - }); + } + }); } void GLContextAGL::SwapInterval(int interval) |
