| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Fixes bug: https://bugs.dolphin-emu.org/issues/12744
Before https://github.com/dolphin-emu/dolphin/commit/e1e3db13baabefa89991388d37db0bb260c4f535
the ControllerInterface m_devices_mutex was "wrongfully" locked for the whole Initialize() call, which included the first device population refresh,
this has the unwanted (accidental) consequence of often preventing the different pads (GC Pad, Wii Contollers, ...) input configs from loading
until that mutex was released (the input config defaults loading was blocked in EmulatedController::LoadDefaults()), which meant that the devices
population would often have the time to finish adding its first device, which would then be selected as default device (by design, the first device
added to the CI is the default default device, usually the "Keyboard and Mouse" device).
After the commit mentioned above removed the unnecessary m_devices_mutex calls, the default default device would fail to load (be found)
causing the default input mappings, which are specifically written for the default default device on every platform, to not be bound to any
physical device input, breaking input on new dolphin installations (until a user tried to customize the default device manually).
Default devices are now always added synchronously to avoid the problem, and so they should in the future (I added comments and warnings to help with that)
|
|
|
|
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
|
|
Also fix the cursor axis not being updated when the mouse device had failed aquiring,
despite them being completely unrelated
|
|
also fix devices being added to its own custom list of devices even when rejected by the CI
|
|
devices
Also polished DInput code in general to try and mitigate issue 11702.
Added a lot of logging and comments.
|
|
sorting priority
This helps us keeping the most important devices (e.g. Mouse and Keyboard) on the top
of the list of devices (they still are on all OSes supported by dolphin
and to make hotplug devices like DSU appear at the bottom.
|
|
|
|
the raw delta mouse input
Co-authored-by: Jordan Woyak <jordan.woyak@gmail.com>
|
|
|
|
|
|
Continues the migration of the logging calls over to the fmt capable
ones.
|
|
|
|
This function does *not* always convert from UTF-16. It converts
from UTF-16 on Windows and UTF-32 on other operating systems.
Also renaming UTF8ToUTF16 for consistency, even though it
technically doesn't have the same problem since it only was
implemented on Windows.
|
|
|
|
|
|
|
|
Introduced in a995e2f5ba3bb55b4245675428bbdc3d34cb7355
We need to be performing a bitwise AND on the flags and not a logical
AND, otherwise we could end up counting device objects that don't
support forced feedback.
|
|
|
|
|
|
|
|
|
|
hotplug event.
|
|
|
|
|
|
|
|
|
|
crash with periodic effects and my GCPad adapter (probably a divide by zero behind the scenes).
|
|
should prevent slowdowns experienced by a handful of users.
|
|
These were not caught by the lint script while it was broken.
|
|
|
|
The SDL backend crashes when you close a joystick after SDL_Quit has
been called. Some backends don't need to be shutdown and
re-initialized everytime, we can just ask to enumerate devices again.
|
|
Rewrite GetXInputGUIDS to use SetupAPI instead of WMI Queries. When
using a language pack where the system language and user/program
language differ, Windows starts taking a VERY long time (10+ seconds)
to complete Queries for Win32_PNPEntity objects (it's probably
translating every single string since it transfers every single one
from the WMI server into memory in the program).
Fixes Issue 9744.
|
|
This makes the device ID assigning code common to all backends, by
moving it to AddDevice() instead of copy-pasting or replicating
the logic in the backends.
Also, to prepare for hotplugging, instead of relying on a name usage
count, the new ID assigning system always starts from ID 0 and tries
to assign the first ID that is not used.
|
|
Small cleanup by using std::shared_ptr and getting rid of
ciface.Devices() which just returned the m_devices (which defeats the
point of making m_devices protected).
Incidentally, this should make the code safer when we have
different threads accessing devices in the future (for hotplug?).
A lot of code use Device references directly so there is
no easy way to remove FindDevice() and make those unique_ptrs.
|
|
|
|
Previously, the devices vector would be passed to all backends. They
would then manually push_back to it to add new devices. This was fine
but caused issues when trying to add synchronisation.
Instead, backends now call AddDevice() to fill m_devices so that it is
not accessible from the outside.
|
|
|
|
Fixes issue 8673.
|
|
|
|
|
|
|
|
|
|
of the original hwnd.
|
|
The return values here have never been checked, so it doesn't make sense
to return a value to begin with.
|
|
|
|
The LEDs feature doesn't actually do anything: the SetState method is
entirely commented out.
|
|
|
|
to use it.
Fixes an off by 1 issue related to double->float->double conversion, and eliminates numerous warnings.
|
