summaryrefslogtreecommitdiff
path: root/src/overlays
diff options
context:
space:
mode:
authorengineer124 <47598039+engineer124@users.noreply.github.com>2023-11-27 21:02:28 +1100
committerGitHub <noreply@github.com>2023-11-27 21:02:28 +1100
commit702f3cf44e7a6972801150a6d13d6fbb2283f230 (patch)
tree759a31b35a4cb8876d93ebdf0bf13da16e8bc5b4 /src/overlays
parentc04aaab6a1d0bdaf6071fadc649385fd3e71e774 (diff)
Document Actor Category Change (#1518)
* Actor Category Change * cleanup * comments * adj comment * revert small cleanup for libc64 PR * adjust comments
Diffstat (limited to 'src/overlays')
-rw-r--r--src/overlays/actors/ovl_Bg_Hakugin_Switch/z_bg_hakugin_switch.c4
-rw-r--r--src/overlays/actors/ovl_Boss_01/z_boss_01.c2
-rw-r--r--src/overlays/actors/ovl_Boss_05/z_boss_05.c6
-rw-r--r--src/overlays/actors/ovl_En_Bee/z_en_bee.c4
-rw-r--r--src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c4
-rw-r--r--src/overlays/actors/ovl_En_Bombf/z_en_bombf.c2
-rw-r--r--src/overlays/actors/ovl_En_Dekubaba/z_en_dekubaba.c2
-rw-r--r--src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c2
-rw-r--r--src/overlays/actors/ovl_En_Fishing/z_en_fishing.c2
-rw-r--r--src/overlays/actors/ovl_En_Fz/z_en_fz.c2
-rw-r--r--src/overlays/actors/ovl_En_Jso/z_en_jso.c2
-rw-r--r--src/overlays/actors/ovl_En_Karebaba/z_en_karebaba.c4
-rw-r--r--src/overlays/actors/ovl_En_Kusa2/z_en_kusa2.c2
-rw-r--r--src/overlays/actors/ovl_En_Mnk/z_en_mnk.c2
-rw-r--r--src/overlays/actors/ovl_En_Poh/z_en_poh.c2
-rw-r--r--src/overlays/actors/ovl_En_Raf/z_en_raf.c4
-rw-r--r--src/overlays/actors/ovl_En_Rd/z_en_rd.c2
-rw-r--r--src/overlays/actors/ovl_En_Sw/z_en_sw.c6
-rw-r--r--src/overlays/actors/ovl_En_Tanron2/z_en_tanron2.c2
-rw-r--r--src/overlays/actors/ovl_En_Test3/z_en_test3.c8
-rw-r--r--src/overlays/actors/ovl_En_Tsn/z_en_tsn.c2
-rw-r--r--src/overlays/actors/ovl_En_Tubo_Trap/z_en_tubo_trap.c2
-rw-r--r--src/overlays/actors/ovl_En_Weather_Tag/z_en_weather_tag.c2
-rw-r--r--src/overlays/actors/ovl_En_Wf/z_en_wf.c2
-rw-r--r--src/overlays/actors/ovl_Obj_Bean/z_obj_bean.c2
-rw-r--r--src/overlays/actors/ovl_Obj_Mure/z_obj_mure.c2
-rw-r--r--src/overlays/actors/ovl_Obj_Roomtimer/z_obj_roomtimer.c2
-rw-r--r--src/overlays/actors/ovl_Obj_Usiyane/z_obj_usiyane.c2
28 files changed, 40 insertions, 40 deletions
diff --git a/src/overlays/actors/ovl_Bg_Hakugin_Switch/z_bg_hakugin_switch.c b/src/overlays/actors/ovl_Bg_Hakugin_Switch/z_bg_hakugin_switch.c
index b1e1cfa8f..7bc5ce060 100644
--- a/src/overlays/actors/ovl_Bg_Hakugin_Switch/z_bg_hakugin_switch.c
+++ b/src/overlays/actors/ovl_Bg_Hakugin_Switch/z_bg_hakugin_switch.c
@@ -400,7 +400,7 @@ void func_80B16244(BgHakuginSwitch* this, PlayState* play) {
this->dyna.actor.world.pos.y = this->dyna.actor.home.pos.y;
if ((BGHAKUGINSWITCH_GET_7(&this->dyna.actor) == BGHAKUGINSWITCH_GET_7_1) &&
(this->dyna.actor.category != ACTORCAT_SWITCH)) {
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, 0);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_SWITCH);
}
this->actionFunc = func_80B162AC;
}
@@ -459,7 +459,7 @@ void func_80B16494(BgHakuginSwitch* this, PlayState* play) {
this->dyna.actor.world.pos.y = (this->dyna.actor.home.pos.y - (1800.0f * this->dyna.actor.scale.y)) + 2.0f;
if ((BGHAKUGINSWITCH_GET_7(&this->dyna.actor) == BGHAKUGINSWITCH_GET_7_1) &&
(this->dyna.actor.category != ACTORCAT_PROP)) {
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_PROP);
}
this->actionFunc = func_80B16520;
}
diff --git a/src/overlays/actors/ovl_Boss_01/z_boss_01.c b/src/overlays/actors/ovl_Boss_01/z_boss_01.c
index 6a9e6c838..26ce0eda7 100644
--- a/src/overlays/actors/ovl_Boss_01/z_boss_01.c
+++ b/src/overlays/actors/ovl_Boss_01/z_boss_01.c
@@ -2107,7 +2107,7 @@ void Boss01_SetupDeathCutscene(Boss01* this, PlayState* play) {
this->cutsceneState = ODOLWA_DEATH_CS_STATE_STARTED;
SEQCMD_STOP_SEQUENCE(SEQ_PLAYER_BGM_MAIN, 1);
sMothSwarm->unk_144 = 250;
- func_800BC154(play, &play->actorCtx, &sMothSwarm->actor, ACTORCAT_BOSS);
+ Actor_ChangeCategory(play, &play->actorCtx, &sMothSwarm->actor, ACTORCAT_BOSS);
}
/**
diff --git a/src/overlays/actors/ovl_Boss_05/z_boss_05.c b/src/overlays/actors/ovl_Boss_05/z_boss_05.c
index ead388dc9..06d8f3b4a 100644
--- a/src/overlays/actors/ovl_Boss_05/z_boss_05.c
+++ b/src/overlays/actors/ovl_Boss_05/z_boss_05.c
@@ -388,7 +388,7 @@ void Boss05_Init(Actor* thisx, PlayState* play) {
this->dyna.actor.params = BIO_BABA_TYPE_LILY_PAD;
this->actionFunc = Boss05_LilyPad_Idle;
this->dyna.actor.flags &= ~ACTOR_FLAG_TARGETABLE;
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_BG);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_BG);
}
} else if (BIO_BABA_GET_TYPE(&this->dyna.actor) == BIO_BABA_TYPE_LILY_PAD) {
this->actionFunc = Boss05_LilyPad_Idle;
@@ -399,7 +399,7 @@ void Boss05_Init(Actor* thisx, PlayState* play) {
SkelAnime_InitFlex(play, &this->lilyPadSkelAnime, &gBioDekuBabaLilyPadSkel, &gBioDekuBabaLilyPadIdleAnim,
this->lilyPadJointTable, this->lilyPadMorphTable, BIO_DEKU_BABA_LILY_PAD_LIMB_MAX);
this->dyna.actor.flags &= ~ACTOR_FLAG_TARGETABLE;
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_BG);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_BG);
} else if (BIO_BABA_GET_TYPE(&this->dyna.actor) == BIO_BABA_TYPE_FALLING_HEAD) {
this->actionFunc = Boss05_FallingHead_Fall;
this->fallingHeadLilyPadLimbScale = 1.0f;
@@ -781,7 +781,7 @@ void Boss05_LilyPadWithHead_Move(Boss05* this, PlayState* play) {
this->dyna.actor.params = BIO_BABA_TYPE_LILY_PAD;
this->actionFunc = Boss05_LilyPad_Idle;
this->dyna.actor.flags &= ~ACTOR_FLAG_TARGETABLE;
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_BG);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_BG);
if (this->forceDetachTimer != 0) {
hitReaction = BIO_BABA_HEAD_HIT_REACTION_DEATCH;
}
diff --git a/src/overlays/actors/ovl_En_Bee/z_en_bee.c b/src/overlays/actors/ovl_En_Bee/z_en_bee.c
index a23a4d486..2034dccba 100644
--- a/src/overlays/actors/ovl_En_Bee/z_en_bee.c
+++ b/src/overlays/actors/ovl_En_Bee/z_en_bee.c
@@ -105,7 +105,7 @@ void EnBee_Init(Actor* thisx, PlayState* play) {
this->actor.shape.shadowScale = 12.0f;
if (CutsceneManager_GetCurrentCsId() != CS_ID_NONE) {
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_ITEMACTION);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ITEMACTION);
}
this->actor.hintId = TATL_HINT_ID_GIANT_BEE;
@@ -151,7 +151,7 @@ void EnBee_FlyIdle(EnBee* this, PlayState* play) {
s32 pad[2];
if ((this->actor.category != ACTORCAT_ENEMY) && (CutsceneManager_GetCurrentCsId() == CS_ID_NONE)) {
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
}
Math_Vec3f_Copy(&nextPos, &this->targetPos[this->posIndex]);
diff --git a/src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c b/src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c
index 92e542f4d..490ded3c6 100644
--- a/src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c
+++ b/src/overlays/actors/ovl_En_Bigpo/z_en_bigpo.c
@@ -748,7 +748,7 @@ void EnBigpo_SetupLanternDrop(EnBigpo* this, PlayState* play) {
this->actor.shape.rot.x = -0x8000;
this->actor.velocity.y = 0.0f;
this->actor.world.pos.y -= 15.0f;
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
this->actor.flags &= ~(ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_UNFRIENDLY); // targetable OFF, enemy music OFF
this->actor.bgCheckFlags &= ~BGCHECKFLAG_PLAYER_400;
this->actionFunc = EnBigpo_LanternFalling;
@@ -895,7 +895,7 @@ void EnBigpo_SelectRandomFireLocations(EnBigpo* this, PlayState* play) {
Math_Vec3f_Copy(&this->fires[fireIndex].pos, &randomFirePo->actor.world.pos);
randomFirePo->actor.parent = (Actor*)this;
randomFirePo->actor.update = EnBigpo_UpdateFire;
- func_800BC154(play, &play->actorCtx, &randomFirePo->actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &randomFirePo->actor, ACTORCAT_PROP);
randomFirePo->unk20C = fireIndex;
randomFirePo->actor.flags &= ~ACTOR_FLAG_TARGETABLE;
// make invisible by size: 0
diff --git a/src/overlays/actors/ovl_En_Bombf/z_en_bombf.c b/src/overlays/actors/ovl_En_Bombf/z_en_bombf.c
index a241d94d0..75852a9d9 100644
--- a/src/overlays/actors/ovl_En_Bombf/z_en_bombf.c
+++ b/src/overlays/actors/ovl_En_Bombf/z_en_bombf.c
@@ -116,7 +116,7 @@ void EnBombf_Init(Actor* thisx, PlayState* play2) {
this->timer = 140;
this->unk_1FE = 15;
thisx->gravity = -1.5f;
- func_800BC154(play, &play->actorCtx, thisx, 3);
+ Actor_ChangeCategory(play, &play->actorCtx, thisx, ACTORCAT_EXPLOSIVES);
thisx->colChkInfo.mass = 200;
thisx->flags &= ~ACTOR_FLAG_TARGETABLE;
EnBombf_SetupAction(this, func_808AEE3C);
diff --git a/src/overlays/actors/ovl_En_Dekubaba/z_en_dekubaba.c b/src/overlays/actors/ovl_En_Dekubaba/z_en_dekubaba.c
index adf3639a7..41ef4302e 100644
--- a/src/overlays/actors/ovl_En_Dekubaba/z_en_dekubaba.c
+++ b/src/overlays/actors/ovl_En_Dekubaba/z_en_dekubaba.c
@@ -1043,7 +1043,7 @@ void EnDekubaba_SetupDeadStickDrop(EnDekubaba* this, PlayState* play) {
this->actor.gravity = 0.0f;
this->actor.velocity.y = 0.0f;
this->actor.shape.shadowScale = 3.0f;
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
this->actor.flags &= ~ACTOR_FLAG_20;
this->timer = 200;
this->drawDmgEffAlpha = 0.0f;
diff --git a/src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c b/src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
index 314db46bf..4d8156a5f 100644
--- a/src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
+++ b/src/overlays/actors/ovl_En_Dinofos/z_en_dinofos.c
@@ -1143,7 +1143,7 @@ void func_8089D018(EnDinofos* this, PlayState* play) {
s32 temp_v0 = this->unk_288 - 10;
if (this->actor.category == ACTORCAT_ENEMY) {
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
func_8089ABF4(this, play);
}
diff --git a/src/overlays/actors/ovl_En_Fishing/z_en_fishing.c b/src/overlays/actors/ovl_En_Fishing/z_en_fishing.c
index 69720cdc8..cc26b6ecf 100644
--- a/src/overlays/actors/ovl_En_Fishing/z_en_fishing.c
+++ b/src/overlays/actors/ovl_En_Fishing/z_en_fishing.c
@@ -958,7 +958,7 @@ void EnFishing_Init(Actor* thisx, PlayState* play2) {
if (thisx->params == 200) {
this->unk_150 = 100;
- func_800BC154(play, &play->actorCtx, thisx, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, thisx, ACTORCAT_PROP);
thisx->targetMode = TARGET_MODE_0;
thisx->flags |= (ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_FRIENDLY);
this->lightNode = LightContext_InsertLight(play, &play->lightCtx, &this->lightInfo);
diff --git a/src/overlays/actors/ovl_En_Fz/z_en_fz.c b/src/overlays/actors/ovl_En_Fz/z_en_fz.c
index 0b4652496..c4ae08bd3 100644
--- a/src/overlays/actors/ovl_En_Fz/z_en_fz.c
+++ b/src/overlays/actors/ovl_En_Fz/z_en_fz.c
@@ -656,7 +656,7 @@ void func_809336C0(EnFz* this, PlayState* play) {
this->actor.flags &= ~ACTOR_FLAG_TARGETABLE;
this->unk_BD7 = 0;
this->unk_BCA = 60;
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
Item_DropCollectibleRandom(play, &this->actor, &this->actor.world.pos, 0xA0);
this->actionFunc = func_80933760;
}
diff --git a/src/overlays/actors/ovl_En_Jso/z_en_jso.c b/src/overlays/actors/ovl_En_Jso/z_en_jso.c
index 0efa7799e..98c3f330b 100644
--- a/src/overlays/actors/ovl_En_Jso/z_en_jso.c
+++ b/src/overlays/actors/ovl_En_Jso/z_en_jso.c
@@ -1166,7 +1166,7 @@ void EnJso_SetupFallDownAndTalk(EnJso* this, PlayState* play) {
this->textIndex = 2;
this->actor.colChkInfo.mass = MASS_IMMOVABLE;
this->actor.flags |= (ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_FRIENDLY);
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_NPC);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_NPC);
this->actor.flags &= ~ACTOR_FLAG_CANT_LOCK_ON;
this->actor.flags &= ~ACTOR_FLAG_100000;
this->action = EN_JSO_ACTION_FALL_DOWN_AND_TALK;
diff --git a/src/overlays/actors/ovl_En_Karebaba/z_en_karebaba.c b/src/overlays/actors/ovl_En_Karebaba/z_en_karebaba.c
index ebfe9e7d1..cfdb2bda9 100644
--- a/src/overlays/actors/ovl_En_Karebaba/z_en_karebaba.c
+++ b/src/overlays/actors/ovl_En_Karebaba/z_en_karebaba.c
@@ -485,7 +485,7 @@ void EnKarebaba_SetupDeadItemDrop(EnKarebaba* this, PlayState* play) {
this->actor.gravity = 0.0f;
this->actor.velocity.y = 0.0f;
this->actor.shape.shadowScale = 3.0f;
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
this->timer = 200;
this->actor.flags &= ~ACTOR_FLAG_20;
this->drawDmgEffAlpha = 0.0f;
@@ -553,7 +553,7 @@ void EnKarebaba_Regrow(EnKarebaba* this, PlayState* play) {
this->actor.flags &= ~ACTOR_FLAG_10;
this->actor.flags |= (ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_UNFRIENDLY);
if (this->actor.params == ENKAREBABA_1) {
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
}
EnKarebaba_SetupIdle(this);
}
diff --git a/src/overlays/actors/ovl_En_Kusa2/z_en_kusa2.c b/src/overlays/actors/ovl_En_Kusa2/z_en_kusa2.c
index 6c833867c..df03abf51 100644
--- a/src/overlays/actors/ovl_En_Kusa2/z_en_kusa2.c
+++ b/src/overlays/actors/ovl_En_Kusa2/z_en_kusa2.c
@@ -864,7 +864,7 @@ void EnKusa2_Init(Actor* thisx, PlayState* play) {
this->actor.update = func_80A5E604;
this->actor.draw = NULL;
this->actor.flags |= ACTOR_FLAG_20;
- func_800BC154(play, &play->actorCtx, &this->actor, 1);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_BG);
this->unk_1BE = 0;
if (D_80A5EAEC != 0) {
D_80A5EAEC = 0;
diff --git a/src/overlays/actors/ovl_En_Mnk/z_en_mnk.c b/src/overlays/actors/ovl_En_Mnk/z_en_mnk.c
index 2477a5b68..094438d08 100644
--- a/src/overlays/actors/ovl_En_Mnk/z_en_mnk.c
+++ b/src/overlays/actors/ovl_En_Mnk/z_en_mnk.c
@@ -274,7 +274,7 @@ void EnMnk_MonkeyTiedUp_Init(Actor* thisx, PlayState* play) {
void EnMnk_MonkeyHanging_Init(Actor* thisx, PlayState* play) {
EnMnk* this = THIS;
- func_800BC154(play, &play->actorCtx, &this->picto.actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->picto.actor, ACTORCAT_PROP);
this->actionFunc = EnMnk_MonkeyHanging_StruggleBeforeDunk;
this->picto.actor.textId = 0x8E8;
SkelAnime_InitFlex(play, &this->propSkelAnime, &gMonkeyHangingRopeSkel, &gMonkeyHangingStruggleAnim,
diff --git a/src/overlays/actors/ovl_En_Poh/z_en_poh.c b/src/overlays/actors/ovl_En_Poh/z_en_poh.c
index 2c6fe4ebe..95cac64e5 100644
--- a/src/overlays/actors/ovl_En_Poh/z_en_poh.c
+++ b/src/overlays/actors/ovl_En_Poh/z_en_poh.c
@@ -576,7 +576,7 @@ void func_80B2DC50(EnPoh* this, PlayState* play) {
this->actor.shape.yOffset = 1500.0f;
this->actor.world.pos.y -= 15.0f;
this->actor.shape.rot.x = -0x8000;
- func_800BC154(play, &play->actorCtx, &this->actor, 8);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_MISC);
this->actor.flags &= ~(ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_UNFRIENDLY);
this->actionFunc = func_80B2DD2C;
}
diff --git a/src/overlays/actors/ovl_En_Raf/z_en_raf.c b/src/overlays/actors/ovl_En_Raf/z_en_raf.c
index 1139e9a89..7476a9b18 100644
--- a/src/overlays/actors/ovl_En_Raf/z_en_raf.c
+++ b/src/overlays/actors/ovl_En_Raf/z_en_raf.c
@@ -537,7 +537,7 @@ void EnRaf_Explode(EnRaf* this, PlayState* play) {
this->timer = 5;
if (this->grabTarget == EN_RAF_GRAB_TARGET_EXPLOSIVE) {
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, 5);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_ENEMY);
this->dyna.actor.flags |= (ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_UNFRIENDLY);
}
@@ -551,7 +551,7 @@ void EnRaf_PostDetonation(EnRaf* this, PlayState* play) {
if (this->timer == 0) {
this->collider.dim.radius = 50;
this->collider.dim.height = 10;
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, 6);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_PROP);
this->dyna.actor.flags &= ~(ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_UNFRIENDLY);
EnRaf_SetupDormant(this);
} else if (this->grabTarget == EN_RAF_GRAB_TARGET_EXPLOSIVE) {
diff --git a/src/overlays/actors/ovl_En_Rd/z_en_rd.c b/src/overlays/actors/ovl_En_Rd/z_en_rd.c
index b83dbf1f1..1ec240e41 100644
--- a/src/overlays/actors/ovl_En_Rd/z_en_rd.c
+++ b/src/overlays/actors/ovl_En_Rd/z_en_rd.c
@@ -1051,7 +1051,7 @@ void EnRd_SetupDead(EnRd* this) {
void EnRd_Dead(EnRd* this, PlayState* play) {
if (this->actor.category != ACTORCAT_PROP) {
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
}
Math_SmoothStepToS(&this->headYRotation, 0, 1, 2000, 0);
diff --git a/src/overlays/actors/ovl_En_Sw/z_en_sw.c b/src/overlays/actors/ovl_En_Sw/z_en_sw.c
index 6599ec001..ca4d53a9f 100644
--- a/src/overlays/actors/ovl_En_Sw/z_en_sw.c
+++ b/src/overlays/actors/ovl_En_Sw/z_en_sw.c
@@ -629,7 +629,7 @@ void func_808D9F08(EnSw* this) {
void func_808D9F78(EnSw* this, PlayState* play, s32 arg2) {
if (arg2 != 0) {
- func_800BC154(play, &play->actorCtx, &this->actor, 5);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
}
Actor_SetScale(&this->actor, 0.02f);
func_808D9DA0(this);
@@ -1061,7 +1061,7 @@ void func_808DB100(EnSw* this, PlayState* play) {
this->unk_456 = 0;
this->unk_454 = 0;
this->skelAnime.curFrame = 0.0f;
- func_800BC154(play, &play->actorCtx, &this->actor, 4);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_NPC);
this->actionFunc = func_808DB25C;
return;
}
@@ -1113,7 +1113,7 @@ void func_808DB2E0(EnSw* this, PlayState* play) {
if ((s32)temp_f2 != 0) {
Actor_PlaySfx(&this->actor, NA_SE_EN_STALTURA_BOUND);
} else {
- func_800BC154(play, &play->actorCtx, &this->actor, 5);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
Math_Vec3f_Copy(&this->actor.velocity, &gZeroVec3f);
this->unk_410 &= ~(0x10 | 0x1);
this->actionFunc = func_808DB100;
diff --git a/src/overlays/actors/ovl_En_Tanron2/z_en_tanron2.c b/src/overlays/actors/ovl_En_Tanron2/z_en_tanron2.c
index 3993a9c91..e018a0c06 100644
--- a/src/overlays/actors/ovl_En_Tanron2/z_en_tanron2.c
+++ b/src/overlays/actors/ovl_En_Tanron2/z_en_tanron2.c
@@ -128,7 +128,7 @@ void EnTanron2_Init(Actor* thisx, PlayState* play) {
if (this->actor.params == 100) {
this->actor.update = func_80BB7B90;
- func_800BC154(play, &play->actorCtx, &this->actor, 5);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
return;
}
diff --git a/src/overlays/actors/ovl_En_Test3/z_en_test3.c b/src/overlays/actors/ovl_En_Test3/z_en_test3.c
index 6fedf9d41..c2f51dd92 100644
--- a/src/overlays/actors/ovl_En_Test3/z_en_test3.c
+++ b/src/overlays/actors/ovl_En_Test3/z_en_test3.c
@@ -525,8 +525,8 @@ s32 func_80A3F09C(EnTest3* this, PlayState* play) {
}
void func_80A3F0B0(EnTest3* this, PlayState* play) {
- func_800BC154(play, &play->actorCtx, &this->unk_D90->actor, 2);
- func_800BC154(play, &play->actorCtx, &this->player.actor, 4);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->unk_D90->actor, ACTORCAT_PLAYER);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->player.actor, ACTORCAT_NPC);
this->unk_D90->stateFlags1 &= ~PLAYER_STATE1_20;
}
@@ -669,8 +669,8 @@ s32 func_80A3F73C(EnTest3* this, PlayState* play) {
play->actorCtx.flags &= ~ACTORCTX_FLAG_4;
this->player.stateFlags2 &= ~PLAYER_STATE2_40000;
this->unk_D90->stateFlags1 |= PLAYER_STATE1_20;
- func_800BC154(play, &play->actorCtx, &this->unk_D90->actor, 4);
- func_800BC154(play, &play->actorCtx, &this->player.actor, 2);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->unk_D90->actor, ACTORCAT_NPC);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->player.actor, ACTORCAT_PLAYER);
CutsceneManager_SetReturnCamera(this->subCamId);
play->tryPlayerCsAction(play, &this->player, PLAYER_CSACTION_WAIT);
}
diff --git a/src/overlays/actors/ovl_En_Tsn/z_en_tsn.c b/src/overlays/actors/ovl_En_Tsn/z_en_tsn.c
index cd595c6c4..fc794c45a 100644
--- a/src/overlays/actors/ovl_En_Tsn/z_en_tsn.c
+++ b/src/overlays/actors/ovl_En_Tsn/z_en_tsn.c
@@ -118,7 +118,7 @@ void func_80ADFCEC(EnTsn* this, PlayState* play) {
if (this->unk_1D8 == NULL) {
Actor_Kill(&this->actor);
} else if ((ENTSN_GET_F(&this->actor)) == ENTSN_F_1) {
- func_800BC154(play, &play->actorCtx, &this->actor, 6);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
}
}
diff --git a/src/overlays/actors/ovl_En_Tubo_Trap/z_en_tubo_trap.c b/src/overlays/actors/ovl_En_Tubo_Trap/z_en_tubo_trap.c
index 83d54f837..c50e82377 100644
--- a/src/overlays/actors/ovl_En_Tubo_Trap/z_en_tubo_trap.c
+++ b/src/overlays/actors/ovl_En_Tubo_Trap/z_en_tubo_trap.c
@@ -234,7 +234,7 @@ void EnTuboTrap_Idle(EnTuboTrap* this, PlayState* play) {
if ((this->actor.xzDistToPlayer < 200.0f) && (this->actor.world.pos.y <= player->actor.world.pos.y)) {
startingRotation = this->actor.home.rot.z;
if ((startingRotation == 0) || (this->actor.playerHeightRel <= (startingRotation * 10.0f))) {
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
currentHeight = this->actor.world.pos.y;
this->actor.flags |= (ACTOR_FLAG_TARGETABLE | ACTOR_FLAG_10); // always update and can target
diff --git a/src/overlays/actors/ovl_En_Weather_Tag/z_en_weather_tag.c b/src/overlays/actors/ovl_En_Weather_Tag/z_en_weather_tag.c
index 90f724bcf..768ba05ab 100644
--- a/src/overlays/actors/ovl_En_Weather_Tag/z_en_weather_tag.c
+++ b/src/overlays/actors/ovl_En_Weather_Tag/z_en_weather_tag.c
@@ -91,7 +91,7 @@ void EnWeatherTag_Init(Actor* thisx, PlayState* play) {
break;
case WEATHERTAG_TYPE_UNK5:
- func_800BC154(play, &play->actorCtx, &this->actor, 7);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ITEMACTION);
play->skyboxId = SKYBOX_3;
play->envCtx.lightConfig = 5;
play->envCtx.changeLightNextConfig = 5;
diff --git a/src/overlays/actors/ovl_En_Wf/z_en_wf.c b/src/overlays/actors/ovl_En_Wf/z_en_wf.c
index d2f1595cf..6160cc15a 100644
--- a/src/overlays/actors/ovl_En_Wf/z_en_wf.c
+++ b/src/overlays/actors/ovl_En_Wf/z_en_wf.c
@@ -339,7 +339,7 @@ void EnWf_Init(Actor* thisx, PlayState* play) {
func_80992FD4(this);
}
- func_800BC154(play, &play->actorCtx, &this->actor, 5);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_ENEMY);
if (D_809942D8 == 0) {
for (i = 0; i < ARRAY_COUNT(sNormalEyeTextures); i++) {
diff --git a/src/overlays/actors/ovl_Obj_Bean/z_obj_bean.c b/src/overlays/actors/ovl_Obj_Bean/z_obj_bean.c
index b141ce222..bb084a14e 100644
--- a/src/overlays/actors/ovl_Obj_Bean/z_obj_bean.c
+++ b/src/overlays/actors/ovl_Obj_Bean/z_obj_bean.c
@@ -382,7 +382,7 @@ void ObjBean_Init(Actor* thisx, PlayState* play) {
return;
}
- func_800BC154(play, &play->actorCtx, &this->dyna.actor, 7);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->dyna.actor, ACTORCAT_ITEMACTION);
func_80937DD8(this);
} else {
s32 params2 = OBJBEAN_GET_3F00(&this->dyna.actor);
diff --git a/src/overlays/actors/ovl_Obj_Mure/z_obj_mure.c b/src/overlays/actors/ovl_Obj_Mure/z_obj_mure.c
index c2599941b..77d5c15d1 100644
--- a/src/overlays/actors/ovl_Obj_Mure/z_obj_mure.c
+++ b/src/overlays/actors/ovl_Obj_Mure/z_obj_mure.c
@@ -314,7 +314,7 @@ void ObjMure_SetChildToFollowPlayer(ObjMure* this, s32 idx1) {
i2++;
this->children[i]->child = this->children[i];
for (j = 0; j < maxChildren; j++) {
- if (i != j && this->children[j]->child == this->children[i]) {
+ if ((i != j) && (this->children[j]->child == this->children[i])) {
this->children[j]->child = NULL;
}
}
diff --git a/src/overlays/actors/ovl_Obj_Roomtimer/z_obj_roomtimer.c b/src/overlays/actors/ovl_Obj_Roomtimer/z_obj_roomtimer.c
index dc4335015..5393b0d7a 100644
--- a/src/overlays/actors/ovl_Obj_Roomtimer/z_obj_roomtimer.c
+++ b/src/overlays/actors/ovl_Obj_Roomtimer/z_obj_roomtimer.c
@@ -55,7 +55,7 @@ void func_80973CD8(ObjRoomtimer* this, PlayState* play) {
Interface_StartTimer(TIMER_ID_MINIGAME_2, this->actor.params);
}
- func_800BC154(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
+ Actor_ChangeCategory(play, &play->actorCtx, &this->actor, ACTORCAT_PROP);
this->actionFunc = func_80973D3C;
}
diff --git a/src/overlays/actors/ovl_Obj_Usiyane/z_obj_usiyane.c b/src/overlays/actors/ovl_Obj_Usiyane/z_obj_usiyane.c
index dad72d9a7..05d331465 100644
--- a/src/overlays/actors/ovl_Obj_Usiyane/z_obj_usiyane.c
+++ b/src/overlays/actors/ovl_Obj_Usiyane/z_obj_usiyane.c
@@ -111,7 +111,7 @@ void func_80C07F30(ObjUsiyane* this, PlayState* play) {
for (i = 0; i < ARRAY_COUNT(this->unk_168[0]); i++) {
for (j = 0; j < ARRAY_COUNT(this->unk_168); j++) {
- if (i != ARRAY_COUNT(this->unk_168[0]) - 1) {
+ if (i != (ARRAY_COUNT(this->unk_168[0]) - 1)) {
func_80C07DFC(&this->unk_710[i], &D_80C08660[i].rot, &this->unk_710[i + 1], &D_80C08660[i + 1].rot, j,
10, &this->unk_168[j][i].unk_00, &this->unk_168[j][i].unk_18);
} else {