diff options
| author | Dragorn421 <Dragorn421@users.noreply.github.com> | 2023-11-12 22:59:52 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-11-12 16:59:52 -0500 |
| commit | 4c75260097135edb171501942e451474fce66c50 (patch) | |
| tree | 5ecafffc7ee1eb140504bdb745329a3c8f9cfa83 /src/code/code_800FC620.c | |
| parent | dc323052c36959e7221a927c094053e279334f41 (diff) | |
Fix misc 21 (#1573)
* Make `sNew` in (unused) `code_800FC620.c` a string
It is passed as a filename to `__osMallocDebug` so should be a nul-terminated string, not a char[3] missing an explicit \0
* Fix gcc warning in `JpegDecoder_ParseNextSymbol` about SLL on negative value
-1U is an unsigned value, aka 0xFFFFFFFF
I keep -1 because it seems that's what a jpeg standard has too
References:
https://stackoverflow.com/questions/40508958/shifting-a-negative-signed-value-is-undefined
https://www.w3.org/Graphics/JPEG/itu-t81.pdf (page 105, figure F.12)
* Small cleanup
* Fix few mistakes (thanks gcc warnings)
* Add `@bug` in file select settings draw code, using the wrong array
* format
* format main
* rename arg for a happy formatter
* Move important function call out of a printf
Diffstat (limited to 'src/code/code_800FC620.c')
| -rw-r--r-- | src/code/code_800FC620.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/code/code_800FC620.c b/src/code/code_800FC620.c index d31d028a9..deca11a4f 100644 --- a/src/code/code_800FC620.c +++ b/src/code/code_800FC620.c @@ -13,7 +13,7 @@ typedef struct InitFunc { // .data void* sInitFuncs = NULL; -char sNew[] = { 'n', 'e', 'w' }; +char sNew[] = "new"; char D_80134488[0x18] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x7F, 0x80, 0x00, 0x00, @@ -100,7 +100,7 @@ void func_800FCB34(void) { initFunc = (InitFunc*)((s32)initFunc + nextOffset); if (initFunc->func != NULL) { - (*initFunc->func)(); + initFunc->func(); } nextOffset = initFunc->nextOffset; |
