diff options
| author | Tharo <17233964+Thar0@users.noreply.github.com> | 2024-12-02 09:40:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-02 04:40:49 -0500 |
| commit | 3f703a39d91b0f90a273ca24fedfc7e6578ad363 (patch) | |
| tree | 43437f65da1a62794a87e29d28a9bf4df5e2c6b5 /src/code/z_actor.c | |
| parent | 6199634ffb42872d053abb1502eb80474de4ae56 (diff) | |
Fix some more GCC warnings, mark some bugs based on GCC warnings (#2309)
* Fix some more GCC warnings, mark some bugs based on GCC warnings
* Weird formatting
* Suggested changes
* More weird indentation I guess
* UNREACHABLE() macro, add missing NORETURNs to fault_n64.c
* AVOID_UB for PAL path in z_file_nameset.c
* Remove comments about return types
* Remove temp no longer needed
Diffstat (limited to 'src/code/z_actor.c')
| -rw-r--r-- | src/code/z_actor.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/code/z_actor.c b/src/code/z_actor.c index b96801fc4..7c4293689 100644 --- a/src/code/z_actor.c +++ b/src/code/z_actor.c @@ -3204,7 +3204,7 @@ Actor* Actor_SpawnEntry(ActorContext* actorCtx, ActorEntry* actorEntry, PlayStat } Actor* Actor_Delete(ActorContext* actorCtx, Actor* actor, PlayState* play) { - char* name; + UNUSED_NDEBUG char* name; Player* player; Actor* newHead; ActorOverlay* overlayEntry; @@ -4041,6 +4041,7 @@ void func_8003424C(PlayState* play, Vec3f* arg1) { } void Actor_SetColorFilter(Actor* actor, s16 colorFlag, s16 colorIntensityMax, s16 bufFlag, s16 duration) { + //! @bug This first comparison is always false as COLORFILTER_COLORFLAG_GRAY is out of range of an s16. if ((colorFlag == COLORFILTER_COLORFLAG_GRAY) && !(colorIntensityMax & COLORFILTER_INTENSITY_FLAG)) { Actor_PlaySfx(actor, NA_SE_EN_LIGHT_ARROW_HIT); } |