summaryrefslogtreecommitdiff
path: root/src/code
diff options
context:
space:
mode:
authorRoman971 <32455037+Roman971@users.noreply.github.com>2022-06-20 22:31:53 +0200
committerGitHub <noreply@github.com>2022-06-20 16:31:53 -0400
commit6d5268402086497e303a7c875b86fee8e678cd08 (patch)
treea4c5df5b5a981282f4fe41b7fd24f7187926b534 /src/code
parent017a3aaf5cdf650f756cc59a5f25a65f4de2ce58 (diff)
Format script improvements and use strict name checks (#1275)
* Prioritize using clang-tidy 6 and improve format.sh * Use clang-tidy-6.0 when available since it's better at applying 'readability-inconsistent-declaration-parameter-name' * Add -m32 and -Wno-everything to compiler options to avoid unwanted errors and warnings * Remove -fsyntax-only since it serves no purpose in the context of clang-tidy * Apply clang-tidy fixes for argument names * Run format.sh again * Use 'Strict' option instead of relying on clang-tidy 6 * Run format script * Add --fix-notes to clang-tidy options for version 13+
Diffstat (limited to 'src/code')
-rw-r--r--src/code/audio_heap.c2
-rw-r--r--src/code/audio_load.c10
2 files changed, 6 insertions, 6 deletions
diff --git a/src/code/audio_heap.c b/src/code/audio_heap.c
index 520d52274..0f5abc442 100644
--- a/src/code/audio_heap.c
+++ b/src/code/audio_heap.c
@@ -1371,7 +1371,7 @@ void AudioHeap_ChangeStorage(StorageChange* change, Sample* sample) {
}
}
-void AudioHeap_ApplySampleBankCacheInternal(s32 apply, s32 id);
+void AudioHeap_ApplySampleBankCacheInternal(s32 apply, s32 sampleBankId);
void AudioHeap_DiscardSampleBank(s32 sampleBankId) {
AudioHeap_ApplySampleBankCacheInternal(false, sampleBankId);
diff --git a/src/code/audio_load.c b/src/code/audio_load.c
index e83cd9219..846ca1a48 100644
--- a/src/code/audio_load.c
+++ b/src/code/audio_load.c
@@ -27,22 +27,22 @@ typedef struct {
typedef void SoundFontData;
/* forward declarations */
-s32 AudioLoad_SyncInitSeqPlayerInternal(s32 playerIdx, s32 seqId, s32 skipTicks);
+s32 AudioLoad_SyncInitSeqPlayerInternal(s32 playerIdx, s32 seqId, s32 arg2);
SoundFontData* AudioLoad_SyncLoadFont(u32 fontId);
Sample* AudioLoad_GetFontSample(s32 fontId, s32 instId);
void AudioLoad_ProcessAsyncLoads(s32 resetStatus);
void AudioLoad_ProcessAsyncLoadUnkMedium(AudioAsyncLoad* asyncLoad, s32 resetStatus);
void AudioLoad_ProcessAsyncLoad(AudioAsyncLoad* asyncLoad, s32 resetStatus);
void AudioLoad_RelocateFontAndPreloadSamples(s32 fontId, SoundFontData* fontData, SampleBankRelocInfo* sampleBankReloc,
- s32 async);
+ s32 isAsync);
void AudioLoad_RelocateSample(TunedSample* tunedSample, SoundFontData* fontData, SampleBankRelocInfo* sampleBankReloc);
void AudioLoad_DiscardFont(s32 fontId);
u32 AudioLoad_TrySyncLoadSampleBank(u32 sampleBankId, u32* outMedium, s32 noLoad);
-void* AudioLoad_SyncLoad(u32 tableType, u32 tableId, s32* didAllocate);
-u32 AudioLoad_GetRealTableIndex(s32 tableType, u32 tableId);
+void* AudioLoad_SyncLoad(u32 tableType, u32 id, s32* didAllocate);
+u32 AudioLoad_GetRealTableIndex(s32 tableType, u32 id);
void* AudioLoad_SearchCaches(s32 tableType, s32 id);
AudioTable* AudioLoad_GetLoadTable(s32 tableType);
-void AudioLoad_SyncDma(u32 devAddr, u8* addr, u32 size, s32 medium);
+void AudioLoad_SyncDma(u32 devAddr, u8* ramAddr, u32 size, s32 medium);
void AudioLoad_SyncDmaUnkMedium(u32 devAddr, u8* addr, u32 size, s32 unkMediumParam);
s32 AudioLoad_Dma(OSIoMesg* mesg, u32 priority, s32 direction, u32 devAddr, void* ramAddr, u32 size,
OSMesgQueue* reqQueue, s32 medium, const char* dmaFuncType);