diff options
| author | LagoLunatic <LagoLunatic@users.noreply.github.com> | 2025-12-23 18:53:10 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-23 15:53:10 -0800 |
| commit | 877889c5105e59ee3aa4e57e53d3b0c5ffcfca77 (patch) | |
| tree | 154eddaea39971210e088cb828f80d38b998f998 /src/d/actor/d_a_cow.cpp | |
| parent | 6ef13c620a46aed5fea525699a4832a1ad6e4d1f (diff) | |
Clean up code, remove fakematches, add UNUSED, enable warnings (#2992)
* Remove NDEBUG_DEFINED fakematch, clean up getName temps
* Fix ifdef
* Fix bad JSystem pch ifdef breaking decomp.me
* Remove Acch Chk fakematches
* Private Acch fields
* Fix some clangd errors in headers
* Add UNUSED macro for matching debug parameters
* Enable clangd unused-parameter warning
* Remove extern from initializers
Probably added by dol2asm?
* Fix process profile definitions
* Remove leftover dol2asm address comments
* Remove some unnecessary double casts
* Enable some more clangd warnings
* Fix missing usages of fopAcM_ct
* Fix wrong enum usage
* Fix more fakematches
Diffstat (limited to 'src/d/actor/d_a_cow.cpp')
| -rw-r--r-- | src/d/actor/d_a_cow.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/d/actor/d_a_cow.cpp b/src/d/actor/d_a_cow.cpp index 0dc61d0bb8..df44ba3924 100644 --- a/src/d/actor/d_a_cow.cpp +++ b/src/d/actor/d_a_cow.cpp @@ -59,7 +59,7 @@ static f32 l_CowRoomPosX[20] = {-10600.0f, -10600.0f, -10800.0f, -10800.0f, -110 static f32 l_CowRoomPosZ[2] = {-19646.0f, -20926.0f}; #define N_WOLF_BUSTERS 3 -extern fpc_ProcID gWolfBustersID[N_WOLF_BUSTERS] = {fpcM_ERROR_PROCESS_ID_e, fpcM_ERROR_PROCESS_ID_e, fpcM_ERROR_PROCESS_ID_e}; +fpc_ProcID gWolfBustersID[N_WOLF_BUSTERS] = {fpcM_ERROR_PROCESS_ID_e, fpcM_ERROR_PROCESS_ID_e, fpcM_ERROR_PROCESS_ID_e}; } // namespace @@ -431,10 +431,8 @@ void daCow_c::setGroundAngle() { static f32 m_near_dist; -/* 806634F8 0002+00 data_806634F8 m_view_angle_wide */ static s16 m_view_angle_wide; -/* 806634FA 0002+00 data_806634FA m_view_angle */ static s16 m_view_angle; #define IS_COW(actor) (fopAcM_GetName((actor)) == PROC_COW) @@ -3116,10 +3114,7 @@ u8 daCow_c::initialize() { } int daCow_c::create() { - if (!fopAcM_CheckCondition(this, 8)) { - new (this) daCow_c(); - fopAcM_OnCondition(this, 8); - } + fopAcM_ct(this, daCow_c); mPrm0 = fopAcM_GetParam(this); if (mPrm0 == (u8)-1 || mPrm0 >= 5) { @@ -3280,7 +3275,7 @@ static actor_method_class daCow_MethodTable = { daCow_Create, daCow_Delete, daCow_Execute, daCow_IsDelete, daCow_Draw, }; -extern actor_process_profile_definition g_profile_COW = { +actor_process_profile_definition g_profile_COW = { fpcLy_CURRENT_e, // mLayerID 7, // mListID fpcPi_CURRENT_e, // mListPrio |