diff options
| author | Jcw87 <Jcw87@users.noreply.github.com> | 2026-01-05 03:55:35 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-01-05 03:55:35 -0800 |
| commit | 22dc7a37dbc844b0eccba65025cf7f0950b98259 (patch) | |
| tree | b8fc9158a2c8b9b8b2a025a5d5d2040d2473b333 /src/d/actor | |
| parent | 767e3ba17ea514010cbc4f2015f8ffc1d4d87286 (diff) | |
fix functions not returning values (#3018)
Diffstat (limited to 'src/d/actor')
| -rw-r--r-- | src/d/actor/d_a_npc_hoz.cpp | 19 | ||||
| -rw-r--r-- | src/d/actor/d_a_obj_bemos.cpp | 3 | ||||
| -rw-r--r-- | src/d/actor/d_a_obj_kshutter.cpp | 15 | ||||
| -rw-r--r-- | src/d/actor/d_a_obj_stopper.cpp | 16 |
4 files changed, 36 insertions, 17 deletions
diff --git a/src/d/actor/d_a_npc_hoz.cpp b/src/d/actor/d_a_npc_hoz.cpp index 3463b27cde..1990a7cf2b 100644 --- a/src/d/actor/d_a_npc_hoz.cpp +++ b/src/d/actor/d_a_npc_hoz.cpp @@ -818,6 +818,25 @@ BOOL daNpc_Hoz_c::drawDbgInfo() { int daNpc_Hoz_c::test(void* i_this) { // DEBUG NONMATCHING + int r30 = 0; + switch (mMode) { + case 0: + case 1: + speedF = 0.0f; + speed.setall(0.0f); + mMode = 2; + // fall-through + case 2: + // TODO: determine pointer type of field_0xE40 + mFaceMotionSeqMngr.setNo(field_0xE40, -1.0f, 0, 0); + mMotionSeqMngr.setNo(field_0xE40, -1.0f, 0, 0); + mJntAnm.lookNone(0); + attention_info.flags = 0; + case 3: + default: + break; + } + return r30; } int daNpc_Hoz_c::selectAction() { diff --git a/src/d/actor/d_a_obj_bemos.cpp b/src/d/actor/d_a_obj_bemos.cpp index 52d796d6b5..44a8c086e7 100644 --- a/src/d/actor/d_a_obj_bemos.cpp +++ b/src/d/actor/d_a_obj_bemos.cpp @@ -1117,8 +1117,9 @@ dBgS_WtrChk daObjBm_c::Bgc_c::M_wrt_work; dBgS_ObjLinChk daObjBm_c::Bgc_c::M_wall_work[23]; -static dBgS_ObjGndChk dummy_touch_work() { +void daObjBm_c::Bgc_c::chk_wall_touch(const fopAc_ac_c*, const daObjBm_c::BgcSrc_c*, short) { static dBgS_ObjLinChk touch_work; + const static float bgc_add = 10.0f; } static f32 dummy_rodata_5158() { diff --git a/src/d/actor/d_a_obj_kshutter.cpp b/src/d/actor/d_a_obj_kshutter.cpp index 96c3711ca3..e2e425097c 100644 --- a/src/d/actor/d_a_obj_kshutter.cpp +++ b/src/d/actor/d_a_obj_kshutter.cpp @@ -308,12 +308,8 @@ cPhs__Step daObjKshtr_c::phase_0() { if (!field_0x619) { mHomeAngleZ = home.angle.z; mHomeAngleX = home.angle.x; - shape_angle.x = 0; - current.angle.x = 0; - home.angle.x = 0; - shape_angle.z = 0; - current.angle.z = 0; - home.angle.z = 0; + home.angle.x = current.angle.x = shape_angle.x = 0; + home.angle.z = current.angle.z = shape_angle.z = 0; field_0x619 = true; } @@ -330,7 +326,8 @@ cPhs__Step daObjKshtr_c::phase_0() { #endif #if DEBUG - if (mType >= 6) { + int r28 = 5; + if (mType > r28) { OS_REPORT_ERROR("鍵付き壁ドア:引数0のタイプ指定が不正値です\n"); // Locked wall door: The type specification for argument 0 is invalid return cPhs_ERROR_e; @@ -345,7 +342,8 @@ cPhs__Step daObjKshtr_c::phase_0() { } } - if (dComIfG_resLoad(&mPhase1, l_arcName[mType]) == cPhs_COMPLEATE_e) { + phase = (cPhs__Step)dComIfG_resLoad(&mPhase1, l_arcName[mType]); + if (phase == cPhs_COMPLEATE_e) { phase = (cPhs__Step)MoveBGCreate(l_arcName[mType], l_dzb[mType], NULL, l_heap_size[mType], NULL); if (phase == cPhs_ERROR_e) { return phase; @@ -355,6 +353,7 @@ cPhs__Step daObjKshtr_c::phase_0() { OS_REPORT("KSHTR PARAM:0x%x\n", fopAcM_GetParam(this)); return cPhs_INIT_e; } + return phase; } cPhs__Step daObjKshtr_c::phase_1() { diff --git a/src/d/actor/d_a_obj_stopper.cpp b/src/d/actor/d_a_obj_stopper.cpp index 557f02c22a..bee5fc640d 100644 --- a/src/d/actor/d_a_obj_stopper.cpp +++ b/src/d/actor/d_a_obj_stopper.cpp @@ -70,18 +70,18 @@ int daObjStopper_c::create() { if (!field_0x9fc) { field_0x9f8 = home.angle.x; field_0x9fa = home.angle.z; - home.angle.z = 0; - home.angle.x = 0; - current.angle.z = 0; - current.angle.x = 0; - shape_angle.z = 0; - shape_angle.x = 0; + home.angle.x = home.angle.z = 0; + current.angle.x = current.angle.z = 0; + shape_angle.x = shape_angle.z = 0; field_0x9fc = 1; } - cPhs__Step phase = (cPhs__Step)MoveBGCreate(NULL, -1, dBgS_MoveBGProc_TypicalRotY, 0x810, NULL); - if (phase != cPhs_ERROR_e) { + cPhs__Step phase = cPhs_COMPLEATE_e; + phase = (cPhs__Step)MoveBGCreate(NULL, -1, dBgS_MoveBGProc_TypicalRotY, 0x810, NULL); + if (phase == cPhs_ERROR_e) { return phase; } + OS_REPORT("STOPPER PARAM<0x%x>\n", fopAcM_GetParam(this)); + return phase; } int daObjStopper_c::Execute(Mtx** param_0) { |
