| Age | Commit message (Collapse) | Author |
|---|
|
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
|
|
Yellow squiggly lines begone!
Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes.
If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed.
The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports.
Not everything is removed, but the cleanup should be substantial enough.
Because this done on Linux, code that isn't used on it is mostly untouched.
(Hopefully no open PR is depending on these imports...)
|
|
|
|
confused and mistakenly enable it.
|
|
ControllerEmu: Remove nunchuk stick data hax.
|
|
|
|
MappingWidget: Add Advanced Configuration Button to Point And Point Passthrough "Enable" boxes
|
|
(Passthrough)" "Enabled" checkboxes.
|
|
overriding destructors - Core & UnitTests
|
|
a bound input.
|
|
to eliminate redundant unused members in Wii Remote extension objects.
|
|
Dentomologist/wiitasinputwindow_update_on_attachment_change
WiiTASInputWindow: Update controls when attachment changes
|
|
Change the displayed controls in the TAS Input window when the
controller's extension (including MotionPlus) is changed.
This previously required restarting Dolphin after the attachment was
changed, as the controls were never updated after the WiiTASInputWindow
was created at Dolphin startup.
|
|
In WiimoteReal.cpp, JitRegCache.cpp, lambda predicates were replaced by pointers to member functions because ranges algorithms are able invoke those.
In ConvertDialog.cpp, the `std::mem_fn` helper was removed because ranges algorithms are able to handle pointers to member functions as predicates.
|
|
In DITSpecification.cpp, MaterialAsset.cpp, and ShaderAsset.cpp, lambda predicates were replaced by pointers to member functions because ranges algorithms are able invoke those.
In NetPlayClient.cpp, the non-trivial `NetPlay::Player` elements were being passed by value in `NetPlayClient::DoAllPlayersHaveGame()`. This has been fixed.
In WIABlob.cpp, the second example's predicate was returning the `std::optional` by value instead of implicitly converting it to a bool. This has been fixed.
|
|
|
|
minimum threshold in UI to 1% to prevent user error.
|
|
button is pressed.
|
|
the IR camera objects.
|
|
|
|
Gets this out of the global namespace and into the Common namespace
|
|
I also changed LoadConfig, but that change doesn't affect correctness,
it's only so it looks neat by matching SaveConfig.
This bug was added in 18a4afb053e8b5f356e22cfc5aec8cc27700710b, the
commit that introduced DefaultValue::Disabled. The bug can't actually be
triggered in master, but it can be triggered in the Android input
overhaul PR.
|
|
|
|
WiimoteEmu: Expose IMU pointing accelerometer weight setting.
|
|
Notches" and "Gate Size" categorized as such.
|
|
|
|
|
|
always applying 50%.
Make "Clear" button reset "Modifier" "Range" settings to 50%.
|
|
|
|
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
|
|
clean code
My future PRs will split the UI state from the Emulation State of some of these emulated
controller values and this readies the code for it.
|
|
casting a value to a u32 when it's originally an int, and it's exposed as int to users,
could end up in cases where a negative number would result as a positive one.
This doesn't really affect the value range of the attachment enum,
still I think the code was wrong.
Heavily tested.
|
|
Similar to the guitar, only control[0] was checked, and that felt random.
|
|
Input cleanup
|
|
NumericSettings support a max, so let's use it.
It might not do much now, but the max and min values will be used to give visual feeback
in the UI in one of my upcoming input PRs
|
|
|
|
The control expression editor allows line breaks, but the serialization was
losing anything after the first line break (/r /n).
Instead of opting to encode them and decode them on serialization
(which I tried but was not safe, as it would lose /n written in the string by users),
I opted to replace them with a space.
|
|
And remove useless include
|
|
fix some related grammar errors
only the ButtonManager required code changes
|
|
to only pitch or only yaw
|
|
|
|
|
|
|
|
|
|
of regular "Point" settings.
Removed "Total Yaw" from included Wii remote input profile to take on the default value.
|
|
FOV and to reach screen edges in the Wii Menu.
|
|
|
|
|
|
While having motion control emulation of IR enabled by default
makes sense in situations like using a DualShock 4 on a PC,
Android has the additional option of touch emulation of IR
which seems to be better liked, and the default value which
was chosen with PC in mind was carried over to Android
without any particular consideration. This change disables
motion control emulation of IR by default on Android only.
|
|
|
