summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2023-11-19Doc Actor: En_Brob (Jabu Jabu Wobble Flesh Block) (#1581)hiisuya
* brob function naming * modified brob header file * renamed skel, collision, and anims * named limbs and dls * renamed shock function * ran formatter * doc modifications * Update assets/xml/objects/object_brob.xml Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-11-19More Camera Flags (#1453)engineer124
* Generic Camera Flags * New flag names * Add flags to functions * Finish flag docs * More docs * More cleanup * More clarity * Better shrinkwindow flag docs * Improve name * CAM_INTERFACE_FLAGS * Better approach to edge cases * Change ordering for consistency * Oops * Add masks to macro * PR/Discord discussions * cleanup comment * Oops * PR Suggestions * More PR Feedback * More PR Suggestions * More Camera Flags * PR Suggestions * More flag style change * Small cleanup * More flag docs * Another flag * Fix flags * sync names with other PRs * more fixes * fix comments * update with hud visibility mode docs * missed one * fix comments * Roman PR Suggestions * interfaceField * small fix * letterbox cleanup * cleanup * fix macro arg * fix func declaration * many more docs * better docs? * missed some * oops, revert * add flags to name * cleanup * flag * double signal * simplify cam func name * more suggestions * PR Suggestion
2023-11-18bombowlman typo (#1582)krm01
2023-11-14doc for menkuri_eye (#1580)krm01
2023-11-12Fix misc 21 (#1573)Dragorn421
* Make `sNew` in (unused) `code_800FC620.c` a string It is passed as a filename to `__osMallocDebug` so should be a nul-terminated string, not a char[3] missing an explicit \0 * Fix gcc warning in `JpegDecoder_ParseNextSymbol` about SLL on negative value -1U is an unsigned value, aka 0xFFFFFFFF I keep -1 because it seems that's what a jpeg standard has too References: https://stackoverflow.com/questions/40508958/shifting-a-negative-signed-value-is-undefined https://www.w3.org/Graphics/JPEG/itu-t81.pdf (page 105, figure F.12) * Small cleanup * Fix few mistakes (thanks gcc warnings) * Add `@bug` in file select settings draw code, using the wrong array * format * format main * rename arg for a happy formatter * Move important function call out of a printf
2023-11-12Changed gLinkChildSlinghotStringDL to gLinkChildSlingshotStringDL (#1576)Javarooster
2023-11-07Rename "ITEM_LAST_USED" (#1572)fig02
* rename * format * remove formatter changes * change model group comments
2023-11-04rename to upper action (#1570)fig02
2023-10-30Remove `(ActorFunc)` casts in initvars (#1571)Dragorn421
* Remove `(ActorFunc)` casts in initvars, use `/**/` trick for format Achieved by using the following regex: (ActorInit.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(.*)(\n\s+)(?:\(ActorFunc\))?(.*)(\n\s+)(?:\(ActorFunc\))?(.*)(\n\s+)(?:\(ActorFunc\))?(.*)(\n\s+)(?:\(ActorFunc\))?(.*\n\};) replaced with $1$2/**/ $3$4/**/ $5$6/**/ $7$8/**/ $9$10/**/ $11$12/**/ $13$14/**/ $15$16/**/ $17$18/**/ $19 plus a change from /**/ to #if 0 #endif in docs/ * Manual fixes
2023-10-28Player Docs: public facing csAction things (#1561)fig02
* name public csAction functions * format * adjust function comment * format
2023-10-27libc cleanup (#1568)Tharo
* libc cleanup * Suggested changes, small alloca tweak * Remove printf include
2023-10-17Use `long` over `int` for s32/u32 types (#1546)Tharo
* long s32 * Suggested changes
2023-10-07Rename Math3D_CylOutsideCyl and Math3D_CylOutsideCylDist (#1557)cadmic
* Rename Math3D_CylOutsideCyl and Math3D_CylOutsideCylDist * radix -> radii Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> * Make Math3D sphere/cylinder collision check function names more consistent --------- Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
2023-10-07Player Docs: Propose Named Unions For Shared Variables (#1560)fig02
* make unions * format * adjust comment on halt thing
2023-10-05Player Docs: Initial AnimSfx stuff (#1556)fig02
* initial animsfx docs * review * extra space
2023-10-05Introduce Player CueIds (#1559)engineer124
* cueId * cleanup
2023-09-27initial action-change-list docs (#1540)fig02
2023-09-26Player Docs: csMode -> csAction (#1547)fig02
* csmode -> cs action * format
2023-09-25Speedmeter Small cleanup (#1554)Derek Hensley
* Small cleanup * x
2023-09-24Improve Matches: Part 4 (#1545)engineer124
* more improvements * small cleanup * PR Review
2023-09-22Name the main pause state and add placeholder enum for main (sub)states (#1551)Dragorn421
2023-09-22Make macros for age reqs data and access (#1549)Dragorn421
* Make macros for age reqs data and access * line breaks for readability
2023-09-20Improve Matches: Part 3 (#1544)engineer124
* improve matchings * spacing
2023-09-20improve matching (#1543)engineer124
2023-09-20improve matches (#1542)engineer124
2023-09-19Dekunut Salesman Docs (#1493)Billy
* Dekunut Salesman Docs * Update src/overlays/actors/ovl_En_Dns/z_en_dns.c Remove extra param from debug logging Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> * * Full Deku/Potion name usage * Dialog -> CanBuy * Revert debug logging symbols * Proper declaration spacing * Fix en_shopnuts header doc * Biz -> Business * Fix missed deku prefix's * Synchronize CanBuy sticks and nuts * Fix enum naming * Clarified CanBuy success values * anon review * fig review * macro changes * fix macro usage --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> Co-authored-by: fig02 <fig02srl@gmail.com>
2023-09-19Player docs: Control Stick Input and Movement (#1539)fig02
* document input stuff and movement speed+yaw * curve -> curved, and other cleanups * fix + format * function declaration * name arguments * add mode descriptions * fix typos * move comment down
2023-09-19Run formatter (#1541)Dragorn421
2023-09-19Doc/Cleanup pass on object handling (#1227)Dragorn421
* `Object_InitBank` -> `Object_InitContext` * Add and use `OBJECT_SPACE_SIZE_BASE` * Remove `OBJECT_EXCHANGE_BANK_MAX` -> use `ARRAY_COUNT()` instead * "object status" -> "object load entry" * Misc. cleanup/renames * Partial docs and way too much batch renaming and cleanup for a single commit * ctrl shift h * format * format clang-11.1 * fix regressions * Improve a `@bug` comment * Move `OBJECT_SPACE_SIZE_BASE` from header to near `Object_InitContext` * "objectID" -> "objectId" * Revert iterator index to `i` in `Actor_KillActorsWithUnloadedObject` * "object load entry index" -> "object entry" * `Object_UpdateLoadEntries` -> `Object_UpdateEntries` * Run format.sh * "object entry" -> "object slot" (except internal usage) * Proper `Object_SpawnPersistent` doc Co-authored-by: fig02 <fig02srl@gmail.com> * fixup one comment "object bank index" -> "object slot" * Amend `Object_SpawnPersistent` comment to mention running out of free slots * `Actor_KillActorsWithUnloadedObject` -> `Actor_KillAllWithMissingObject` * Remove useless mention of what uses `Object_SpawnPersistent` * Fix mistake on `Object_SpawnPersistent` doing sync dma, not async * run formatter * `Object_InitContext` -> `Object_Init` * `waitObjectSlot` -> `requiredObjectSlot` * `Object_Init` -> `func_80097DD8` * one objectIndex -> objectSlot * Remove `OBJECT_SPACE_SIZE_BASE` * light fix on the merge (rm OBJECT_EXCHANGE_BANK_MAX) * `func_80097DD8` -> `Object_InitContext` --------- Co-authored-by: fig02 <fig02srl@gmail.com>
2023-09-19Document niche magic spell bug (#1526)fig02
* document magic spell bug * Update src/overlays/actors/ovl_player_actor/z_player.c Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> * adjust comment * fix renamed func and reformat --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-09-18Start Player Item Docs (#1523)fig02
* item docs * format * loop change * some of engineers review * shorten comment (thanks formatter) * ProcessItemButtons * true/false
2023-09-17Name player's generic `actionVar`s (#1538)fig02
* name player generic vars * format
2023-09-16Document Framebuffer Filters, VisCvg and VisZbuf (#1534)Tharo
* Document z_viscvg and z_viszbuf Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> * Few more notes * Some more notes Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> * Review * Americanisation, FB RGB * Oops * Review * Minor documentation modifications * Header, base struct and enums Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com> * functions.h fix * Suggested changes, further adjustments to file doc comments * Further suggested changes, standardize capitalization of gfxP * g --------- Co-authored-by: Elliptic Ellipsis <elliptic.ellipsis@gmail.com> Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-09-14remove the extra ``CS_CMD_STOP`` (#1535)Yanis42
2023-09-13Player Docs: Name actionFunc (#1531)fig02
* progress, going to merge master * merge master * finish renmaing functions * reorder declarations
2023-09-13Document Camera Special9 (door) angle bug (#1525)fig02
* document special9 angle bug * Update src/code/z_camera.c Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-09-09Apply noreturn attribute where applicable (#1532)Tharo
2023-09-06Document Player's bgcheck routine (`func_80847BA0`) (#1503)fig02
* progress * progress * progress * done for now * floor pitch comments * sYDistToFloor * add function comment * sFloorShapePitch * typo in header
2023-09-06Player doc: anim wrappers (#1437)Dragorn421
* Player doc: anim wrappers * revert name callbacks in `D_80854AA4` * Adj -> Adjusted * format * Add `PLAYER_ANIM_ADJUSTED_SPEED` * format * Add a comment on `Player_AnimReplaceApplyFlags` --------- Co-authored-by: fig02 <fig02srl@gmail.com>
2023-09-06Document pause states (excluding gameover) (#1483)Dragorn421
* Document PauseContext.state * Very light docs surrounding pause states * PAUSE_STATE_UNPAUSE -> PAUSE_STATE_RESUME_GAMEPLAY and comment on purpose in the enum * PAUSE_STATE_MAIN -> PAUSE_STATE_6 * format * Player_InitDrawPause -> Player_InitPauseDrawData
2023-09-06z_fishing partially documented (#1424)blackgamma7
* Document z_Fishing Document code and data RE: Fishing minigame. * More z_fishing.c progress Id's more values, added flag for "High score" entries * moved and renamed Fishing flags Flags moved outside z_fishing.c - ending sequence checks for "hat stolen" flag. * more fishing.c Id'ing added more id's and clarification. * Update z_fishing.h clarified not about fish weight. * more z_fishing.c documenting missed a bitfeiled in the fishing "highScores" that kept track of your number of fishing trips * Update z64save.h a #define got lost for the "fishing games played" increment * z_fishing: a few formatting and naming changes based on feedback - removed comments summing textboxes as it was deemed redundant - tried to unify fish measurment as "length" - clarified a few vars based on name - formatted single-line comments to have one space. * Update z_fishing.c ran format.py and fixle.sh * Update z_fishing.c changed code around a few bools that was still matching. * `z_en_Fishing`: changes from feedback, id'd rotate phase fields. * Update z_fishing.c merge fix * `z_fishing`: More doc'ing. * `z_fishing`: changes based on feedback * `z_fishing`: fixed typo * `z_fishing`: merge with master * Update z_fishing.c sSinkingLureLocationPos was too redundant * Merge fix, added more comments, #defines, id's * Update z_fishing.c adding EN_FISH_PARAM may have led to mismatch. * `z_fishing`: fixed compare mismatch * Update z64save.h fix typo * Update z_fishing.c a few more id's
2023-08-29Fix and tidy up missing_gcc_functions.c (#1529)Tharo
2023-08-23`z_en_syateki_niw` doc (#1449)blackgamma7
* SyatekiNiw doc started id'ing funcs and fields for SyatekiNiw * `z_en_syateki_niw` doc * `z_en_syateki_niw1: (almost) all fields/funcs doc'd * `z_en_syateki_niw` update changes based on feedback. * `z_en_syateki_niw`: limb fields renamed * Update z_en_syateki_niw.h renamed fields as suggested. * Update src/overlays/actors/ovl_En_Syateki_Niw/z_en_syateki_niw.h fix typo in comment. Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> * Update z_en_bom_bowl_man.c add minigame enum to actor spawn param * `z_en_syateki_niw`: updated based on feedback renamed local vars for claritey, added more comments to struct. * Update z_en_syateki_niw.c renamed function and var based on feedback --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2023-08-19En_Cow Doc (#1492)Billy
* Add Documentation for Cows * Better naming for cow unlock flag * Update with MM solutions and PR suggestions * Readable conditions * Decimal cycle counter * Replace params with cow type * Clean up type usage and function names * Clean up cylinders * Fix collider enum * Rename EnCow rear collider * Fix spacing * PR fixes: COLL -> COLLIDER enum static prefix Missed MM function naming Specific actor flags naming * Rename of healRot and breathTimer * Document Epona's song reset behavior * anon review * fig review * whitespace * rework milk interaction stuff * changes to milk comment --------- Co-authored-by: fig02 <fig02srl@gmail.com>
2023-08-15Doc/cleanup pass on effects 1 (#1421)Dragorn421
* Some doc/cleanup on `Effect_Ss_Fhg_Flash` * Some doc/cleanup on `Effect_Ss_Blast` * 11DA0 -> Billboard * doc three lerp funcs in effectss * Some doc/cleanup on `Effect_Ss_Bomb` * `rTexIdx` -> `rTexIndex` * lifespan * `LIFESPAN` -> `EFFSSBOMB_LIFESPAN` * --parentheses * Add todo about "having zapd forward declare static variables" * try rework comments on effects scale * lightning -> "a ball of electrical arcs" ?
2023-08-15Placeholder names for skelanime moveflags (#1489)Dragorn421
* Add defines for all used animflags * Use named constants (and add two) for players `func_80832F54` flags * note which flags are player-only * Attempt at documenting but too FeelsUnkMan again * forgot something * ANIM_FLAG_PLAYER_0 -> ANIM_FLAG_0 and amend comment from "player-only" to "no effect outside player" * 1<<n flags
2023-08-15Cleanup/add bgcheck macros (#1478)Dragorn421
* Cleanup/add bgcheck macros * vIA -> vI * parentheses around bit& * achivement get: formatter contrarian * COLPOLY_VTX_FLAGS -> COLPOLY_VTX_FLAGS_MASKED * & before << in WATERBOX_PROPERTIES packing macro * & before << in SURFACETYPE* packing macro and fix parentheses
2023-08-15Split z64.h: move various things, state, sram, gfx, jpeg, prerender, ↵Dragorn421
speedmeter (#1487) * Split z64.h more * fix speedmeter.h (expect this kind of issue resolution to pop up eventually) * fix z64object.h * fix z64state.h * fix (probably only partially) z64play.h * fix fix speedmeter.h :) * revert making a play header (sadge), add/split transition & transition_instances * move stuff to cutscene, interface * Move `TransitionCircle%` enums to `z64transition_instances.h` * z64state.h -> z64game.h with a "this is not final" comment * forward declare GraphicsContext in z64game.h instead of including the header file for it * don't comment on where the forward declarations are from reasoning: 1) it's easy to go out of sync (like this comment, it was outdated anyway) 2) any IDE can easily find the struct anyway
2023-08-15Document z_lib Sfx Functions (#1470)engineer124
* document lib sfx * rename functions
2023-08-15Mention why PrimDepth is used in `PreRender_FetchFbufCoverage` (#1520)Tharo
* Mention why PrimDepth is used in PreRender_FetchFbufCoverage * Clarify that this only affects the memory alpha blender input, not all alpha blender inputs * Try to make the subtle difference between coverage and memory alpha more clear