| Age | Commit message (Collapse) | Author |
|
* Rename AT `effect` to `hitSpecialEffect`
* bss
|
|
* introduce `enum CutsceneIndex` as a first step
* crudely rename `enum CutsceneIndex` entries
* run `check_format.py ...` separetely
so that it doesn't clutter previous commit. still, allowing `clangd LSP` to run format-on-save yields inconsistent results for me with the project's tooling, especially for header files
* apply a draft PR suggestion
Co-authored-by: mzxrules <mzxrules@gmail.com>
* rename `CS_INDEX_*` with PR suggestions
and some additional observations
reverified with
> `check_format.py ...`
> `make ...`
additionally:
- current clang-format lacks a rule for trailing commas
- compiler says about them `cfe: Warning 624`
* improve `CS_INDEX_*` naming, rem `ENTRANCE` suffix
https://github.com/zeldaret/oot/pull/2286#discussion_r1829165205
reverified with
> `check_format.py ...`
> `make ...`
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/4/console
hmm, i do need this automation locally to
* apply a PR suggestion
https://github.com/zeldaret/oot/pull/2286#discussion_r1829219841
* remove redundant comments, fix the header comment
and add a comment chunk from https://github.com/zeldaret/oot/pull/2286#discussion_r1829108940
* rename the flag for freeing `nextCutsceneIndex`
* rename the flag for automatic `sceneLayer` calc
it gets assigned to the `nextCutsceneIndex`,
so `CS_INDEX_NONE` name was misleading
* use explicit scene layer names instead of numbers
* ok, now the last two `CS_INDEX_*` are less unknown
the purpose of `CS_INDEX_BARRIER` is not quite clear still
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/14/console
* run `fix_bss` locally
`ntsc-1.2` refused to comply though
* revert all local to the branch bss shifts
* ugh, use defines instead of an enum
probably size of enum entries doesn't match well? originally these were
just numbers. besides, not like it's a real enumeration from zero to a
value or some bit flags
* still, add a BSS pragma for `z_demo.c`
* apply review changes
* factor out a cutscene layer formula
* give scene layers names throughout code
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/32/console
* tweak `CS_INDEX` descriptions
* apply PR review suggestions
* rename "auto" -> "default"
* apply PR review suggestions
https://github.com/zeldaret/oot/pull/2286#discussion_r1868693980
essentially reverts 106cb1021be88f745ee303838c11c7d7cbf9c79d, except for 2 generic `z_scene.c` lines
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/77/console
* Apply suggestions from code review
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: mzxrules <mzxrules@gmail.com>
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/175/console
* Move CS_INDEX_* macros to z64save.h, with the definition of gSaveContext.save.cutsceneIndex
* `#define CS_INDEX_D 0xFFFD` and co.
Co-authored-by: cadmic <cadmic24@gmail.com>
* add comment on CS_INDEX_D
* review
* CS_INDEX_NONE is back
* bss
* expand comment about 0xFFFD
* fix comment about 0xFFFF usage
* review
---------
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: cadmic <cadmic24@gmail.com>
|
|
`SFX_PLAY_AT_POS` (#2633)
* Add `SFX_PLAY_CENTERED`
* Add `SFX_PLAY_AT_POS`
|
|
* z64 - a
* z64 - b
* z64 - c
* z64 - d
* z64 - e
* z64 - f
* z64 - g
* z64 - h
* z64 - i
* z64 - l
* z64 - m
* z64 - o
* z64 - p
* z64 - q
* z64 - r
* z64 - s
* z64 - t
* z64 - v
* restore file
* fix merge
* fix merge
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* Document kaleido debug menu
* Fix BSS
* bss
* Address reviews
* bss
* add #pragma increment_block_number to z_parameter and let CI do its thing
* bss
* buffer -> digitBuf
* reformat comments on sSectionPositions. trick clang-format into not ruining the array by adding // comments on their own line
* rename to KaleidoScope_DrawInventoryEditor
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* cp extracted/PAL_VERSION/... assets/...
* make NTSC compatible
* include cleanup
* progress
* progress2
* format
* comments
|
|
|
|
|
|
* split out various macros
* fix
* fix2
* fix dw
* libc path
* fix macro
* does this fix bss
* fix bss
|
|
|
|
* create printf and translation headers
* non-overlays complete
* printf finished
* move T macro
* edit comment
* fix error
* fix bss
* remove is_64
* fix bss
|
|
* split most of functions.h
* osdriverominit
* forgot include
* fix
* remove functions.h
* temporary fix for fix_bss
* fix bss
* revert fix_bss.py change
|
|
* move variables into z64environment.h
* z_room.h
* z64sram.h, z64ss_sram.h, z64font.h, kanread.h
* z64lifemeter.h, z64debug.h, debug_arena.h
* buffers.h
* remove z_bgcheck global
* gamealloc.h
* suggestions
* .bdd
|
|
* z64env_flags, z64quest_hint_commands
* z64cutscene_spline, z64save.h moved from z64.h
* bss
* pr suggestion
* bss
* suggestions
|
|
|
|
* [iQue] Match z_actor
* Reword comment
|
|
z_opening (#2424)
* [iQue] Match z_end_title
* [iQue] Match z_construct
* [iQue] Match z_common_data
* [iQue] Match z_parameter
* [iQue] Match z_title, z_opening
* Actually match z_parameter
* Give up on stack issues
* this->exit = true
|
|
|
|
* Simplify most event flags
* EVENTINF_HORSES_INDEX -> EVENTINF_INDEX_HORSES
* Add missing index numbers
* pr suggestions
* Clean up INGO_RACE flags
|
|
* document z_horse.h
* .bss
* suggestions and more comments
* bss
* INGORACE -> INGO_RACE
* format header macros
* FIx incorrect type comparision
* EnInMode -> EnInStartMode
* R_EXITED_SCENE_RIDING_HORSE
|
|
* Rename item get flags for Forest Stage upgrades
* Fix Jenkins build error
* Document shared flag bug
* Rename shared flag
* Massive documenting comments
* GDI - remove one trailing whitespace
|
|
* Fix some more GCC warnings, mark some bugs based on GCC warnings
* Weird formatting
* Suggested changes
* More weird indentation I guess
* UNREACHABLE() macro, add missing NORETURNs to fault_n64.c
* AVOID_UB for PAL path in z_file_nameset.c
* Remove comments about return types
* Remove temp no longer needed
|
|
* rename OOT_DEBUG to DEBUG_FEATURES
* makefile changes
* add DEBUG_ASSETS
* fix DEBUG_FEATURES usages
* format
* fix errors
* review
* fix problem and review2
* review
* add DEBUG_FEATURES to DEBUG_ASSETS check
* review
* whoops
* format
|
|
* Rename RoomBehaviorType1 to RoomType
* suggestions
* Update include/z64scene.h
---------
Co-authored-by: fig02 <fig02srl@gmail.com>
|
|
* use missed reg macros
* do action indexing cleanup
* misc
* doc fixup ish in KaleidoScope_SetPageVertices
* newline_police
* `43` -> `(PAGE_BG_QUADS + WORLD_MAP_QUAD_28)`
|
|
* [ntsc-1.0/1.1] Match "game engine" files
* Use R_START_BTN_X/R_START_BTN_Y
* Comment obvious bugs
* Move Magic_Fill comments
* Move EVENTINF_HORSES_INDEX printf inside #if
* Replace "this function"
|
|
* Move definitions of OOT_NTSC/OOT_PAL/OOT_MQ to versions.h
* Add PAL_N64 shorthand
|
|
* Pause doc: Prompt page and save prompt state
* bss
* `QUAD_PROMPT_` -> `PROMPT_QUAD_`
* `QUAD_MAP_WORLD_`, `QUAD_MAP_` -> `WORLD_MAP_QUAD_`
* `PAUSE_QUAD_CURSOR_` -> `PAUSE_CURSOR_QUAD_`
* `PAUSE_SAVE_PROMPT_STATE_RETURN_TO_MENU_ALT` -> `_2`
* bss
* bss
* add comments to help clarify save prompt vs prompt
|
|
`MATRIX_FINALIZE_AND_LOAD` (#1983)
* clean up gSPMatrix usage
* add weird hybrid macro gSPMATRIX_SET_NEW
* Matrix_NewMtx, MATRIX_NEW -> Matrix_Finalize, MATRIX_FINALIZE
* gSPMATRIX_SET_NEW -> MATRIX_FINALIZE_AND_LOAD
* format
|
|
* Pause doc: Cursor drawing
* bss
|
|
* TargetContext -> Attention
* targetCtx -> attention
* Target_ -> Attention_
* FindTargetableActor -> FindActor
* targetableActorP -> attentionActorP
* data vars (and 1 function I missed)
* targetMode -> attentionRangeType
* attention range enum comments
* ATTENTION_RANGE_
* attention range data
* TargetColor -> AttentionColor
* missed one
* fixup color variables
* targetArrowOffset -> lockOnArrowOffset
* focus pos comment
* targetPriority -> attentionPriority
* assets
* loose-ends
* Attention System Description
* format
* skj range type
* enemy bgm
|
|
* document Target_Draw
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
* fix missed renames
* retail fix
* another fix
---------
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com>
|
|
* Match z_fbdemo_wipe1.c
* Fix gDPSetTileCustom
* Match z_eff_ss_dead.c
* Match src/code/audio_thread_manager.c
* Match z_parameter.c
* Match KaleidoScope_DrawWorldMap
* Format
* 1 -> AUDIOMGR_DEBUG_LEVEL_NO_RSP
* Actually match KaleidoScope_DrawWorldMap
* Add comment on duplicate code
* Revert "Fix gDPSetTileCustom"
This reverts commit de09338d92e50dd3b9cb8ee7214e2e6b3fecf7ff.
|
|
* T() in z_camera.c
* T() in z_parameter.c
* T() in z_room.c
* T() in z_kaleido_scope_call.c
* T() in z_map_exp.c
|
|
* Add names to all typedef'd structs, unions, and enums
* wtf vs code
* Use a better regex
|
|
* Match NTSC z_parameter.c and z_construct.c
* Comment which REG collide
* Use new REGs everywhere
* Use new REGs everywhere for real
|
|
* Build gc-us
* Set up gc-us disassembly
* Don't disasm unchanged overlays
* Fix gc-eu-mq BSS
* romalign link_animetion for NTSC
* Explicitly set CPP defines to 0/1
* Add #ifs to segment_symbols.h
* Add sButtonTextures now
* Fix message _SHIFTL usage
* Don't ifdef LANGUAGE_MAX
|
|
|
|
* Define OOT_DEBUG=0 in retail builds
* Fix ifndef
* Replace VI_MODE_EDITOR_INACTIVE
* Revert "Replace VI_MODE_EDITOR_INACTIVE"
This reverts commit f7c4cae7c3b3d9fdc56e97183690c05f2dcec215.
* Replace VI_MODE_EDITOR_INACTIVE, take 2
* Revert EnBom_Draw
|
|
* z_parameter okay
* no u32
|
|
* Replace most osSyncPrintf calls with PRINTF macro
* DEBUG -> OOT_DEBUG
|
|
* Create debug macros for common functions
* Revert NDEBUG change
* MALLOCR -> MALLOC_R
* DEBUG -> OOT_DEBUG
* Use the same name for debug and non-debug matrix functions
* Fix file/line argument order
* Revert g[s]DPNoOp[Tag]
* Use SystemArena_MallocDebug directly in GameAlloc_MallocDebug
* MTXF_TO_MTX -> MATRIX_TO_MTX
|
|
* name public csAction functions
* format
* adjust function comment
* format
|
|
* csmode -> cs action
* format
|
|
|
|
* Document PauseContext.state
* Very light docs surrounding pause states
* PAUSE_STATE_UNPAUSE -> PAUSE_STATE_RESUME_GAMEPLAY and comment on purpose in the enum
* PAUSE_STATE_MAIN -> PAUSE_STATE_6
* format
* Player_InitDrawPause -> Player_InitPauseDrawData
|
|
* Split SaveContext struct
* run formatter
* Remove temporary-until-split stuff in z_sram
* .
* run formatter
|
|
* "bgs sword" -> "biggoron sword"
* Animation_ChangeImpl: last arg is `ANIMTAPER_` enum
* TransitionTileStatus -> state
* Tiny gbi.h formatting fixups
* some cleanup on floormaster
* misc float ops cleanup
* sunsSongState = SUNSSONG_INACTIVE
* continueFlag == CS_CMD_STOP
* fix few camera names inconsistency
* textual 0 padding? not on my lawn
* libultra: construct address from end of dmem rather than oob from imem
* more free1 -> 2 fixup
|
|
* TransitionTile'
* Final clean up
* PR
* Header comment
* vtx_tn
* Name background DL
* row <-> col
* Rename update functions
* Update header
* Enum
* Done -> Ready + cleanups
* Update include/z64transition.h
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* commit old stuff
* progress
* progress
* progress
* progress
* more progress, renaming cues next
* small changes
* enum values added for all actions
* hardcoded values removed when possible
* commands renamed
* first pass of action -> cue
* fix some matches
* some more cleanup
* scriptPtr
* forgot one
* remove cue rot union
* more changes
* some more stuff
* more stuff
* fix matching issues
* some more things
* progress, starting to rename destinations
* small changes
* name some destinations
* more names
* need to switch branch
* progress
* first pass of destination names
* usages fixed
* use destination enum
* fix csdis
* format
* command descriptions
* revert accidental zap changes
* forgot some things
* use a single macro for CutsceneCameraPoint (idk why i didnt think of this sooner)
* typo
* review1
* clarify ruby/sapphire comment
* remove endframe for commands that dont use it
* some more review
* most review, but not all
* scriptPtr -> script, and another small change
* ocarina action
* remove +1 from light settings command, change comment
* actionIndex -> cueIdTemp (i guess)
* _SetCueX -> _SetXFromCue
* format
* tweak fade out seq arg names
* use spline terminology
* more dragorn and engineer review
* misc start/end frame note
* cleanup StartPosRotFromCue vs PosRotFromCue
* cleanup spline terminology
* sPrevCamId -> sReturnToCamId
* comment on debug cs data address
* Cutscene_Init -> Cutscene_InitContext
* single point types are not a list
* remove todo comment
* some more review
* rumble struct names
* some review
* more review
* missed one
* reword pointer comment
* even more review
* match transition terminology with z_play
* change condition and format
* frame count
* command specific structs with alignment
* anon review
* remove unneeded arg from time macro
* yeet `CsCmdGeneric`
* remove unused from single point types
* typo
* compromise attempt -- name endFrame everywhere
* fixes
* fix again
* copied the wrong note
* cutscene data note
* review, format
* compat defines
* idk whats going on man
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|