| Age | Commit message (Collapse) | Author |
|
* Apply includes style to `src/code/z_[r-z].c`
* fixup
|
|
* z_scene Some comments and function names
* review changes
* further fixing from comments
* vromAddr
---------
Co-authored-by: djevangelia <djevangelia>
|
|
* Document an includes style, apply to z_demo.c and z_play.c
* "reverse" style includes
* bss
* clarify what a "main header" is
* Update docs/includes.md
Co-authored-by: Tharo <tharo10600@gmail.com>
* Update docs/includes.md
---------
Co-authored-by: Tharo <tharo10600@gmail.com>
|
|
* Document pass on WaterBox code
* implement suggestions, missing comment
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* [cc0 oot] z_vis*
* bss
* docs
* fixup
* further vis docs
* add FbFilterType enum
* bss
* gfxP
|
|
* gActorSetupXluDL
* gActorSetupOpaDL
* ACTOR_SETUP_OPA_DL
* BSS
* Some more usages of ACTOR_SETUP_OPA_DL
* docs
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* Rename EVENTCHKINF 40, 45, 80, C7
* Rename EVENTCHKINF 40, 45, 80, C7 w format
* updated save.h comment for accuracy
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Applied 'Zelda' to 'Zeldas' & 'Pulled' to 'Obtained' adjustments
* EVENTCHKINF_INDEX_OBTAINED_ZELDA_LETTER -> EVENTCHKINF_INDEX_OBTAINED_ZELDAS_LETTER
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* `@bug UB` in Item_Give and Item_CheckObtainability
* `@bug` on `envCtx->windSpeed` not initialized in Environment_Init
|
|
* Document z_eff_ss_stone1.[ch]
* Incorporate feedback from PR review.
From https://github.com/zeldaret/oot/pull/2670:
- Shortened excessively verbose
suppressRTransFadeFlashAlphaStepAfterTwoFrames name to
suppressFadeFlash
- Fixed up comment that went waaaaaay beyond the column limit in
z_eff_ss_stone1.h
- Shortened comparison with 0 of variable bool semantics in
z_eff_ss_stone1.c
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Fix misnaming from PR review and document some more
From https://github.com/zeldaret/oot/pull/2670:
- shortenFadeFlash is incorrect - renamed to freezeFadeFlash
- Used `false` instead of 0 in EnArrow_Fly
- Elaborated comments about what exactly freezeFadeFlash does
Also added a few extra comments to z_eff_ss_stone1.c
* Ran clang-format
* More feedback from PR review, clarified comment
From https://github.com/zeldaret/oot/pull/2670:
- Change 0 to false in header comment
- Remove verbose speculation about former use of unused variable
- Made comment on use of viewDepth clearer
- Separated matrix and gfx code with a newline
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Marked the "1500" as being in units
---------
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
|
|
* Document `EnIn` (AKA the hard-working Ingo)
* Fix variable references
* Revert switch
* Rename race outcome functions for clarity
* Apply suggestions
|
|
* [cc0 oot] "kanread"
* format
* document kanji_tex
* fixup
|
|
* [cc0 oot] z_memory_utils
* format
* doc
* MemCopy: The memory regions must not overlap.
|
|
* Document `EnSa`
* Rename INFTABLE entries
* Animation set -> group
* Remove trailing commas
* Rename textState field
* Remove trailing comma
* Rename EVENTCHKINF flag
* Correct frowning/closed swap of enum
* Rename INFTABLE flag
|
|
* Document CIC6105
* Changes, AUDIOMGR_DEBUG_LEVEL -> AUDIOMGR_ACTIVITY_LEVEL
|
|
|
|
* `Item_DropCollectibleRandom`: params macro and drop tables enum
* fixup
|
|
* Simplify or comment on the remaining complex render mode settings
* Suggested changes
* Format
|
|
* Macro-ify access to pauseCtx->playerSegment regions.
Using macros to indicate which region in the player segment is being
accessed makes the memory layout more obvious and indicates the
intended level of memory ownership, particularly in the case of the
texture image at the start of the segment.
* Add clarifications for gameplay_keep details
* Uniform macro name for the render texture
* Comment
|
|
* oot-gc-eu-dbg-proto OK
* add gc-eu-dbg-proto to readme
* mention overdump trimming for all debug roms
* rename gc-eu-dbg-proto to gc-eu-dbg-2
Rationale: first version to make it into decomp (which should also be the first one that surfaces) gets an un-numbered version name, then the second version gets -2, and so on
|
|
S2DEX2 after drawing a room background (#2725)
|
|
|
|
* gc-eu-dbg OK
* cleanup/fortify makefile and line_numbers.h changes
* fill segments.csv
* add gc-eu-dbg to Jenkinsfile
* cleanup/fortify dmadata_table.h
* add gc-eu-dbg to readme
* fix checksum check and compressed checksum
|
|
(#2706)
* Make bool return values of SkelAnime_Update and LinkAnimation_Update clear
* formatting: empty line after decl
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* Fix F3DEX2 ucode name on N64 versions (not PosLight)
* put the not-PosLight / PosLight differences under F3DEX_GBI_PL
* revert bss changes
|
|
* remove noop macros Fault_SetFontColor Fault_SetCharPad under PLATFORM_N64
* remove duplicate declarations in sfx.h
* use render mode presets more
* decimal for alpha values
* fix some z_camera comments typos
* fix references to preprocess.sh (used to be preprocess.py)
* remove outdated comment on deps in makefile
* code_800AD920 was renamed to z_viszbuf
* fix capitalization typo: gOcarinaofTimeDesignTex -> gOcarinaOfTimeDesignTex
* fix typo: gLinkAdultEyesClosedfTex, gLinkChildEyesClosedfTex -> remove extra f
* fix typo: gCrstalSwitchRedTex, gCrstalSwitchBlueTex -> gCrystal
* fix PARAMS_GET_U amount of bits
|
|
|
|
* Document SysCfb_GetFbPtr bug
* cleaner comment
* fixes
* change wording again
|
|
* Commit and split gameplay_keep
* Remove debugging bits
* format
* bss
* merge gameplay_keep_0x400 into link_textures
* Name some unused NTSC stuff
* Rename files for some of the newly named unused NTSC stuff
* name more gkeep files
* format
* spin_attack
* name fish anims files
* name some eff_ files
* name a bunch more files
* Add underscore in not-final names
* cleanup limb enum names (remove g prefix)
* split gameplay_keep_0x34020.c into gBugCrawlAnim.c + bug_skel.c
* door.h -> door_skel.h
* gArrowNAnim -> gArrowN_Anim
* split arrow_anims into gArrow1_Anim + gArrow2_Anim
* fix merge
* bss
* bss
* Fix bss
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
|
|
* Commit code assets
* Have different ifdefs
* Move to code files
* Missed an include
* Prevent code assets from having their source unnecessarily written
|
|
|
|
|
|
names (#2646)
* Cleanup extracted colliders 3: Use `HIT_SPECIAL_EFFECT_`, `HIT_BACKLASH_` names
* revert removing FLARE_DANCER_BODY_DMG (oops)
|
|
|
|
* `Camera_KeepOn4` docs 2: RO and RW data
* fix unk_14 rename
* CAM_DATA_UNK_22 -> CAM_DATA_INIT_TIMER
|
|
* Name HIT_BACKLASH_ and HIT_SPECIAL_EFFECT_ values
* SHOCK -> ELECTRIC
|
|
* Rename AT `effect` to `hitSpecialEffect`
* bss
|
|
* introduce `enum CutsceneIndex` as a first step
* crudely rename `enum CutsceneIndex` entries
* run `check_format.py ...` separetely
so that it doesn't clutter previous commit. still, allowing `clangd LSP` to run format-on-save yields inconsistent results for me with the project's tooling, especially for header files
* apply a draft PR suggestion
Co-authored-by: mzxrules <mzxrules@gmail.com>
* rename `CS_INDEX_*` with PR suggestions
and some additional observations
reverified with
> `check_format.py ...`
> `make ...`
additionally:
- current clang-format lacks a rule for trailing commas
- compiler says about them `cfe: Warning 624`
* improve `CS_INDEX_*` naming, rem `ENTRANCE` suffix
https://github.com/zeldaret/oot/pull/2286#discussion_r1829165205
reverified with
> `check_format.py ...`
> `make ...`
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/4/console
hmm, i do need this automation locally to
* apply a PR suggestion
https://github.com/zeldaret/oot/pull/2286#discussion_r1829219841
* remove redundant comments, fix the header comment
and add a comment chunk from https://github.com/zeldaret/oot/pull/2286#discussion_r1829108940
* rename the flag for freeing `nextCutsceneIndex`
* rename the flag for automatic `sceneLayer` calc
it gets assigned to the `nextCutsceneIndex`,
so `CS_INDEX_NONE` name was misleading
* use explicit scene layer names instead of numbers
* ok, now the last two `CS_INDEX_*` are less unknown
the purpose of `CS_INDEX_BARRIER` is not quite clear still
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/14/console
* run `fix_bss` locally
`ntsc-1.2` refused to comply though
* revert all local to the branch bss shifts
* ugh, use defines instead of an enum
probably size of enum entries doesn't match well? originally these were
just numbers. besides, not like it's a real enumeration from zero to a
value or some bit flags
* still, add a BSS pragma for `z_demo.c`
* apply review changes
* factor out a cutscene layer formula
* give scene layers names throughout code
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/32/console
* tweak `CS_INDEX` descriptions
* apply PR review suggestions
* rename "auto" -> "default"
* apply PR review suggestions
https://github.com/zeldaret/oot/pull/2286#discussion_r1868693980
essentially reverts 106cb1021be88f745ee303838c11c7d7cbf9c79d, except for 2 generic `z_scene.c` lines
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/77/console
* Apply suggestions from code review
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: mzxrules <mzxrules@gmail.com>
* apply Jenkins fixes
https://jenkins.deco.mp/job/OOT/job/PR-2286/175/console
* Move CS_INDEX_* macros to z64save.h, with the definition of gSaveContext.save.cutsceneIndex
* `#define CS_INDEX_D 0xFFFD` and co.
Co-authored-by: cadmic <cadmic24@gmail.com>
* add comment on CS_INDEX_D
* review
* CS_INDEX_NONE is back
* bss
* expand comment about 0xFFFD
* fix comment about 0xFFFF usage
* review
---------
Co-authored-by: mzxrules <mzxrules@gmail.com>
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Co-authored-by: cadmic <cadmic24@gmail.com>
|
|
|
|
* CollisionCheckInfo.atHitEffect -> atHitBacklash
* ColliderElementDamageInfoAC.effect -> hitBacklash
* add HIT_BACKLASH_ enum
* bss
* bss
* bss
* bss
* bss
* Update comments
|
|
* doc `KaleidoScope_SetCursorPos`
* doc bug in `KaleidoScope_DrawWorldMap`
* fix anonymous enum
* `D_808321A8` -> `sSavedButtonStatus`
* s16 decimal for `sVtxPageMapDungeonQuads``X/Y/Width/Height`
* Use `LANGUAGE_` enum for indexing language-indexed regs
|
|
`SFX_PLAY_AT_POS` (#2633)
* Add `SFX_PLAY_CENTERED`
* Add `SFX_PLAY_AT_POS`
|
|
* `Camera_KeepOn4` docs 1
* add comment
* backticks around at, eye
|
|
`Player_SetTurnAroundCamera`, `Player_RequestCameraSetting` (#2608)
* Introduce `CAM_SET_CAMERA_DATA_`, `CAM_ITEM_TYPE_` and name `Player_CameraChangeSettingTurnAround`
* bss and formatting
* func_80835E44 -> Player_RequestCameraSetting
* -> Player_SetTurnAroundCamera
* -> CAM_DATA_SET_
|
|
* WeaponInfo docs
* format
* disasm metadata
* merge fixup
* Add MELEE_WEAPON_INFO_TIP and _BASE
* format
* Offset
|
|
* Document fog functions Gfx_SetFog(2) and Play_SetFog
* review
* Apply suggestions from code review
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|
|
* Commit `do_action_static`
* fix
* rm do_action_static from write_source.txt
|
|
* Update docs/Documenting.md
* fix
|
|
* Add Vtx[] resources in xmls for (partially) documented assets 7
* bss
|
|
* z64 - a
* z64 - b
* z64 - c
* z64 - d
* z64 - e
* z64 - f
* z64 - g
* z64 - h
* z64 - i
* z64 - l
* z64 - m
* z64 - o
* z64 - p
* z64 - q
* z64 - r
* z64 - s
* z64 - t
* z64 - v
* restore file
* fix merge
* fix merge
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
|