summaryrefslogtreecommitdiff
path: root/src/code
AgeCommit message (Collapse)Author
2022-05-31Doc pass on scene draw configs: names (#1233)Dragorn421
* Name most scene draw configs * 0 -> None, 36 -> GanonCastleExterior * 48 -> GraveExitLightShining * 47 -> CalmWater * (0) none -> default * `SCENE_DRAW_CONFIG_` -> `SDC_`
2022-05-29Audio Docs: Adsr Decay Rate (#1238)engineer124
* Init adsr decay docs * cleanup * cleanup * Revert some docs * Cleaner docs * count hex to dec * scaled updates per frame * Consistency * Oops, fix meaning * Avoid `decayRate` conflict with reverb `decayRate` * PR suggestion
2022-05-29Documentation pass centered on z_player_lib (#1230)Dragorn421
2022-05-23Document Magic (#1199)engineer124
* Magic docs WIP * More docs, first round finished * Better docs * More renaming * Simpler name * Another small adjustment * rm if(1) * Better names again after in-game testing * Change comments * change comment * Big rename based on all the suggestions * Small touch-up * More PR Suggestions * RESTORE_IDLE -> RESET * More docs * Capitalization * PR suggestions * Make declaration consistent * Health_ChangeBy (amount) * PR Suggestions * Missed one * More PR Suggestions * Change comment * Add another clarity comment * Discord discussions on `magicFillTarget` * Comments * grammar * More comment clarity * Another bad comment * PR suggestions, improved comments * One more comment * one more thing * bar -> meter
2022-05-21PlayState Rename (#1231)fig02
* global context -> play * fix PlayState* PlayState
2022-05-21Documentation pass on scene/room commands (#1226)Dragorn421
* Rename handler functions * Rename cmd_id enum names for consistency * `char` -> `s8` for explicit padding in cmd structs * `Room.unk03/03` -> `behaviorType2/1` * `UNK_PTR` -> `void*` * `showInvisActors` -> `lensActorsMode` + enum * Add `ROOM_BEHAVIOR_TYPE1/2_` enums * "mesh" -> "mesh header" * `Polygon polygon` -> `PolygonBase base` (for now...) * Misc cleanup * "lens actors mode" -> "lens actor mode" * Revert "`char` -> `s8` for explicit padding in cmd structs" This reverts commit 59b9295828d0fa341b0f05fbe9d660adb04476aa. * `LENS_ACTOR_MODE_` -> `LENS_MODE_HIDE/SHOW_ACTORS`
2022-05-20Environment documentation pass (#1115)fig02
* some docs, start introducing time macro * most usages of CLOCK_TIME * finish up clock time defines, format * saving incase i need to revert * more docs * more docs progress * some more docs * format with 11 * change sos to storm * update functions.h * some depth stuff * review 1 and 2 * whoops * update zbuf stuff * most of review 3 * enum name * storm state enum * review 4 * fix enum * add comment to skyboxischanging * review * things dont match, committing so i can change branches * revert struct changes * define for override_full_control * new clock_time macro * fill alpha -> glare strength * update comment * remove indoor/outdoor, new name for underwater light variable * remove copy pasted comment * fix comments * remove whitespave * review
2022-05-20Document `eventChkInf` usage of freed carpenters flags (#1210)Dragorn421
* Document `eventChkInf` usage of freed carpenters flags * +`()`
2022-05-20Document SkelCurve system (#1192)EllipticEllipsis
* Rename and document SkelCurve * AVOID_UB in DemoTreLgt_OverrideLimbDraw * Rename code_8006C510 * Objdump flags in the makefile * Move CC_CHECK above compilation * Review 1 * Review 2 * Review 3 * Review Add doxygen comments to file head use angle macro, improve bug comment, make arguments of SkelCurve_Draw more consistent, Change this temp to pad in MagicWind
2022-05-18Gameplay_ -> Play_ and this (#1229)fig02
2022-05-17Doc misc 5 (#1223)Dragorn421
* Annotate global equip and upgrade masks data * Trivial respawn doc stuff Move the respawn mode enum up to use the _MAX enum value in the save context struct * Comment on the `sceneFlags[127]` debug-strings-suggested out-of-bounds access * Reword `room_inf[127]` comments (attempt)
2022-05-15Fix misc 12 (#1222)Dragorn421
* (light) `src` to `src/code/code_8006C510.c` * `setup + entrance` -> `entrance + setup` * Decimal for `gdSPDefLights1` args (colors, unit vector) * Run formatter * `firstDone` bool -> `materialFlag` * `ENTR_MAX`: 0x613 -> 0x614 * revert `materialFlag` to bool++ for now
2022-05-12Document Sub-Cameras (#989)engineer124
* Copying SubCam Changes from PR 908, made it to the end of bosses * Finish copying over PR * format * More cleanup * clean-up * PR Suggestions, Clean-Up, Improvement in CS * Remove substructs from fd/fd2 * format * Improve fishing * minor fix * Make CutsceneCameraDir more general * `sActiveCamMove` -> `sCamMove` * Fix conflict with object kankyo * Add CAM_ID_MAIN to object_kankyo * Improve cam cutscenes further * Revert cutscene cmd names (better for a separate PR) * At -> LookAt in the context of Cutscenes * Missed naming in diving game * Format * Fill in Ganon2 Names (now that it's matching) * format * `sActiveCamId` -> `sReturnToCamId` * activeCamId -> returnToCamId * Discord Discussions * FIRST * Move macro to bottom, comments * More suggestions * PR suggestion, cleanup comment * Oops * add comments * Adjust comment * Change edge-case * whoops Co-authored-by: fig02 <fig02srl@gmail.com>
2022-05-12Remove many redundant parentheses (eg. in boolean conditions) (#1220)Roman971
* Remove many unnecessary parens around boolean conditions * Remove duplicate parens in some expressions * Apply review suggestions * Update src/overlays/actors/ovl_Bg_Jya_Lift/z_bg_jya_lift.c Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com> Co-authored-by: EllipticEllipsis <elliptic.ellipsis@gmail.com>
2022-05-10Various minor cleanups (#1218)Roman971
* Fix assert in z_en_horse.c * Fix UB sceneFlags access in z_en_elf.c * Add Object_Spawn to public object functions This function is used externally in MM and works as a standalone, so it most likely belongs to the public interface * Fix float literals to always use lowercase e for the exponent * Remove "mininap" in one of the map data variables sDgnMinimapTexIndexBase is also used for the pause menu map so naming it for the minimap turned out to be inaccurate
2022-05-09Introduce DEFINE_ENTRANCE for entrance table and create entrance enum (#1213)fig02
* entrance table OK * entrance enum fixed * most entrances using enum, still need to do conditionals * more entrances * entrance_table.h cleanups * some review * remove _0 from first entrance in a group of setups * change table description * typo * wens spellcheck in vscode * remove extra line
2022-05-09Audio Ocarina Documentation (#1026)engineer124
* Begin ocarina documentation * Many ocarina-related docs * More ocarina docs * Introduce Ocarina Fonts Enum * Fix ocarina font enum * Fix incorrect documentation, more documentation * Ocarina recording documentation * cleanup * Small touch-ups * Fix font -> instrument * format * Better docs on playback, memory game * more cleanup * Add z64ocarina.h * Clean up names * final cleanup * typo * Fix description * better docs * Fix channel -> channelIdx * Fix old "font" name to correct "instrument" name, add io port docs * Add comments to clarify certain lines/functions * format * Rename noteIdx to pitch * Missed a name * Add comment on pitch * `reset` -> `SetInstrument` and `displayed` -> `playback` * Clarify audio_update and windmill comment * Minor PR fixes * Revert Audio_Update because there are 2 different Audio_Update functions * PR Feedback * Ocarina Idx -> Index * Introduce OCARINA_BTN_C_RIGHT_OR_C_LEFT * PR Suggestions * Next PR Suggestions * Next PR Feedback * consistency * Better docs (PR) * Better comment
2022-05-08Fixup weird horse flags usage (#1214)Dragorn421
* wip: refactor flag defines for `eventInf[0]` * Cleanup attempt * run formatter * remove spacing in enum indices comments * Add line breaks * Macros +`()` -`;`
2022-05-08Restructuring Camera Structs and Related Macros (#1108)engineer124
* Proof-of-concept * small cleanup * static to fixed * Update to new names * Use full names for structs * Update comments * PR 1 * More macro changes * More PR Suggestions * Use a union for funcData * Apply change to all cam structs * typedef union outside of cam struct * Add size * typedef union, not struct * funcData -> paramData * Better manage doorParams
2022-05-07HealthMeter_ -> Health_ (#1202)engineer124
* HealthMeter_ -> Health_ * PR Suggestion
2022-05-07Cleanup `pad`'s in z_scene_table.c (#1215)engineer124
* cleanup * More cleanup
2022-05-04Fix misc 11 (#1209)Dragorn421
* Pass boolean for `freezeFlag` to `Actor_SetDropFlag` * Use `else if`s in `func_80835F44` * Cleanup `transitionCtx` usage of instance data * `TransitionContext.setEnvColor` -> `TransitionContext.setUnkColor` * Fixup one comment * linebreaks (#1) * Run formatter Co-authored-by: fig02 <fig02srl@gmail.com>
2022-05-04Name rsp ucodes and surrounding cleanup (#1166)Tharo
* Name rsp ucodes and surrounding cleanup * Fix comments alignment and remove unnecessary & in sys_ucode * Change capitalization of sys_ucode variables * Remove unnecessary externs for aspMain * Improvements to Jpeg_ScheduleDecoderTask * Split unknown rsp code into a separate file, spacing
2022-05-02Memstuff (#1164)EllipticEllipsis
* Un-fake a couple of matches in memory manip functions * Document fmodf * Un-fake a couple of matches in memory manip functions * Document fmodf * Rename functions and files * Document memmove, memsets, memcpys * Format * Sort out some missing sizeofs * Name fmodf * Rename local variables * size_t * Use COBRA_SHADOW_TEX_SIZE * Review * Tweak the Doxyfile to remove @brief requirement * Roman's review * Fix a bug comment * Change fmodf
2022-05-01Improve the state of handwritten assembly files (#865)Tharo
* Format all handwritten asm and document some * Use c preprocessor for constants * Fix * Fix PI_STATUS_ERROR, some label improvements * Avoid hi/lo for constants * Some more comments * Properly mark functions as functions and their sizes * Fix merge * Improvements * Review suggestions, rework procedure start/end macros to be more like libreultra * Move IPL3 symbol definitions into ipl3.s * Fix undefined_syms, add include and language guards to asm.h and fix the comment in gbi.h * Consistent hex capitalization, add some MIPS builtin defines to CC_CHECK to behave properly * Add -no-pad-sections assembler option and clean up alignment in gu files and bzero * Further suggestions and improvements * Matrix conversion function clarifications * Fix passing AVOID_UB to gcc * Suggestions * Suggestions, global interrupt mask improvements * Further suggestions, interrupt mask comments * Comments fixes, rdb.h * Switch from # comments to // comments, remove unnecesary .set gp=64 directives * Further review suggestions * Missed one
2022-04-30Doc equips usage (inventory, current and player-specific constants) (#1142)Dragorn421
* Doc equips usage (inventory, current and player-specific constants) * Improve some comments * `currentSword`(`Item`) -> `currentSwordItemId` * Comments on the right in `D_801261F8` * Improve `sDebugSaveInventory.equipment` formatting with extra parentheses * Use constants for `sNewSaveInventory.equipment` * Run formatter * Make comments in z64save.h header a single line even if very long * `CHECK_OWNED_EQUIP_ALT` * One more use of `CHECK_OWNED_EQUIP` * `OWNED_EQUIP_FLAG` * `OWNED_EQUIP_FLAG_ALT` * Improve (?) giving sword by item id * "half-byte" -> "nibble" * Improve equips for setting kokiri sword * Improve (?) checking boots by item id * Improve (?) checking equips by item id * Fixup one spot assuming `EQUIP_TYPE_SWORD == 0` * Comments on the right in `sBootDListGroups`
2022-04-30Fix misc 10 (#1208)Dragorn421
* Cleanup around `Item_DropCollectible` * Cleanup around `Math3D_Vec3fDistSq`, `Math3D_Dist2DSq` * Material/Model naming for one dlist pair * Minor comments fixup * Explicit `!= NULL` check * Signed decimal for an array of coordinates * Fixup comments some more
2022-04-29Cleanup `clang-format off` (#1195)Dragorn421
* Run formatter * Remove useless `// clang-format off` * Improve manual formatting inside `clang-format off` blocks * Remove `// clang-format off` where used only for code style formatting * Remove some `// clang-format off` with a for loop "trick" * Reduce the size of `clang-format off` blocks * Remove one `clang-format off` by moving assignment to inside line * Revert "Remove some `// clang-format off` with a for loop "trick"" This reverts commit 30c344b800f22cc45cc30c8c88ce014715cdfed0. * Put some `// clang-format on` back on the same level as `off`
2022-04-29Fixup `feetFloorFlags` doc and -> `feetFloorFlag` (#1180)Dragorn421
2022-04-29Defines for `SaveContext` flags (`eventChkInf`, `itemGetInf`, `infTable`, ↵Dragorn421
`eventInf`) (#1094) * script-assisted `itemGetInf` flags * comment near non-trivial `itemGetInf` usage * Run formatter * Try something with the itemgetinf flags that can't use the packed value * Add defines for `eventChkInf` (direct access) * Add defines for `eventChkInf` (access through `Flags_GetEventChkInf`) * Add defines for `eventChkInf` (access through `Flags_SetEventChkInf`) * Add defines for `infTable` (direct access) * Add defines for `infTable` (used by `Flags_GetInfTable`) * Add defines for `infTable` (used by `Flags_SetInfTable`) * Add defines for `eventInf` * parenthesis cleanup near `GET_EVENTCHKINF` usage * parenthesis cleanup near `GET_ITEMGETINF` usage * parenthesis cleanup near `GET_INFTABLE` usage * fixup one `eventInf` usage * parenthesis cleanup near `GET_EVENTINF` usage * parenthesis cleanup near `Flags_GetEventChkInf` usage * slight `z64save.h` formatting improvement * Improve itemGetInf flags in z_bg_dy_yoseizo * Questionable improvement in z_en_ge2 * Questionable improvement in z_en_daiku * Questionable improvement in z_en_mu * Run formatter * Parentheses around `gSaveContext` macros arguments * Move individual flags define to the end of z64save.h, and improve comments separating the groups
2022-04-27Document Transition System (#1131)fig02
* transition type enum * mode enum, start documenting some types * some more * use enums for entrance table * entrance table filled out * sceneLoadFlag -> transitionTrigger * sandstorm state/mode/type * done i think * fixes * clean up circle weirdness * circle use enum + fix texture names * fix * how did that even happen lol * jesus * review2 * some more review * most review, still some more to do * new transition trigger names * some of review * next type default
2022-04-24Angle cleanup - macros names (#1193)Dragorn421
* Move binang utility macros out of angle conversion macros block * `BINANG_TO_DEGF` -> `BINANG_TO_DEG_ALT` (it may even be warranted to name it _approx instead of _alt, unsure) * Add `BINANG_TO_DEG` (unused by oot) (for completeness) * `DEGF_TO_BINANG` -> `DEG_TO_BINANG_ALT` (again may even be _approx, or maybe _cam) * Add `DEG_TO_BINANG` (unused by oot) (for completeness) * `RADF_TO_BINANG` -> `RAD_TO_BINANG` * `RADF_TO_DEGF` -> `RAD_TO_DEG` * Cleanup argument names in angle conversion macros * Format for angle macros changes * Run formatter * Move `DEG_TO_BINANG_ALT`, `BINANG_TO_DEG_ALT` to z64camera.h * Remove `DEG_TO_BINANG`, `BINANG_TO_DEG` * Remove `_ALT` from `DEG_TO_BINANG`, `BINANG_TO_DEG` * Add comment about inaccuracy near `DEG_TO_BINANG`, `BINANG_TO_DEG` * run formatter * `CAM_` prefix on `DEG_TO_BINANG`, `BINANG_TO_DEG` macros * Revert "Remove `DEG_TO_BINANG`, `BINANG_TO_DEG`" This reverts commit 5321647e5b2e3538ef25325f41399e1dd3984656.
2022-04-23Name variables for Audio_PlaySoundGeneral (#1198)engineer124
* Rename variables and function * Improve comment * PR Suggestion * PR Suggestions * Revert back to `Audio_PlaySoundGeneral`, make a separate PR `Sound` -> `Sfx` * Oops, fixed that
2022-04-23Parameter/Item Misc Cleanup (#1201)engineer124
* Misc parameter cleanup * More cleanup * More cleanup * ia4, more readable * More comments * PR Suggestion
2022-04-23Improve matches in Interface_Draw (#1200)engineer124
2022-04-18document most navi enemies as enum type (#1110)playerskel
* document most navi enemies as enum type * enum value auto increments, add enemy default for 0 * also define and comment navi enemy tektite blue * Update include/z64actor.h Co-authored-by: mzxrules <mzxrules@gmail.com> * Update include/z64actor.h Co-authored-by: mzxrules <mzxrules@gmail.com> * Update include/z64actor.h Co-authored-by: mzxrules <mzxrules@gmail.com> * Update include/z64actor.h Co-authored-by: mzxrules <mzxrules@gmail.com> * Update include/z64actor.h Co-authored-by: mzxrules <mzxrules@gmail.com> * Update include/z64actor.h Co-authored-by: mzxrules <mzxrules@gmail.com> * apply navi enemy updates accepted so far * update names * review * review * freezzard -> freezard Co-authored-by: mzxrules <mzxrules@gmail.com> Co-authored-by: fig02 <fig02srl@gmail.com>
2022-04-08Message Queues, Threads, and surroundings cleanup (#1178)Tharo
* message queues, threads, and surroundings cleanup * Format, make the formatter prefer clang-format-11 if found * Fix __osThreadTail type * Q -> Queue, thread defines renamed * Reformat, add missing NULL * Suggested changes and further casting cleanup * Reformat * padmgr name fixes
2022-04-09Names for some view things (#1191)Robin Allen
* Names for some view things * Review: ORTHOGRAPHIC → ORTHO * Review: dirty → dirtyFlags * Review: Doc comment style * Review: Define constants in terms of each other * Review: Rename the ApplyToOverlay functions * Update include/z64.h Co-authored-by: fig02 <fig02srl@gmail.com> * Review: Better View_LookAtInternal doc * arg1 → mask * View_LookAtInternal → View_LookAtUnsafe * Review: View_SanityCheckEyePosition → View_ErrorCheckEyePosition * sViewNotInitialized → sLogOnNextViewInit * Remove VIEW_FORCE_ALL * near/far → zNear/zFar Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com> * lookAt → at Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com> * near/far → zNear/zFar * View_ApplyPerspective/Ortho: Remove from header instead of commenting * lookAt → at * Add fwd decls * Fix external view->at accesses * Missed these somehow * lookAt → at * Omit "Apply" in comments * dirtyFlags → flags * View_ApplyScissor → View_ApplyShrinkWindow * Update src/code/z_view.c Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> Co-authored-by: fig02 <fig02srl@gmail.com> Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com> Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
2022-04-03Fix misc 9 (#1183)Dragorn421
* Fix typo `tranform` -> `transform` * (may be controversial) `indexes` (noun) -> `indices`, both are correct but `indices` prevails in the repo currently, and seems prefered in technical contexts * Fixup one `@bug` * Fix typo `relfect` -> `reflect` * Rename and `@bug` `DemoTreLgt_OverrideLimbDraw` * Fixup `PLAYER_AP_` to `ARROW_` type conversion * `posModel` -> `modelPos` * `effSpawnPosModel` -> `effSpawnModelPos` * Gohma decay bug: Verified that timers do not prevent UB access * Reorder summation in a more meaningful way Co-authored-by: JoshDuMan <40190173+JoshDuMan@users.noreply.github.com>
2022-04-04Document Pushing Player: Bg Conveyors and Climbing Slopes (#1103)engineer124
* Document pushing Player * Cleaner and better names * Tiny cleanup * Add enum to func * PR Feedback * Change conveyor to `IsFloorConveyor` * Small touchup * Attempt at better comments * Clarify comments * Clarify comment further * Fix formatting * PR Feedback
2022-04-03Angle cleanup - miscellaneous (#1159)Dragorn421
* Add `BINANG_TO_RAD_ALT2` * Few hex constants in place of decimal cardinal angles * Use `BINANG_TO_DEGF` more * Use `DEG_TO_RAD(int)` for angle literals * `BINANG_TO_RAD_ALT(literal)` -> use `BINANG_TO_RAD` * Somewhat arbitrary literal angles cleanup
2022-03-21first pass (#1185)louist103
2022-03-20Angle cleanup - `DEG_TO_RAD` (#1157)Dragorn421
* Run formatter * Touch up angle macros (parentheses and hex constants) * Remove `DEGF_TO_RADF`, use `DEG_TO_RAD` instead * Remove `DEGTORAD`, use `DEG_TO_RAD` instead * Use `DEG_TO_RAD` more
2022-03-20Doc (partially) player model and anim code data (#1143)Dragorn421
* Doc (partially) player model and anim data * `Player_OverrideLimbDrawPause` -> `func_80091880` * Enum comments: use hex * Change `D_80853914` to 1D array, change accesses to use new macro `PLAYER_ANIM_BY_GROUP_AND_TYPE` * `PLAYER_ANIM_BY_GROUP_AND_TYPE` -> `GET_PLAYER_ANIM`
2022-03-19Angle cleanup - `BINANG_TO_RAD`, `BINANG_TO_RAD_ALT` (#1158)Dragorn421
* Run formatter * Touch up angle macros (parentheses and hex constants) * Add `BINANG_TO_RAD_ALT` * Swap `BINANG_TO_RAD` and `BINANG_TO_RAD_ALT` * Run formatter
2022-03-20Small collision_check improvements (#1172)Tharo
* COLSHAPE_INVALID -> COLSHAPE_MAX, variable names * Marked suggestions Co-authored-by: mzxrules <mzxrules@gmail.com> * true/false, SAC_ON define for sacFlags * SAC_ON -> SAC_ENABLE, intersection -> hitPos, revert ARRAY_COUNT use in CollisionCheck_ApplyDamage Co-authored-by: mzxrules <mzxrules@gmail.com>
2022-03-16Fix misc 8 (#1150)Dragorn421
* Use `s32` as type instead of `StackStatus` enum type * `bossLimbDl` -> `bossLimbDL` * Fixup comment refering to `Actor.velocity` by struct offset * Fixup `feetFloorFlags` doc and -> `feetFloorFlag` * Fixup `xyzDistToPlayerSq` comment * Make `SkelAnime.mode` comment refer to `AnimationMode` (<- `AnimationModes`) * Use enum names to refer to anim modes and break long lines in z64animation.h * `EnDha_OverridePostDraw` -> `EnDha_PostLimbDraw` * ichains cleanup * Scene command ids usage cleanup * Properly name unkXXX members as unk_XXX * change `gSceneCmdHandlers` length in variables.h too * Revert Unknown flags to unk0 & unk1 * Remove "current scene" mention from `Flags_*Unknown` as they aren't saved or loaded so not scene-specific * `Struct_8011FAF0`: unk_00, unk_04 * Run formatter * Do not break long lines in headers * Revert "Fixup `feetFloorFlags` doc and -> `feetFloorFlag`" This reverts commit c45b3611e7c8997d27807cfd1c9e1fbdaeb026fe.
2022-03-13More documentation for IrqMgr (#1144)Tharo
* doc irqmgr * Fix * Format * Review suggestions * Fix * Some more review * Further changes
2022-03-13Angle cleanup - `RADF_TO_BINANG` (#1155)Dragorn421
* Run formatter * Touch up angle macros (parentheses and hex constants) * Use `RADF_TO_BINANG` more
2022-03-12Doc player drawing (#1098)Dragorn421
* Introduce and use more enums and defines for equips and data involved in player drawing * `EQUIP_TYPE_`, `EQUIP_INV_`, `EQUIP_VALUE_` * Improve doc on ItemEquips/Inventory's `equipment` field * Run formatter * Add `PLAYER_MODELGROUPENTRY_*` for second index of `gPlayerModelTypes` * Name `PLAYER_MODELGROUPENTRY_*` from existing documentation * Partial doc on `PLAYER_MODELTYPE_*` * Some doc on `PLAYER_MODELGROUP_*` * Run formatter * Name and some doc/cleanup on the various player draw functions * Name symbols used for player position in pause menu * Name player override/post limb draw callbacks * `BOOTS_NORMAL` -> `BOOTS_KOKIRI` * `EQUIP_INV_SWORD_GIANTKNIFE` -> `EQUIP_INV_SWORD_BROKENGIANTKNIFE` * `currentSword` -> `currentSwordItem` to avoid confusion with `PlayerSword` enum * Make one constant more explicit * Document severe bug (not an issue by luck) * Some doc on `PLAYER_MODELTYPE_RH_FF` * Actually name most of `PlayerModelType` * Actually name most of `PlayerModelGroup` and improve comments * Make equipment in debug save data use equip enums * Name symbol for computing player's `bodyPartsPos` and fix struct access * Name right/left `HandType` symbols * Add `PlayerBodyPart` enum * Run formatter * Introduce defines for pause player render dimensions and cleanup viewport usage in pause drawing * Document `playerSegment` related usage * Run formatter * Revert player bodypart changes * Revert equips doc changes * Revert player model and anim data changes * Revert drawing-unrelated changes * Move `sTunicColors` tunic comments to after data